Following review by @hassec, I use static base64_encoding vector in both Exiv2::base64encode() and Exiv2::base64decode().
I'm a little uneasy about changes to the API of the shared object/DLL. I will investigate #890 during the release process. So I have a plan to identify this if it's an issue. I think it's OK. ``` 703 rmills@rmillsmm-local:~/gnu/github/exiv2/bmff/build $ nm --demangle lib/libexiv2.dylib | grep base64 00000000000384a0 T Exiv2::base64decode(char const*, char*, unsigned long) 0000000000038340 T Exiv2::base64encode(void const*, unsigned long, char*, unsigned long) 00000000001c33a0 s Exiv2::base64_encode 704 rmills@rmillsmm-local:~/gnu/github/exiv2/bmff/build $ nm -g --demangle lib/libexiv2.dylib | grep base64 00000000000384a0 T Exiv2::base64decode(char const*, char*, unsigned long) 0000000000038340 T Exiv2::base64encode(void const*, unsigned long, char*, unsigned long) 705 rmills@rmillsmm-local:~/gnu/github/exiv2/bmff/build $ ```main
parent
212f1b5ebb
commit
02477faf4e
Loading…
Reference in New Issue