From 36e848d4fe6bd4554597c84cb6c5f519c8e07af3 Mon Sep 17 00:00:00 2001 From: Rosen Penev Date: Fri, 10 Feb 2023 19:05:38 -0800 Subject: [PATCH] clang-tidy: replace memcpy with copy_n Found with bugprone-not-null-terminated-result Signed-off-by: Rosen Penev --- src/jpgimage.cpp | 2 +- src/value.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/jpgimage.cpp b/src/jpgimage.cpp index 865a4716..9247082a 100644 --- a/src/jpgimage.cpp +++ b/src/jpgimage.cpp @@ -1001,7 +1001,7 @@ int ExvImage::writeHeader(BasicIo& outIo) const { byte tmpBuf[7]; tmpBuf[0] = 0xff; tmpBuf[1] = 0x01; - std::memcpy(tmpBuf + 2, exiv2Id_, 5); + std::copy_n(exiv2Id_, 5, tmpBuf + 2); if (outIo.write(tmpBuf, 7) != 7) return 4; if (outIo.error()) diff --git a/src/value.cpp b/src/value.cpp index 728b0343..36b80451 100644 --- a/src/value.cpp +++ b/src/value.cpp @@ -471,7 +471,7 @@ size_t XmpValue::copy(byte* buf, ByteOrder /*byteOrder*/) const { write(os); std::string s = os.str(); if (!s.empty()) - std::memcpy(buf, s.data(), s.size()); + std::copy_n(s.data(), s.size(), buf); return s.size(); }