From 444a2680a3301f9dab6525bfff7f5027db27eee5 Mon Sep 17 00:00:00 2001 From: Robin Mills Date: Mon, 27 Apr 2020 07:26:00 +0100 Subject: [PATCH 1/2] fix_1121_CODEOWNERS_0.27 --- .github/CODEOWNERS | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 00000000..455e09bb --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,40 @@ +contrib/vs2019 sridharb1 + +# https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners +# # This is a comment. +# # Each line is a file pattern followed by one or more owners. +# +# # These owners will be the default owners for everything in +# # the repo. Unless a later match takes precedence, +# # @global-owner1 and @global-owner2 will be requested for +# # review when someone opens a pull request. +# * @global-owner1 @global-owner2 +# +# # Order is important; the last matching pattern takes the most +# # precedence. When someone opens a pull request that only +# # modifies JS files, only @js-owner and not the global +# # owner(s) will be requested for a review. +# *.js @js-owner +# +# # You can also use email addresses if you prefer. They'll be +# # used to look up users just like we do for commit author +# # emails. +# *.go docs@example.com +# +# # In this example, @doctocat owns any files in the build/logs +# # directory at the root of the repository and any of its +# # subdirectories. +# /build/logs/ @doctocat +# +# # The `docs/*` pattern will match files like +# # `docs/getting-started.md` but not further nested files like +# # `docs/build-app/troubleshooting.md`. +# docs/* docs@example.com +# +# # In this example, @octocat owns any file in an apps directory +# # anywhere in your repository. +# apps/ @octocat +# +# # In this example, @doctocat owns any file in the `/docs` +# # directory in the root of your repository. +# /docs/ @doctocat \ No newline at end of file From 848e5809615142e21ac9273b12ff87a4239783c9 Mon Sep 17 00:00:00 2001 From: Robin Mills Date: Mon, 27 Apr 2020 08:15:55 +0100 Subject: [PATCH 2/2] Fixed issue spotted in review. --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 455e09bb..06c5d3b1 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,4 +1,4 @@ -contrib/vs2019 sridharb1 +contrib/vs2019 @sridharb1 # https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners # # This is a comment.