From 6c0059b5a083abd1c76834fab56b9f83083f544e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Luis=20D=C3=ADaz=20M=C3=A1s?= <piponazo@gmail.com>
Date: Sun, 18 Apr 2021 14:46:43 +0200
Subject: [PATCH] cmake: Treat xmpsdk headers as system ones

This is done so that when we use EXIV2_TEAM_EXTRA_WARNINGS we do not get
warnings about XMPSDK (we do not want to deal with those)
---
 cmake/compilerFlags.cmake | 1 +
 src/CMakeLists.txt        | 2 +-
 unitTests/CMakeLists.txt  | 2 +-
 xmpsdk/CMakeLists.txt     | 4 ++--
 4 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/cmake/compilerFlags.cmake b/cmake/compilerFlags.cmake
index 1ee46cf7..4cda1f72 100644
--- a/cmake/compilerFlags.cmake
+++ b/cmake/compilerFlags.cmake
@@ -61,6 +61,7 @@ if ( MINGW OR UNIX OR MSYS ) # MINGW, Linux, APPLE, CYGWIN
         endif()
 
         add_compile_options(-Wall -Wcast-align -Wpointer-arith -Wformat-security -Wmissing-format-attribute -Woverloaded-virtual -W)
+        add_compile_options(-Wno-error=format-nonliteral)
 
         # This seems to be causing issues in the Fedora_MinGW GitLab job
         #add_compile_options(-fasynchronous-unwind-tables)
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 18a26b28..73dc5e75 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -133,7 +133,7 @@ set_target_properties( exiv2lib_int PROPERTIES
 )
 
 target_include_directories(exiv2lib_int PRIVATE ${ZLIB_INCLUDE_DIR})
-target_include_directories(exiv2lib PRIVATE 
+target_include_directories(exiv2lib SYSTEM PRIVATE 
     $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/xmpsdk/include>
     ${ZLIB_INCLUDE_DIR}
 )
diff --git a/unitTests/CMakeLists.txt b/unitTests/CMakeLists.txt
index bef0e2f5..45307fca 100644
--- a/unitTests/CMakeLists.txt
+++ b/unitTests/CMakeLists.txt
@@ -48,7 +48,7 @@ if (exiv2lib_COMPILE_DEFINITIONS)
     target_compile_definitions(unit_tests PRIVATE ${exiv2lib_COMPILE_DEFINITIONS})
 endif ()
 
-target_include_directories(unit_tests
+target_include_directories(unit_tests SYSTEM
     PRIVATE
         ${exiv2lib_INCLUDE_DIRECTORIES}
 )
diff --git a/xmpsdk/CMakeLists.txt b/xmpsdk/CMakeLists.txt
index 92317a76..8bb99d51 100644
--- a/xmpsdk/CMakeLists.txt
+++ b/xmpsdk/CMakeLists.txt
@@ -31,9 +31,9 @@ target_link_libraries(exiv2-xmp
         $<BUILD_INTERFACE:${EXPAT_LIBRARY}>
 )
 
-target_include_directories(exiv2-xmp
+target_include_directories(exiv2-xmp SYSTEM
     PRIVATE 
-        $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/xmpsdk/include>
+        ${PROJECT_SOURCE_DIR}/xmpsdk/include
         ${EXPAT_INCLUDE_DIR}
 )