63 Commits (0f0885b0d6251f1dae3cc6d013d600fae26b3cfd)

Author SHA1 Message Date
Kevin Backhouse b16cd52b88 Replace sprintf with snprintf. 4 years ago
Kevin Backhouse 2b84f4bd64
fix: zero initialize local variables. (#1743)
* Zero initialize local variables.

* Initialize xmpID_
4 years ago
Luis Díaz Más f30022d73d
Fix issues detected with PVS-Studio + other little improvements (#1689)
* avoid re-declaration of constant variables

* Replace pthreads critical section with std::mutex

* ci - better naming

* cmake - increase minimum version to 3.11. Use project DESCRIPTION

* fix - do not treat string::find() return type as bool

* remove conditions that were always true

* remove condition that were always false

* Remove EXV_HAVE_GMTIME_R which is not used anymore

* pixelWidth_ was inherited from Exiv2::Image

The width & height variables in the TiffImage class need to be mutable
to be able to change their values on the getters pixelHeight() and
pixelWidth() ... Do not ask me why ...

* Remove superfluous if

* pvs:V766 item with identical key added already

* pvs:V730 not all members were initialized (time)

* pvs:V730 not all members are initialized

* pvs:v668 no point in testing pointer against null after new

* pvs:V1048 variable assigned the same value

* replace c-style dynamic vector with std one

* pvs:547 fakeData is always true

* Remove useless constructor in derived class

* pvs:V690 modern way to disable copy-ctor

* Replace malloc/free with new/delete. No need to check for null

* pvs:V1028 cast operands and not result

* Remove custom MIN/MAX functions

* pvs:V595 pointer used before verified against null

* pvs: index used before being checked

* pvs:V1028 possible overflow. Cast operands

* pvs:v575 potential null pointer passed to other functions

* pvs:V547 deal with always true/false expressions

* pvs:V560 part of conditional expressions always false or true

* pvs:V701 possible break in realloc -> move to std::vector

* Make some classes 'final'

* Replace sprintf with std::to_string()

* fix compilation on windows
4 years ago
Rosen Penev 2c57f214c5 clang-tidy: use nullptr
Found with modernize-use-nullptr

Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev 743da1a564 clang-tidy: use C++ casting
Found with google-readability-casting

Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev cdbee3c26c clang-tidy: init in member initializer
Found with cppcoreguidelines-prefer-member-initializer

Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev f9d394adf0 clang-tidy: run through performance checks
Found with performance*

Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev b8712188bb clang-tidy: use auto
Found with modernize-use-auto

Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev 4aa5566cf6 clang-tidy: make several member functions const
Found with readability-make-member-function-const

Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev fddb035106 clang-tidy: remove pointless const
Found with readability-avoid-const-params-in-decls

Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev 80595f8468 clang-tidy: remove duplicate public
Found with readability-redundant-access-specifiers

Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev 15f0a600ed clang-tidy: use default member init
Found with modernize-use-default-member-init

Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev bd6a996181 clang-tidy: use using
Found with modernize-use-using

Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev 8128716287 clang-tidy: use = default
Found with modernize-use-equals-default

Ran through git clang-format

Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev 4ceb325c8f clang-tidy: range for loop conversions
Found with modernize-loop-convert

Ran through git clang-format.

Also removed several questionable loops and replaced with simpler
algorithms.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Luis Díaz Más 83dda6ccd7 Fix warnings related to -Wdeprecated-copy 4 years ago
Luis Díaz Más 0bbaa6eff3 cpp: Replace auto_ptr by unique_ptr 4 years ago
Robin Mills 4a8d365e80 fix_1508_enableBMMF_effort2 4 years ago
Robin Mills 9da2aed5d2 Use the documented 5 line prolog in every sample application. Tidy up sample prologs and header code. 4 years ago
Robin Mills d632988bbd Massive code prolog cleanup. 4 years ago
Robin Mills da1b02d644 fix_1268_GPSProcessingMethod 5 years ago
clanmills 8f5b740270 put them back. 5 years ago
clanmills 79b37ec3aa Putting geotag.cpp back into the product (git strikes again) 5 years ago
Robin Mills cd9ee99567
Delete geotag.cpp 5 years ago
clanmills d994161e80 Added option -remove to samples/geotag.cpp 5 years ago
clanmills 759ce9fffe fix_1046_sample_geotag Take advantage of fix to #1046 in samples/geotag.cpp 5 years ago
clanmills 13565be3d2 Change for solaris. 5 years ago
Robin Mills 7844b11e4b
[xmpsdk] Add XMP Initialisation/Cleanup code to all main() programs
- update documentation
- Removed redundant calls to Exiv2::XmpParser::terminate() (legacy of our
  discusssion with @tester0077).
- this fixes #976
6 years ago
Luis Díaz Más 113136e134 Replace DEBUG with EXIV2_DEBUG_MESSAGES
Fixes #926
6 years ago
Luis Díaz Más 2d1e1fe6ef Reduce the scope of variables 7 years ago
Luis Díaz Más dc7eb5008b Add explicit to constructors with 1 argument 7 years ago
Luis Díaz Más c43d998457 Fix cppcheck issues: passedByValue 7 years ago
Luis Díaz Más 989acd18c7 Fix cppcheck issues: uninitMemberVar & uninitVar 7 years ago
Luis Diaz Mas 773bdfd14e Create a header where to keep an unique definition of UNUSED 7 years ago
Luis Díaz Más d55b2b1b65 Remove HAVE_STDLIB_H check and replace stdlib.h by cstdlib 7 years ago
Mario Emmenlauer 548d7688c7 samples/geotag.cpp: fixed debugging code to be in the correct ifdef 7 years ago
tbeu 5df8b01b77 Remove obsolete svn revision 8 years ago
clanmills 038fe6cb94 #1233 Fixed bug in samples/geotag.cpp 8 years ago
Robin Mills 1b536bd0ed #2130 Don't build conntest. Build is broken when --enable-webready. Fixed issue with samples/geotag.cpp on Linux. 9 years ago
Robin Mills fcd0cb3e19 #1233 Correction to r4573 9 years ago
Robin Mills 86028dd46e #1233 Fixed issue on MacOS-X 10.4 (32 big big-endian PPC, 2003 OS) with realpath() and added additional images for future testing. 9 years ago
Robin Mills 80fd8ee333 #1233 geotag.cpp added option -ascii. The degree sign in the output was upsetting test harness on some platforms. 9 years ago
Robin Mills 24c032c2a2 #1233 Changes to geotag-test to avoid full paths. Added make geotag-test. Sanitized geotag.cpp code 9 years ago
Robin Mills bd16f3441e #1233 Thank You to Anton for reporting this and providing a patch. I've updated the test suite. 9 years ago
Andreas Huggel a57317f685 Some API policing 10 years ago
Robin Mills 4817df0a17 #936. Fix header file. 10 years ago
Robin Mills 856ddd323c #1029 Spell separator correctly everywhere (not seperator). 10 years ago
Robin Mills 0df8356a56 #1029. Thank You, Thomas for reporting this and providing the patch. 10 years ago
Robin Mills d393b0fa7e trunk: exiv2 v0.25 11 years ago
Robin Mills 94e6dcbf50 Fix cygwin compilation warning on geotag.cpp 11 years ago