1d095cf751
Removed tag handled separately
4 years ago
5bc444ff00
Use DataBuf rather than raw malloc.
4 years ago
7c2ab1d7de
Check that the float is within the range of an int before casting.
4 years ago
0fab606e90
fix: incorrectly triggered enforce check during preview extraction in LoaderTiff::getData(), closes #1829
4 years ago
e34e150f22
Replace assertion with an error message.
...
(cherry picked from commit 4ec1768415ba015041a9bb28ab17c1ccf6a8c63e)
4 years ago
ed1db4ace2
Use std::round for rounding to nearest.
4 years ago
8d5e70379e
Update src/tags_int.cpp
...
Co-authored-by: Christoph Hasse <hassec@users.noreply.github.com>
(cherry picked from commit ad2e7221b498258bd04188b66f6da5cefd101e73)
4 years ago
52d70c8924
Check value is in range before casting from double to uint32_t, to avoid undefined behavior.
...
(cherry picked from commit 1455cc88466a14d8ea49935005e9de097984f012)
4 years ago
0e7d80fc84
Merge pull request #1826 from Exiv2/mergify/bp/main/pr-1820
...
Check that the string isn't empty (backport #1820 )
4 years ago
db25089c6f
Merge pull request #1823 from Exiv2/mergify/bp/main/pr-1818
...
Fix memory leak in pngimage.cpp (backport #1818 )
4 years ago
34aa899513
Merge pull request #1825 from Exiv2/mergify/bp/main/pr-1814
...
jp2image.cpp: check size before allocation to avoid out-of-memory errors (backport #1814 )
4 years ago
644aaaac92
Check that the string isn't empty
4 years ago
ffde235336
Add comment to explain the bounds-check.
4 years ago
67e2ef5ccd
Check size before allocation to avoid out-of-memory errors.
4 years ago
8f889c132e
Corrected JPEG XL file type
4 years ago
c641116b25
Add static_cast to fix build error on Windows.
4 years ago
b8ed3867c0
Use DataBuf, rather than new[], for automatic delete when an exception is throw.
4 years ago
dd4659ce2d
Add bounds-check to prevent out-of-bounds read in memcmp.
...
(cherry picked from commit a6253799d4e3727e32e6412798dceca4200efdda)
4 years ago
0144209ed0
Add SonySInfo1 makernote tags (tag 3000)
...
Add all tags, except the face detection sub-groups and related
bookkeeping values.
Source: Exiftool (https://exiftool.org/TagNames/Sony.html )
4 years ago
2488fc82e9
Merge pull request #1804 from kevinbackhouse/FuzzMore
...
Add fuzzing dictionary and test all printStructure() options
4 years ago
e086c7cbd2
add Canon EF 100-400 2x, and make size of aperture lens matching delta dependent on teleconverter factor
4 years ago
7d2f2d2526
make the ifdef in getExiv2ConfigPath a bit more minimal
4 years ago
95c2c26747
Fixes for Max and Win
4 years ago
6d5407e851
first search cwd for config file then check home dir
4 years ago
6fd6c8b3dd
fix: SIGSEGV on parsing of config file. (introduced in main by clang-tidy fix)
4 years ago
22b876d278
Merge pull request #1800 from postscript-dev/add_SonyMisc3c_tags
...
Add SonyMisc3c makernote tags (tag 9400)
4 years ago
593fcbd865
Add fuzzing dictionary and test all printStructure() options
4 years ago
35a2b25d64
Fix build error when EXIV2_DEBUG_MESSAGES is enabled.
4 years ago
2532f6db40
Add `markerHasLength` utility function.
4 years ago
96b85751ee
Add comment to explain bounds-check.
4 years ago
10bd09871f
Update src/jpgimage.cpp
...
Co-authored-by: Christoph Hasse <hassec@users.noreply.github.com>
4 years ago
fed192dc97
Fix compiler warning.
4 years ago
483a1497a0
Improved handling of jpg segments to avoid out-of-bound reads.
4 years ago
deb41bd117
bufRead needs to be adjusted after seek()
4 years ago
cc9d780534
Add SonyMisc3c makernote tags (tag 9400)
...
Changes:
+ Add tags. Rename Exiftool `SequenceLength` tags to `SequenceLength1`
and `SequenceLength2`, to prevent a name clash.
+ Update docs and manpage.
Source: [Exiftool](https://exiftool.org )
4 years ago
01b109e8ff
Merge pull request #1798 from Exiv2/mergify/bp/main/pr-1789
...
&bytes[0] (std::vector) will crash if bytes has zero elements (backport #1789 )
4 years ago
c3239e3187
&bytes[0] will crash if bytes has zero elements.
...
(cherry picked from commit 3e72d129e53b14e0b62d74aefed6bbd326562d63)
4 years ago
9004fb5a97
Remove redundant check.
...
(cherry picked from commit 19026fab2bc2b6dee2150f38153feb65a41cea17)
4 years ago
07225c05ee
Make sure that read is complete to prevent infinite loop.
...
(cherry picked from commit ffe5eb517dad93845e62144d8e53f52b17420ecd)
4 years ago
7251a96da6
remove exv_grep_keys_t type alias
4 years ago
d6c82b88bc
refactor: avoid unused variable warning of regex_error
4 years ago
687b38a130
refactor: use POSIX regex syntax as that is what was used before
4 years ago
d82980b563
refactor: replace old linux regex.h with regex from STL.
4 years ago
944e68fa15
Merge pull request #1787 from Exiv2/mergify/bp/main/pr-1766
...
Extra checking to prevent loop counter from wrapping around (backport #1766 )
4 years ago
686702616c
Merge pull request #1794 from kevinbackhouse/bmff-check-box-nesting
...
Enforce BMFF box nesting
4 years ago
3575a8258e
Merge pull request #1786 from Exiv2/mergify/bp/main/pr-1769
...
Safer std::vector indexing (backport #1769 )
4 years ago
9aabdcf698
fix: add Sigma 30mm f/1.4 DC DN | C to canon lens detection
4 years ago
5eb464271e
Fix format specifier.
4 years ago
43d95b8a75
Fix compiler warnings.
4 years ago
3019fbee4f
Extra protection against large allocations.
4 years ago
78e9c8aa82
address + box_length == box_end
4 years ago
02d4ef2c5e
Support for 64-bit box lengths looked broken.
4 years ago
8c64e9abba
Add `pbox_end` param to `BmffImage::boxHandler` to enforce box nesting.
4 years ago
293fd586ab
Add SonyMisc2b makernote tags (tag 9404)
...
Changes:
+ Add tags, pretty printing and tag group selector function
+ Update docs
Source: https://exiftool.org/TagNames/Sony.html
4 years ago
b82084995c
Add `getExifValue()` to `makernote_int.cpp`
...
Function generalizes `getExifModel()`, allowing any value in a tag to
be accessed.
4 years ago
eb2782e685
Fix warning: comparison of integer expressions of different signedness
4 years ago
67a46f742d
Type of escapeStart should be size_t.
4 years ago
670dfb2fab
Better fix for potential integer overflow in `bytes.size() - 3`.
4 years ago
69d82ffe01
Defensive coding changes to avoid integer overflow in loop conditions.
4 years ago
ad5e6c479c
Extra checking to prevent the loop counter from wrapping around.
4 years ago
dc2c77ce81
Safer std::vector indexing.
4 years ago
82057a6a1d
Merge pull request #1777 from postscript-dev/update_sony2fp_tags
...
Update Sony2Fp tags
4 years ago
d5ada325af
Check that `type` isn't an empty string.
4 years ago
510a38e27d
Move all `startsWith()` funcs to `Util` namespace
...
The function checks if a string is in the beginning of another. This
is intended for use until the move to C++20 when
`std::basic_string<>::starts_with()` becomes available. Suggested in
https://github.com/Exiv2/exiv2/pull/1777 .
Separate identical definitions have been moved into a single copy.
4 years ago
0827a76b6a
Update Sony2Fp makernote functions
...
Minor changes using suggestions in #1777 :
+ Simplify loop conditions
+ Add startsWith() in SonyMakerNote class
+ Change `if`/`else` to `switch`
4 years ago
e4e3362284
Defensive programming in Image::printIFDStructure
4 years ago
caf08b229e
dirLength == 0 can cause an infinite loop.
4 years ago
0208b508a0
Merge pull request #1773 from kevinbackhouse/fuzz
...
Add fuzz target
4 years ago
fa52d7e2cb
Better way to print the error message.
4 years ago
6685b8db4a
Print message to stderr when EXIV2_DEBUG_MESSAGES is enabled.
4 years ago
f724f4e2fc
Don't crash if s > size.
4 years ago
e821404d69
Merge branch 'update_sony2fp_tags' of https://github.com/postscript-dev/exiv2 into update_sony2fp_tags
4 years ago
4a21b45e60
Update Sony2Fp makernote tag selector function
...
In C++20, std::string has a starts_with() function. Add a startsWith()
function now, which can be replaced when the project moves to C++20.
Suggested in https://github.com/Exiv2/exiv2/pull/1777
4 years ago
670c89b2bd
Merge branch 'Exiv2:main' into update_sony2fp_tags
4 years ago
4ac8ac9ba0
Update Sony2Fp makernote tags (tag 9402)
...
Changes:
+ Add pretty printing for all tags
+ Add camera selector, to prevent incompatible models using tags
+ Update testing with new values
Source: Exiftool (https://exiftool.org/TagNames/Sony.html )
4 years ago
6798be637f
Merge pull request #1774 from Exiv2/mergify/bp/main/pr-1745
...
fix: avoid processing MOV (quicktime) files when BMFF is enabled (backport #1745 )
4 years ago
7b3dd26c23
Merge pull request #1718 from opengisch/ios
...
Fix building for ios
4 years ago
eb22591cea
Fix formatting of sonyMisc1 makernote tags
4 years ago
3e681c6730
fix: avoid processing MOV (quicktime) files when BMFF is enabled
...
(cherry picked from commit 1b6895927f293855e5bb437ad28f31da2c2cfe54)
4 years ago
bf786f4cc6
Updates to make fuzzing work.
4 years ago
2b8856dcea
Add SonyMisc1 (Tag 0x9403) makernote tags
...
Source: Exiftool (https://exiftool.org/TagNames/Sony.html )
4 years ago
033175e127
Don't deref end iterator.
4 years ago
43fe7bbb98
Add Exif.Image.PageName tag ( #1765 )
...
* Add Exif.Image.PageName tag
* Add trailing punctuation mark to PageName and DocumentName tags description.
* Add XPosition and YPosition TIFF tags
4 years ago
ff00771425
Better bounds checking in Jp2Image::printStructure
...
(cherry picked from commit 0fcdde80997913dde284ea98f06f9305d06cb160)
4 years ago
c2b52119d4
Check that findKey didn't return end().
4 years ago
98fb218475
Throw exception if lens info wasn't found.
4 years ago
d30c95d07e
fix incorrect loop condition ( #1752 )
4 years ago
5ab3f2b0c5
Defensive coding to avoid 0x80000000/0xFFFFFFFF FPE.
4 years ago
11a26fb0d4
Prevent divide-by-zero crash.
4 years ago
8c4d67ca50
Defensive coding to avoid 0x80000000/0xFFFFFFFF FPE.
4 years ago
d5b7f99fbf
Three tag descriptions corrected
4 years ago
37fea97dd3
clang-tidy: use override
...
Found with modernize-use-override
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
b84d8e9a44
clang-tidy: use auto
...
Found with modernize-use-auto
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
9210fb85f9
clang-tidy: pass by value
...
Found with modernize-pass-by-value
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
b16cd52b88
Replace sprintf with snprintf.
4 years ago
2fbf2e6b7c
clang-tidy: remove dedundant initializer
...
Found with readability-redundant-member-init
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
a4c5bdac19
fix: stricter date parsing in value.cpp ( #1720 )
...
* Regression test for issue 1713
* Stricter date parsing.
* Fix test failure caused by stdout mismatch.
(cherry picked from commit ab58026cff0e5edebc026261e9dc4b7db05b802d)
4 years ago
1d64f482ff
fix: use vector::at() rather than operator[] (backport #1735 ) ( #1741 )
...
* fix: use vector::at() rather than operator[] (#1735 )
* Regression test for https://github.com/Exiv2/exiv2/issues/1706
* Use vector::at() rather than operator[].
* Print to stderr when exception is caught and EXIV2_DEBUG_MESSAGES is enabled.
* Check that it prints "Bad value" for the date.
(cherry picked from commit f4d3adbf91e6dc4e34aee5bac7b7fd9e127a5c00)
# Conflicts:
# src/value.cpp
* fix merge conflicts from mergify backport
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>
Co-authored-by: Christoph Hasse <hassec@users.noreply.github.com>
4 years ago
2b84f4bd64
fix: zero initialize local variables. ( #1743 )
...
* Zero initialize local variables.
* Initialize xmpID_
4 years ago
3e099da7b7
Remove obsolete snprintf macros.
4 years ago
2539e5dd7e
fix: change duplicated Canon RF 100-500 2x into missing 1.4 teleconverter version
4 years ago
704ee571de
fix: allow for FX.Y syntax in aperture regex
4 years ago
fa78ab3593
Use official Canon RF lens model names
...
The new RF line is named F2.8L instead of f/2.8L (for example).
This patch makes the model names identically to the official
Canon lens names and the same names exiftool uses.
4 years ago
2f83b7e0f6
Merge pull request #1692 from Exiv2/hassec_canon_lens_test
...
New Canon Lens Identification + Automatic Test of all Lenses
4 years ago
cfeceee416
add lens: Olympus M.ZUIKO DIGITAL ED 12-45mm F4.0 PRO ( #1725 )
...
* add lens ID for Olympus M.Zuiko Digital ED 12-45mm F4.0 Pro #1723
* add test for #1723 checking the Olympus M.Zuiko Digital ED 12-45mm F4.0 Pro recognized correctly
4 years ago
5aafb351e5
Fix building on ios
4 years ago
23dbf4f51a
correct identification for Tamron SP 24-70mm G2 A032 ( #1691 )
...
* correct identification for Tamron SP 24-70mm G2 A032 with LensType 0E (14)
Existing entry with LensType 4E is kept as it's needed as well
Added testcase for LensType 0E for Tamron_SP_24-70mm_F2.8_Di_VC_USD_G2
4 years ago
efb0af8506
fix: make casts explicit to please msvc
4 years ago
7867343611
fix: prefer symbolic boolean operators so windows is happy
4 years ago
bdd8a386b5
feat: improve lens recognition of canon makernote
...
If multiple choices are possible they are now all reported. This
behaviour is now the same as it is in exiftool.
All lenses are tested in the new test_canon_lenses.py test
4 years ago
907fe2369e
fix: readd some previously removed lenses now that we plan to trea ambiguous lenses
4 years ago
4ee8962d42
refactor!: use lensfun style nameing for lenses
4 years ago
56f9979a4b
Improve detection of Canon lenses with TC
...
Lenses with and without a TC may share the same lens ID. Prefer entries
that explicitly mention the TC.
4 years ago
9962b88db3
Fix misdetection of Tamron SP AF 300mm as Canon EF 75-300mm
...
When searching for the Tamron lens, only the string "300mm" is searched in
the lens description, which also happens to be present for the Canon lens.
Since the Canon lens comes first in the list, it wins. Fix this issue by
prefixing the search string with a single space so it always has to match
the full focal length specification.
4 years ago
477150f067
Fix rounding error in fnumber calculation
...
The mathematical calculation of fnumbers does not always match the expected
values: For example for f/3.5 the precise mathematical value is 3.564...,
which gets rounded to 3.6. Fix this special case by returning a value
closer to the expected value.
4 years ago
0d030eefdf
Remove undetectable lenses
...
Lenses that have the exact same ID, focal length and aperture as some other
lens that comes earlier in the list (and thus always wins):
* 137, "Tamron SP 17-50mm f/2.8 XR Di II VC"
* 137, "Tamron SP 24-70mm f/2.8 Di VC USD"
* 161, "Sigma 28-70mm f/2.8 EX"
* 173, "Sigma 180mm EX HSM Macro f/3.5"
* 180, "Zeiss Milvus 50mm f/1.4"
* 183, "Sigma 150-600mm f/5-6.3 DG OS HSM | S"
* 254, "Tamron SP 90mm f/2.8 Di VC USD Macro 1:1 F004"
* 254, "Tamron SP 90mm f/2.8 Di VC USD Macro 1:1 F017"
Lenses that share their IDs with other lenses, but have no or an
unsupported focal length:
* 33, "Voigtlander or Carl Zeiss Lens"
* 131, "Sigma 4.5mm f/2.8 EX DC HSM Circular Fisheye"
4 years ago
f30022d73d
Fix issues detected with PVS-Studio + other little improvements ( #1689 )
...
* avoid re-declaration of constant variables
* Replace pthreads critical section with std::mutex
* ci - better naming
* cmake - increase minimum version to 3.11. Use project DESCRIPTION
* fix - do not treat string::find() return type as bool
* remove conditions that were always true
* remove condition that were always false
* Remove EXV_HAVE_GMTIME_R which is not used anymore
* pixelWidth_ was inherited from Exiv2::Image
The width & height variables in the TiffImage class need to be mutable
to be able to change their values on the getters pixelHeight() and
pixelWidth() ... Do not ask me why ...
* Remove superfluous if
* pvs:V766 item with identical key added already
* pvs:V730 not all members were initialized (time)
* pvs:V730 not all members are initialized
* pvs:v668 no point in testing pointer against null after new
* pvs:V1048 variable assigned the same value
* replace c-style dynamic vector with std one
* pvs:547 fakeData is always true
* Remove useless constructor in derived class
* pvs:V690 modern way to disable copy-ctor
* Replace malloc/free with new/delete. No need to check for null
* pvs:V1028 cast operands and not result
* Remove custom MIN/MAX functions
* pvs:V595 pointer used before verified against null
* pvs: index used before being checked
* pvs:V1028 possible overflow. Cast operands
* pvs:v575 potential null pointer passed to other functions
* pvs:V547 deal with always true/false expressions
* pvs:V560 part of conditional expressions always false or true
* pvs:V701 possible break in realloc -> move to std::vector
* Make some classes 'final'
* Replace sprintf with std::to_string()
* fix compilation on windows
4 years ago
758dd6bbc6
refactor!: remove free() function from DataBuf to avoid potential problems, see #1542
4 years ago
2c57f214c5
clang-tidy: use nullptr
...
Found with modernize-use-nullptr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
86c71ae6c3
clang-tidy: avoid global non const variables
...
Found with cppcoreguidelines-avoid-non-const-global-variables
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
d1e116a8ef
remove some pointless std::set
...
Partially found by gcc's -fanalyzer
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
4c4f8da338
remove initializers
...
these were moved outside the constructor body.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
e5894d71e1
default con/destructors in headers
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
ce47de67b5
use auto in template
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
c44c289d76
clang-tidy: fix ending namespace comnments
...
Found with llvm-namespace-comment
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
a74bceacb0
clang-tidy: remove pointless return
...
Found with readability-redundant-control-flow
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
743da1a564
clang-tidy: use C++ casting
...
Found with google-readability-casting
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
8dbc699858
clang-tidy: add missing explicit
...
Found with google-explicit-constructor
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
ff39473c18
clang-tidy: convert to static
...
Found with readability-convert-member-functions-to-static
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
6da49fd29b
more constexpr
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
cdbee3c26c
clang-tidy: init in member initializer
...
Found with cppcoreguidelines-prefer-member-initializer
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
036af68a71
remove pointless constructors
...
Replaced with Uniform initialization. Allows constexpr usage.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
8564d0b394
clang-tidy: pass by value
...
Found with modernize-pass-by-value
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
f9d394adf0
clang-tidy: run through performance checks
...
Found with performance*
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
b8712188bb
clang-tidy: use auto
...
Found with modernize-use-auto
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
20dfab8036
manual for range loop conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
8e52032ee0
clang-tidy: range loop conversions
...
Found with: modernize-loop-convert
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
c73dfa0106
clang-tidy: use uppercase numeric literals
...
Found with readability-uppercase-literal-suffix
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
8e178e912e
replace {} initialization with fill
...
Old compilers don't implement {} correctly.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
fdf9d3799c
clang-tidy: don't use else after return
...
Found with llvm-else-after-return
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
4aa5566cf6
clang-tidy: make several member functions const
...
Found with readability-make-member-function-const
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
24a8139233
clang-tidy: fix badly indented if
...
Found with readability-misleading-indentation
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
1b9b77c51f
clang-tidy: add ending namespace comments
...
Found with google-readability-namespace-comments
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
bf290e84e5
fix compilation with EXIV2_DEBUG_MESSAGES
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
3416b631c5
Add Sony ARW compression to dict
4 years ago
fddb035106
clang-tidy: remove pointless const
...
Found with readability-avoid-const-params-in-decls
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
80595f8468
clang-tidy: remove duplicate public
...
Found with readability-redundant-access-specifiers
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
ca66136092
Use readOrThrow to check error conditions of iIo.read().
...
(cherry picked from commit 0f9eb74c44c908e170a64cab590949d53749af8e)
4 years ago
5dc4292b40
fix bad for range loop
...
This loop is supposed to break when it encounters a match.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
091fd77885
clang-tidy: remove redundant member init
...
Found with readability-redundant-member-init
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
674fdcd38b
clang-tidy: fix declartation names
...
Found with readability-inconsistent-declaration-parameter-name
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
2e73aa9dc0
default con/destructors in headers
...
Helps to optimize trivially destructable stuff.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
428c436629
clang-tidy: simplify boolean expression
...
Found with readability-simplify-boolean-expr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
5d716c7df4
clang-tidy: empty() conversions
...
Found with readability-container-size-empty
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
9642e3cceb
clang-tidy: remove pointless string init
...
Found with readability-redundant-string-init
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
143a1fbbe2
clang-tidy: don't use string compare
...
Found with readability-string-compare
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
8337462032
clang-tidy: use empty() instead of comparing size
...
Found with readability-container-size-empty
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
af7b2430c5
clang-tidy: use override
...
Found with modernize-use-override
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
15f0a600ed
clang-tidy: use default member init
...
Found with modernize-use-default-member-init
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
170b18db74
Merge pull request #1621 from Exiv2/mergify/bp/main/pr-1591
...
Fix infinite loop caused by subBox with zero size. (backport #1591 )
4 years ago
b4b8061478
Early access is always compiled
4 years ago
566ea272a1
Prevent large allocation.
...
(cherry picked from commit f154f0ae540deeb9251467187d01c2a5846d27b5)
4 years ago
aac34630d4
Fix infinite loop caused by subBox with zero size.
...
(cherry picked from commit 2736126e7b92c5654f56620c097f9a4580c0f73b)
4 years ago
9dbffa719b
Add missing public headers to install target
4 years ago
5a9c29303e
clang-tidy: remove pointless static
...
Found with readability-static-definition-in-anonymous-namespace
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
bd6a996181
clang-tidy: use using
...
Found with modernize-use-using
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
b3040da54c
clang-tidy: don't check for NULL with delete
...
Found with readability-delete-null-pointer
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
1dc1186760
clang-tidy: simplify boolean expressions
...
Found with readability-simplify-boolean-expr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
8128716287
clang-tidy: use = default
...
Found with modernize-use-equals-default
Ran through git clang-format
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
57cad2619b
Add bounds check in Jp2Image::doWriteMetadata().
...
(cherry picked from commit e6a0982f7cd9282052b6e3485a458d60629ffa0b)
4 years ago
b675c58bab
Move include/CMake to src
4 years ago
1b4577904b
Fix MSVC build
4 years ago
bf0d8114c9
#525 : Update comment and fix variable name
4 years ago
94420ab591
Remove custom rwlock in favor of `std::mutex` of C++11
...
Current design on Windows was broken anyway, since legacy class `RWLock` does not implement a proper rwlock (shared read and exclusive write)
Once we are allowed using C++14 features, we can replace the `std::mutex` by `std::shared_timed_mutex` and the read-access locks by `std::shared_lock`.
Once we are allowed using C++17 features, we can replace the `std::mutex` by `std::shared_mutex` and the read-acces locks by `std::shared_lock`.
4 years ago
4ceb325c8f
clang-tidy: range for loop conversions
...
Found with modernize-loop-convert
Ran through git clang-format.
Also removed several questionable loops and replaced with simpler
algorithms.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
e93ad82734
clang-tidy: use braced init list
...
Found with modernize-return-braced-init-list
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
294372f2ad
cmake: revert change due to old cmake versions on CentOS & debian9
4 years ago
582edd399c
cmake: ignore PDBs warnings on Win/Debug/Static buils
4 years ago
9de534976f
msvc: fix compiler warning on x86
4 years ago
90dde02359
Win - Disable UNICODE which is failing at the moment
4 years ago
84220855b2
clang-tidy: use = delete
...
Found with modernize-use-equals-delete
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
53f18cf408
conan: use cmake_paths generator instead of cmake
...
We also upgraded the xcode version on Travis-CI
4 years ago
f601d23d5e
conan: update conan recipe versions
4 years ago
b3de96f4b4
Add more bounds checks in Jp2Image::encodeJp2Header
4 years ago
e366c786b9
Fix -Werror=shadow warning after recovering EPS
4 years ago
9b9154d137
fix warning (hiding local variable)
4 years ago
d5240a4bda
eps: Fix code after usage of unique_ptr. Remove deprecation tags
4 years ago
8314030604
Revert "Remove deprecated EPS format"
...
This reverts commit 537cdad99e
4 years ago
8388223deb
Check that the string is properly terminated.
4 years ago
e8422732af
Fix LGTM warning about format specifier
...
https://lgtm.com/projects/g/Exiv2/exiv2/rev/pr-6633ad1cc6e6c36bffd6655165c299c53e934b22
4 years ago
e97a9ff88a
Fix signed/unsigned compiler warning.
4 years ago
27e349e063
Fix signed/unsigned compiler warning.
4 years ago
285e7a4e72
Fix out-of-bounds read in bmffimage.cpp
4 years ago
783b3a6ff1
Improve bound checking in WebPImage::doWriteMetadata()
4 years ago
23c1cda99d
Fix signed/unsigned compiler warnings.
4 years ago
f930883919
Better bounds checking in Jp2Image::encodeJp2Header()
4 years ago
f85f7f717a
Replace many of the iterators types with auto
4 years ago
75e4bd9059
Remove rest of useless typedefs from datasets.hpp
4 years ago
01a3bc716d
Fix warnings in VS
4 years ago
75bf666d3b
Remove typedef to Dictionary::const_iterator
4 years ago
0a1bf46a1c
revert changes that are affecting to VS
4 years ago
de4d43d4d1
Fix warnings EXIV2_TEAM_EXTRA_WARNINGS
...
Most of the warnings fixed were:
- Hiding of local variables
- Hiding of globals
- Useless casts
- Conversions between float/double
4 years ago
6c0059b5a0
cmake: Treat xmpsdk headers as system ones
...
This is done so that when we use EXIV2_TEAM_EXTRA_WARNINGS we do not get
warnings about XMPSDK (we do not want to deal with those)
4 years ago
83dda6ccd7
Fix warnings related to -Wdeprecated-copy
4 years ago
3682bce15e
Fix Ubuntu 20.04/Release/Sanitizer test breaker
4 years ago
d73dd0874d
Fix icc_test which is failing on Linux:
...
luis@ryzenLinux:/media/linuxDev/programming/exiv2/buildReleaseSanitizers$ cp large.icc Reagan2.icc
luis@ryzenLinux:/media/linuxDev/programming/exiv2/buildReleaseSanitizers$ bin/exiv2 -iC /tmp/Reagan2.jp2
/media/linuxDev/programming/exiv2/src/jp2image.cpp:661:28: runtime error: reference binding to misaligned address 0x61f000002a9e for type 'const struct Jp2BoxHeader', which requires 4 byte alignment
0x61f000002a9e: note: pointer points here
07 07 01 00 00 00 0c 53 63 6f 6c 72 02 00 00 00 00 0c 48 4c 69 6e 6f 02 10 00 00 6d 6e 74 72 52
4 years ago
b5d3a1fd70
auto_ptr -> unique_ptr for code with WIN_UNICODE enabled
4 years ago
2de3bad869
Remove EXIV2_ENABLE_VIDEO and related stuff
4 years ago
3eb1eee7fe
Remove deprecated RiffVideo support
4 years ago
061ec1a75d
Remove deprecated QuickTime support
4 years ago
8dcc07887a
Remove deprecated Matroska support
4 years ago
94b87a8dec
Remove deprecated SSH support
4 years ago
384a5edfcf
Remove deprecated ASF Video
4 years ago
3ddef8f8b8
Correct GDS distance unit in description
...
knot is a measure of speed...
4 years ago
94adf1b038
Improve precision of GPS lat/lon printed values
4 years ago
3f3bbc28ad
Improve printing of GPS info
4 years ago
206a2c495c
fix_enableBMFF_v1
4 years ago
f700043a6d
Add Exif Gamma tag
4 years ago
ede33f5eba
Initialization of variables (fix issue detected with sanitizers)
4 years ago
5fcea2b4e2
Use stack variables instead of java style
4 years ago
0bbaa6eff3
cpp: Replace auto_ptr by unique_ptr
4 years ago
537cdad99e
Remove deprecated EPS format
4 years ago
9e6a520089
Merge pull request #1539 from Exiv2/FixIssue1530
...
Fix integer overflow
4 years ago
9b7a19f957
Fix integer overflow.
4 years ago
0a91b56616
Fix incorrect delete.
4 years ago
13e5a3e023
Fix out of buffer access in #1529
4 years ago
22ea582c6b
fix_1522_jp2image_exif_asan
4 years ago
aef9cf76f7
fix_1503_JXL_bmff
4 years ago
49cfe45323
Merge pull request #1513 from Exiv2/fix_1508_enableBMFF
...
Fix 1508 enable bmff
4 years ago
9da2aed5d2
Use the documented 5 line prolog in every sample application. Tidy up sample prologs and header code.
4 years ago
190106ca78
fix_1507_avif_size0x0
4 years ago
d632988bbd
Massive code prolog cleanup.
4 years ago
99600c6aaf
exiv2 --verbose --version was reporting have_strerror_r twice!
4 years ago
6fad24cd11
Merge pull request #1491 from Exiv2/fix_1486_effort2
...
fix_1486_effort2
4 years ago
717fc098be
fix_1486_effort2 https://github.com/Exiv2/exiv2/pull/1486#discussion_r593161473
4 years ago
f95d97a0bf
Add mif1 brand to heif mime type
4 years ago
fcb3066950
Include a few more BMFF major brands
4 years ago
b3dfabdde0
Merge pull request #1486 from Exiv2/fix_1484_empty_ascii
...
Terminate empty ASCII strings
4 years ago
ba6a577ab9
https://github.com/Exiv2/exiv2/pull/1486#issuecomment-796843835
4 years ago
09567b477b
Merge pull request #1487 from kmilos/housekeep_bmff
...
Include HEIC type explicitly
4 years ago
fa41e52c8a
Add comment and test case
4 years ago
bf1be5cb50
fix_1473_LocationShown
4 years ago
e3c78623f7
Include HEIC type explicitly
4 years ago
26ba26e241
Terminate empty ASCII strings as well
4 years ago
9e2ac47cf9
Merge pull request #1475 from 1div0/BMFF
...
Base Media File Format
4 years ago
02477faf4e
Following review by @hassec, I use static base64_encoding vector in both Exiv2::base64encode() and Exiv2::base64decode().
...
I'm a little uneasy about changes to the API of the shared object/DLL. I will investigate #890 during the release process. So I have a plan to identify this if it's an issue. I think it's OK.
```
703 rmills@rmillsmm-local:~/gnu/github/exiv2/bmff/build $ nm --demangle lib/libexiv2.dylib | grep base64
00000000000384a0 T Exiv2::base64decode(char const*, char*, unsigned long)
0000000000038340 T Exiv2::base64encode(void const*, unsigned long, char*, unsigned long)
00000000001c33a0 s Exiv2::base64_encode
704 rmills@rmillsmm-local:~/gnu/github/exiv2/bmff/build $ nm -g --demangle lib/libexiv2.dylib | grep base64
00000000000384a0 T Exiv2::base64decode(char const*, char*, unsigned long)
0000000000038340 T Exiv2::base64encode(void const*, unsigned long, char*, unsigned long)
705 rmills@rmillsmm-local:~/gnu/github/exiv2/bmff/build $
```
4 years ago
212f1b5ebb
Following review by @piponazo, I am clarifying the bool return from Exiv2::enableBMFF().
4 years ago
e3fd0c633e
Thank You @piponazo for the code review. I've made the changes you requested.
4 years ago
5f563b5255
Fix spelling mistakes in LangAltValue::read()
...
Removed unneeded comments and empty space.
4 years ago
0da1a50afe
Revert style changes
4 years ago
4c52861a74
Fix msvc build breaker.
4 years ago
e09d093ccf
Minor whitespace formatting
4 years ago
282d1d6995
Add static to LangAltValue::read() const values
4 years ago
f1303cbcda
Another effort to fix base64decode and associated unit test.
4 years ago
87e536dadf
Fix #1358 . This should be in a different PR. Keep changes to base64 encode/decode together.
4 years ago
db9bec3e01
Restore -pC --binary to output everything. Test suite updated to suit.
4 years ago
21c610e952
Restoring i < dataLength trigraph that I should not have removed.
4 years ago
2f2dd7d56c
Fix ICC profile handling (my bad, iOS files are correct).
4 years ago
c59c53acf5
Trick to avoid msvc issue with final line of base64 data.
4 years ago
1eeeecea50
Replaced Exiv2::base64encode() because last effort failed unit test on msvc.
4 years ago
6cd9263fa7
Fix langAltValue::read() parsing
...
+ Fix segmentation faults in langAlt parse
+ Fix mismatched quotation marks and incorrect values
+ Add Python testing
+ Some tests commented out as quotation marks are filtered, preventing them
from running.
Closes #1481 .
4 years ago
80e20304cb
Fix Linux build breakers.
4 years ago
5410395576
Replaced the ugly code in Exiv2::base64encode() and update the test suite.
4 years ago
0ad46453ed
With good fortune, bmffimage is ready for review.
4 years ago
ee4d14340a
Fix box.length == to use bigEndian decode! Fix toAscii() to emit on ascii 32-127 bytes.
4 years ago
df68648dc3
refactored setModeAndPrintStructure() to respect class Task.binary_ when printing ICC profiles.
4 years ago
b983a9db75
Re-awaken obsolete command-line argument --binary and store class Task.
4 years ago
71d29fe60b
Fix MSVC build breaker and modify test_pr_1475_HIF.py to run on Windows.
4 years ago
55d2201892
Changed CI build default -DEXIV2_ENABLE_BMFF=On. Fixed suite to run with/without bmff. -pS and -pR same for bmff.
4 years ago
c84274ec19
Cosmetic change to -pR/-pS output.
4 years ago
fd9cb67fb7
WIP: adding BmffImage::printStructure() and support for colr box.
4 years ago
2b38d221dc
Adding DNG 1.6 triple-illuminant calibration tags
4 years ago
4ca05ed34a
Fix .CR3 files to call parseXmp().
4 years ago
ea1c91874f
Added parseXmp() to parse Xmp metadata.
4 years ago
44d976c2a1
Remove bmffimage::printStructure() as discussed in review with @hassec. Corpse removal and cleanup in bmpfimage.hpp
4 years ago
dcfe538a09
Revert "Add artist tag"
...
This reverts commit c46e800c0a
4 years ago
c46e800c0a
Add artist tag
4 years ago
5c77888037
Revised following code review by @hassec. Thank You, Christoph.
4 years ago
4d3af08ad8
Add CR3 image dimensions
4 years ago
4ae0a1d2a3
Tidy up. Rename Tag::cr3_exif -> Tag:cmt2
4 years ago
9515e4658b
Cleanup. 1. Recursively process uuid/cano box. 2. Fix LGTM/CI sprintf grumbles. 3. Comment parseTiff() in bmffimage.hpp.
4 years ago
913ee33372
Parse Exif in .HEIC/.AVIF
4 years ago
108670b309
Corrected format string
4 years ago
28b41f59bd
run clang-format on new files
4 years ago
29f3d5cac9
introduce parseTiff method to parse exif
4 years ago
f190f496d1
Tidying up. 1. pixelHeight_. 2. refactored indenter() -> indent(). 3. EXIV2_DEBUG_MESSAGES outputs to std::cerr
4 years ago
4a96025294
Fixed recursion issue in the meta box.
4 years ago
bafea0f1b8
[WIP] Fixed Image Spatial Extents Property Handling
4 years ago
8d7133d7bc
WIP: Added class Iloc and related code.
4 years ago
8976a23f2d
More fixes for LGTM/CI warnings.
4 years ago
64866cc568
Fixing warnings from LGTM/CI.
4 years ago
0b4b7c695e
Fix msvc/CI build breakers.
4 years ago
630fb23046
Fixing a build breaker.
4 years ago
6d13e44e5a
WIP: Refactored readMetadata() into recursive boxHandler()
4 years ago
0360a7ded5
[WIP] Yet another type cast correction to make Travis CI happy
4 years ago
a75ac74417
[WIP] Correction to make Travis CI happy
4 years ago
04481dd753
[WIP] 64-bit length
4 years ago
d455f473e8
C++ simplification.
4 years ago
7beb4e3e0d
fix_1471_sony2010_0.27
4 years ago
4fa0a88097
[WIP] Correction
...
https://ci.appveyor.com/project/piponazo/exiv2-wutfp/builds/37795261/job/23l6a0u0wt6ax79l
4 years ago
81e0f99254
[WIP] Another try
4 years ago
7b5854e26e
[WIP] Redefine tags
4 years ago
f0a321dedb
[WIP] Base Media File Format
4 years ago
c40eccd062
fix_1464_sony2010e Fix c++ code
4 years ago
c608148820
[WIP] Added box types
4 years ago
a6a47346a8
Use a.rfind(b, 0) == 0 instead of a.find(b) == 0 to reduce processing time when checking that a starts wit b, #1459
4 years ago
e19fca6640
Small corrections
4 years ago
f5c6e7595f
Fix Linux build-breaker when ENABLE_ISOBMFF=False and EXIV2_TEAM_WARNINGS_AS_ERRORS=On
4 years ago
fa39234275
Fixing Linux build/test issues.
4 years ago
0844e1bbfb
Rename class ISOBMFF => class bmffImage to match other image handlers. Removed C++11 style code. Removed unused code.
4 years ago
460a802671
Fix image handler to give jp2image code higher priority than the next isobmff code.
4 years ago
92469f4c27
[WIP] Add ISO/IEC Base Media File Format
4 years ago
ddd326fc18
Update canonmn_int.cpp
...
Added Sigma 35mm/1.4 to lens id 368 and changed resolver to look at both focal length and aperture. Fixed canonEv so lenses with f/6.3 report as f/6.3 (they actually report f/6.2 to camera)
4 years ago
056359d89b
fix formatting
4 years ago
93869e1311
use EXV_PRINT_TAG macro instead of specific print function
4 years ago
51bd57e387
add shutter mode and mechanical shutter count to nikon makernote 3
4 years ago
cf9be2cc3b
fixing exceptions and reordering tags
4 years ago
ff2ffb1909
add_cr3_tags
4 years ago
19decc1193
Merge pull request #1436 from Exiv2/dng_1.6
...
Add DNG 1.6 support
5 years ago
4c2ac99673
try and fix ci-build 3/N
5 years ago
f740fcd823
try and fix ci-build 2/N
5 years ago
814357a6d1
try and fix ci-build
5 years ago
2909e9cacc
Implement handling of new Nikon LensData version 8.0 and 8.01
5 years ago
240179514c
Add DNG 1.6 support
5 years ago
9b5108583b
Revert "Revert "fix_1431_binary_comment.""
...
This reverts commit 2866415322
5 years ago
c6167258ce
Revert "Restored 0.27.2 "toString()" behaviour of Exifdatum.value().toString() for CommentValue."
...
This reverts commit ecae9dc6eb
5 years ago
2866415322
Revert "fix_1431_binary_comment."
...
This reverts commit b6bf20a897
5 years ago
af8699a8ac
Revert "Fixing test suite."
...
This reverts commit 23f39b60f7
5 years ago
23f39b60f7
Fixing test suite.
5 years ago
ecae9dc6eb
Restored 0.27.2 "toString()" behaviour of Exifdatum.value().toString() for CommentValue.
5 years ago
b6bf20a897
fix_1431_binary_comment.
5 years ago
01a146e014
Merge pull request #1427 from Exiv2/prettyprint_planarconfig
...
Pretty print PlanarConfig
5 years ago
5e7a563407
Pretty print PlanarConfig
5 years ago
85e3a31242
Promote remaining SHORT/LONG tags default type
5 years ago
866d213983
Merge pull request #1409 from Exiv2/fix_1402_rafimage_0.27
...
fix_1402_rafimage_0.27
5 years ago
2466c78fe6
Calming Test Suite concerning Continuous and CropMode confusion.
5 years ago
a71eb24956
Pointless change to trigger CI to build again.
5 years ago
e032586d74
Code/comment tidy.
5 years ago
9b877f8506
Success. It's working!
5 years ago
0b5ba68e54
Merge pull request #1412 from Exiv2/dng15_0.27
...
Add DNG 1.5 tags and values
5 years ago
c48189afa7
Add FujiIFD to TiffCreator::tiffGroupStruct_
5 years ago
a8b549f7df
Remove debugging code.
5 years ago
4ab2eb3ec6
Add DNG 1.5 tags and values
5 years ago
13032f44f1
Fix Pana tag typo and improve Fuji tag description
5 years ago
45119e3260
WIP: working to understand how to support tiffIfd in tiffvisitor_int.cpp
5 years ago
b410eb3550
Complete DNG 1.4 spec support
5 years ago
a2f4082beb
Revert exv commit and remove empty line.
5 years ago
abce0ac300
Fix typo and remove empty line.
5 years ago
01a449544c
Adding support for DefaultUserCrop and BaselineExposureOffset
...
Nothing special, copied from dng 1.5 reference.
5 years ago
76514a1654
WIP #1402 rafimage::printStructure() improved formatting.
5 years ago
Peter Kovář
Kevin Backhouse
Christoph Hasse
postscript-dev
postscript-dev
Andrea Giudiceandrea
norbertwg
Rosen Penev
mergify[bot]
Daniel Vogelbacher
andyrtr
Matthias Kuhn
nulllinie
Christoph Hasse
Alexander Steffen
Luis Díaz Más
Miloš Komarčević
tbeu
Robin Mills
Miloš Komarčević
Pydera
Ingo Weyrich
czgnp
Alex Esseling
hanno@schwalm-bremen.de