75f7285487
Remove translatable mark from RF lenses
3 years ago
ecfdaca525
Add more Canon RF lenses
3 years ago
1f5bc3b8a5
Avoid buffer reallocation ( #2392 )
3 years ago
fb6b769817
Merge pull request #2390 from kevinbackhouse/tiffvisitor-safe-add
...
Use Safe::add() in tiffvisitor_int.cpp
3 years ago
a58e52ed70
Use safe add to prevent overflow
...
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>
Use safe add to prevent overflow
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>
3 years ago
eada606992
Match Conan's cmake find module case for Brotli
3 years ago
9a6ee59421
Support brotli compressed boxes in JPEG XL
3 years ago
ee698689b4
Exif start can be at any byte in payload, not word aligned
3 years ago
62705a6615
Use Safe::add() in tiffvisitor_int.cpp
3 years ago
9767e375af
Update makernote model ID tags ( #2389 )
...
* Update `Exif.Sony(1|2).SonyModelID` values
* Update `Exif.Pentax.ModelID` values
* Update `Exif.Canon.ModelID` values
* Purge duplicates in `Exif.Canon.ModelID`
* Correct text in `Exif.Canon.ModelID`
3 years ago
3897f17b1e
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=52355
...
Avoid integer overflow when temp == INT_MIN.
3 years ago
03abb2c109
Merge pull request #2384 from kevinbackhouse/fix-issue-2383
...
Avoid null pointer deref
3 years ago
222c45c154
Merge pull request #2374 from norbertwg/update_easyAccessAPI
...
several keys added to easyaccess
3 years ago
6bb956ad80
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=52382
...
Avoid null pointer deref.
3 years ago
b90426dda9
Merge pull request #2378 from kevinbackhouse/fix-issue-2376-2377
...
Fix bugs in QuickTimeVideo::userDataDecoder
3 years ago
597e372b1c
clang-format
3 years ago
459910c36a
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=51751
...
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=52053
Avoid null pointer deref and heap buffer overflow.
3 years ago
fd7566fcd8
get rid of nested if conditions
...
Easier to read with lambdas.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
e38d3d9976
several keys added to easyaccess
...
sample easyaccess-test enhanced with additional optional arguments
"category" for easier definition of some tests
3 years ago
a2cb06a28e
Fix/add exceptions for BMFF based files ( #2364 )
...
* Fix BmffImage::writeMetadata() error id/message
* Add exceptions setting Exif/IPTC/XMP in BMFF
* Add missing header for new functions
3 years ago
a8a35345c8
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=51241
...
Fix bounds checking bug.
3 years ago
b3bd36c749
clang-format
3 years ago
0db460c9b0
nul-terminate string
3 years ago
a38e124076
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=51707
...
Resize buf to avoid buffer overflow.
3 years ago
d856ca7d82
cland-tidy: simplify booleans
...
Found with readability-simplify-boolean-expr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
9dc34ad39c
Update Sony(1|2) tags ( #2323 )
...
* Update Sony(1|2) group (minor Minolta changes)
Transcribe all tags (except for `LensID`) from main ExifTool Sony
group into Exiv2.
Changes include:
- Rename `ColorReproduction` -> `CreativeStyle` and
`LongExposureNoiseReduction` -> `FocusMode3` to reflect use.
- Rename `0x*` tagnames to equivalent ExifTool tags (e.g.,
`0x2006` -> `Sharpness`).
- Remove tag entries that are Groups (e.g., `ShotInfo`).
- Separate some common Sony/Minolta data as the camera types use
different values (e.g., `Quality`)
- Additional `exiv2-Sony*.exv` test files come from ExifTool Sony
samples (https://exiftool.org/Sony.tar.gz ).
ExifTool Sony tags sources:
https://www.exiftool.org/TagNames/Sony.html
1e17485cbb/lib/Image/ExifTool/Sony.pm
3 years ago
84f566b4b7
use reference to work around MSVC bug
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
640b0fbf5d
Merge pull request #2346 from kevinbackhouse/fix-issue-2345
...
Fix buffer overflow in QuickTimeVideo::tagDecoder
3 years ago
56249bb1a0
Use getULong to read unsigned numbers.
3 years ago
d2253c91f5
Merge pull request #2348 from kevinbackhouse/fix-issue-2270
...
Don't allow zero width/height in WebPImage::inject_VP8X
3 years ago
bf151a17a3
Don't allow zero width/height in WebPImage::inject_VP8X
3 years ago
344764a7de
Fix clang-format error.
3 years ago
bf4f28b727
Avoid potential integer overflow.
3 years ago
d3651fdbd3
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=50901
...
Resize buf to avoid buffer overflow.
3 years ago
337fe1854f
fix(quicktimevideo) avoid out of bounds read, closes #2340
3 years ago
7a92e1bd0f
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=50315
...
Don't allow INT_MIN (0x80000000) because it can cause a UBSAN failure in std::gcd().
3 years ago
ccebe7936e
Update Nikon flash tags ( #2274 )
3 years ago
e4adf388aa
fix(quicktimevideo) cleanup and hardening as suggested in review by @kevinbackhouse
3 years ago
0577057548
fix(quicktimevideo) silence windows warnings
3 years ago
ce4b9f0ff9
fix(video) dont throw in isQTimeType
3 years ago
3456f30988
fix(video) clang-format quicktimevideo
3 years ago
393815ffb0
fix(video) filetype detection: handle video via quicktimevideo.cpp and other ftyp files in bmffimage
3 years ago
0a948c6a7d
feat(video) revive quicktime.{h,cpp} and adapt to codebase changes.
3 years ago
30dbd13982
fix(video) bmffimage can not currently handle mp42 files so skip those
3 years ago
71dc04ebb1
misc sonarlint stuff
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
89d7798f1d
Add more MIME type mappings for TIFF-based raws
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
2fa84f4bab
remove using
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
235b1e0d19
move structured bindings up
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
88fcd234bb
remove pointless x_default variable
...
Just replace it with the string.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
b6c2062fae
std::to_string conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
10a62b2350
replace custom gcd function with std
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
3ac7608282
Merge pull request #2321 from kevinbackhouse/fix-issue-2320
...
Fix integer overflow in printDegrees
3 years ago
e151daa0fc
fix compilation without mmap and non win32
...
buf was refactored not to be a pointer.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
fe4f56d979
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=49894
...
Check that `60 * rem` won't overflow.
3 years ago
fc840405cc
revert std::function back to function pointers
...
The former has too much overhead. No point in it.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
9aaeb893ee
don't use w32 sockets for cygwin
...
Not needed.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
350541f22a
manual replacement of [0] with front()
...
Avoids implicit array decay.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
5c90684441
simplify some defines
...
As far as I can tell, _WIN32 is defined for true Windows platforms.
Cygwin is a POSIX platform.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
f3b572d211
fix iconv handling and windows
...
WIN32 as a define is wrong. _WIN32 is the correct one.
Which opens up the issue of the used functions and the wrong logic.
Changed the function logic to use if and elif, as done later in the
code.
Also changed all usages of WIN32 with _WIN32
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
e41dd1d227
remove pointless UNUSED statement
...
Does not compile as it is no longer present.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
2b8ca5a9d7
fix compilation with mingw iconv
...
The parameter there is const. Use the appropriate macro.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
7fa6d7378f
Add Nikon3.WhiteBalanceBias2
3 years ago
306424f589
remove c_str for fs stuff
...
fs::path is convertable to a string.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
b8855fb3b5
misc sonarlint cleanups
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
1602afef0a
const conversions
...
These were not const.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
5e20467e5c
default init static variable
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
d4f04296e4
remove explicit constructor
...
No need.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
c64ed25c13
remove unused using
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
7b9ba51c4e
enum class conversion
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
6e3db99755
simplify switch statement with returns
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
2e8ce712ec
Use emplace().
3 years ago
166b5b834d
Replace TiffTreeStruct with std::pair
3 years ago
3d38e11300
Remove unneeded constructor
3 years ago
67270c2b11
Use std::unordered_map for TiffTreeStruct lookup.
3 years ago
be1c00c916
Suggestions from @neheb and @piponazo
3 years ago
71dfff5a69
Use a switch
3 years ago
7ec15d247e
Use std::unordered_set for tiffImageTags
3 years ago
12b94bc420
get rid of extern const
...
Looks like some pre C++11 thing.
Also fix formatting of these by adding , at the end of the arrays.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
e831219d5c
Correct error from #2301
3 years ago
938964f4d0
remove GroupName struct
...
No point in this.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
cc604780be
Merge pull request #2283 from kevinbackhouse/printStructure-depth
...
Convert type of depth parameter to size_t
3 years ago
09f61bc3d1
Suggestions from @neheb and @piponazo.
3 years ago
1fccceeba1
Use std::map for faster lookup.
3 years ago
e74feff4d8
strcmp to == conversions
...
Does the same thing.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
d5e42da39e
replace structs with std::pair
...
Simpler.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
0256775408
Merge pull request #1949 from VJSchneid/main
...
add support for more fujifilm tags
3 years ago
ee5dae4ddd
Fix implicit cast warning.
3 years ago
4410f46214
Change the return type of the 2Data functions to size_t.
3 years ago
d62220a858
apply clang-format to src/fujimn_int.cpp
3 years ago
73a1a0ec21
Merge remote-tracking branch 'origin'
3 years ago
1d0530f04d
misc sonarlint changes
...
Mostly const changes.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
8ba9003f19
Fix clang-tidy warning about double move.
3 years ago
b0040e3bbe
Convert type of depth parameter to size_t.
3 years ago
0f1ea7571b
Refactor printTiffStructure depth increment
3 years ago
46f2ef8009
Refactor printIFDStructure depth increment
3 years ago
39239cef68
Merge pull request #2296 from kevinbackhouse/tiff-offset-size_t
...
Use size_t for the offset argument in TiffComponent
3 years ago
89040ad1de
Fix implicit type conversions.
3 years ago
d8bd05f4e8
Use size_t
3 years ago
beaee05062
Change type of sizeDataArea_
3 years ago
30debd2635
Use size_t for the offset.
3 years ago
e34395e095
replace shared_ptr with make_shared
...
The former creates a nullptr. The latter actually allocates.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
c03af98725
clang-tidy: use auto
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
5a08e33fd8
sonarlint: replace loop with find_if
...
Sonarlint complains about this loop for some reason. Convert to find_if
to fix.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
aae02babba
sonarlint: replace lock_guard with scoped_lock
...
C++17 allows scoped_lock, which sonarlint recommends.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
5d2d47032b
replace [0] with front() where applicable
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
1958e70a71
Use int32_t in TimeValue
3 years ago
3db7598e29
Don't use long in floatToRationalCast
3 years ago
49679640e8
make_unique conversions
...
Requires pointer hack for MSVC.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
3ae1d3b48e
return make_unique directly
...
Simpler
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
9ca7f861cf
remove string_view from headers
...
This should allow usage with C++11 projects. It's also wrong. The only
user of this assigns an std::string from a string_view, which is not
safe.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
5479792d50
remove pointless &*
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
f3b08d506e
const ref conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a6c30dd1dd
make upper the same as lower
...
Small cleanup
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
b8eaae649d
use some auto
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
b793409eb6
find_if and lambda conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
932d59a984
find_if conversion
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
9766c4532d
fix some gcc -Weffc++ warnings
...
Mostly deleted member functions
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
543c951bde
clang-tidy: use '' for find
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
4544fd826c
Add more Nikon Z lenses
3 years ago
ca5f88d519
Add Nikon LensData v0802
3 years ago
176210567f
remove friend operator
...
Seems to be unused. It's also inconsistent between various clang-format
versions.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
94f8889cd3
Update olympus tags ( #2246 ) ( #2249 )
...
Update translation output of `Exif.OlympusCs.ArtFilter`/`Exif.OlympusCs.MagicFilter`, `Exif.OlympusCs.ImageStabilization` and `Exif.OlympusCs.WhiteBalance` tags.
Fix `Exif.OlympusCs.ImageStabilization` type from `unsignedShort` to `unsignedLong`.
Closes #2246 .
Ref: Exiftool Olympus tags and Olympus E-M10 Mark II instuction manual.
3 years ago
dc4ae73013
Add tag description option to exiv2 app ( #2279 )
...
* Add `tagDesc()` to (Exif|Xmp|Iptc) Datums and Keys
* Add `--Print d` option to exiv2 app
* Add testing for all exiv2 application `--Print` options
* Update manpage
3 years ago
05586628b2
Merge pull request #2276 from kevinbackhouse/TagInfo-enums
...
Move enums from tags_int.hpp to tags.hpp
3 years ago
3ef783e02a
Convert IfdId and SectionId to enum classes.
3 years ago
90f794f13e
Merge pull request #2277 from kevinbackhouse/iptcDataSegs
...
Simplify the iptcDataSegs logic in jpgimage.cpp
3 years ago
97e58a4573
Merge pull request #2267 from neheb/clang
...
mostly clang-tidy fixes
3 years ago
8e5b8113e7
Use emplace_back
3 years ago
2c31430ecd
Merge pull request #2275 from kevinbackhouse/vector-access
...
Fix some "unsafe vector access" warnings
3 years ago
a608138f5f
Simplify the iptcDataSegs logic
3 years ago
62043c18ab
clang-format
3 years ago
b9b2d7741b
Fix some "unsafe vector access" warnings.
3 years ago
3f7cb78a3b
Move enums from tags_int.hpp to tags.hpp
3 years ago
0c3da129f2
Replace assert with enforce. (Fix for https://github.com/Exiv2/exiv2/issues/2268 )
3 years ago
7f673c766d
Fix some "signed shift" warnings
3 years ago
5be42f132c
try to fix some fanalyzer warnings
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
c0083d6788
clang-tidy: fix mismatching declaration variable
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
7f9242afc6
clang-tidy: replace + with append()
...
Silences clang-tidy performance warning
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
fc1a398488
clang-tidy: remove const
...
It doesn't do what it's supposed to here.
Found with misc-misplaced-const
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
84555f1ad5
clang-tidy: no else after return
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a5c521ea57
Merge pull request #2252 from neheb/2
...
clang-tidy: use default member init
3 years ago
60b3e28e0b
Merge pull request #2266 from kevinbackhouse/signed-shift
...
Fix some "signed shift" warnings
3 years ago
1ada360774
Fix some incorrect format specifiers.
3 years ago
b3f2ab5988
Fix some "signed shift" warnings.
3 years ago
08a68c3606
Merge pull request #2251 from kevinbackhouse/basicio-ftell
...
Change return type of BasicIo::tell() to size_t
3 years ago
5e4eab0012
Merge pull request #2248 from Exiv2/hassec_fix_2247
...
fix naming of canon EF 35-80mm. closes #2247
3 years ago
bae7da19ca
clang-tidy: use default member init
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
c2fbff291e
PNG: always strip the existing iCCP chunk
3 years ago
ad4e13b827
Change return type of BasicIo::tell() to size_t.
3 years ago
16d72c9945
fix naming of canon EF 35-80mm.closes #2247
3 years ago
cf963e9e4d
clang-tidy: C casts to C++
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a98954a98e
clang-tidy: add missing special member functions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
b4c90b5e16
clang-tidy: replace pointer magic with data()
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
93dc63b389
Merge pull request #2215 from Exiv2/add_f_lenses
...
Add some F mount lenses
3 years ago
e00422ae52
Account for header bytes for Exif and XMP boxes
3 years ago
e185c5843f
use correct type for element counter in printFujiFaceElementTypes
3 years ago
6bbaa31409
apply clang-format rules to fujimn_int.cpp
3 years ago
f3258027f4
fix some rebase issues
3 years ago
88bc575b7b
add comment that fujiColor value 512 differs from exiftool
3 years ago
b8e378b85e
fix typo in fujiSharpness and prevent undefined behaviour when shifting signed values
3 years ago
040b106b0a
remove TODO entries
3 years ago
f9cbf2438a
add some fujifilm tags from exiftool and extend TagDetails
3 years ago
967f6a6265
remove redundant TagDetails and fix formatting
...
Co-authored-by: Miloš Komarčević <4973094+kmilos@users.noreply.github.com>
3 years ago
21d07634ae
print newer labels first when interpreting Fujifilm tags
3 years ago
c4ba70caeb
remove auto range for DynamicRangeAuto setting
3 years ago
4a3cf6b3de
add support for more fujifilm tags
3 years ago
0dcd8605c9
fix mmap compilation
...
CI doesn't catch all cases failing.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
c9bdd6ed94
Merge pull request #2209 from Exiv2/mainTODOs
...
Improvements around TODO comments
3 years ago
d59e1433c0
replace readlink with std::filesystem
...
Simpler.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
707e22c577
Add some F mount lenses
3 years ago
bd1758c3c5
remove some double pointer stuff
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
65c5b772c9
fix misplaced const
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
c9c2a1847b
remove const std::function
...
std::move is used.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a86bc386da
reference conversions
...
There's no nullptr here.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
48f848f5bb
clang-tidy: remove const params in decls
...
Found with readability-avoid-const-params-in-decls
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
2e721a716e
std::function conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a8061e7ee9
clang-tidy: default member init
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
151b54ab3e
remove default constructor
...
This is rule of zero.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
2b74cc885d
Revert some boilerplate which is not needed
3 years ago
d4ffcb9497
utils are in Internal namespace
3 years ago
cc79051b79
Move 1-liner to header file
3 years ago
ee855c0e71
Reduce amount of string transformations
3 years ago
d5742f449b
Move string helpers to utils
3 years ago
1a3e93856b
More tests for rational convertions
3 years ago
8da71e7133
Test parseUint32 and fix it when number is out of limits
3 years ago
331924612e
Remove duplication by using templates
3 years ago
2b91b5daf9
More tests for DataBuf read/write functions
3 years ago
6964f5f9f2
DataBuf::c_data() returns nullptr when empty + avoid duplication
...
After the previous commit, I realized that std::vector::data() also
returns nullptr when the vector is empty. So I decided to emulate this
behavior in DataBuf::c_data().
Anyways, the changes done in the previous commit are valid and allow us
to avoid some processing when the DataBuf is empty.
3 years ago
c3d0100d48
Fixing bad usages of DataBuf (when it is empty)
3 years ago
4a4a8c544c
Throwing when trying to access TooFar elements in DataBuf
3 years ago
941017d281
Fix issues on ARM builds ( #2205 )
...
* Specify base class initialization in Copy Constructor
* Fix printing of uint64_t variable in ARM 32bits
Use cinttypes
* Fix alignment issues on ARM 32 bits
* tests: add assertion with custom message
3 years ago
6203ded16f
add constexpr constructor
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
8d2e1926ca
remove unused class declarations
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
25c47cd1cf
Merge pull request #2197 from Exiv2/mainRefactoringFormats
...
Refactoring in JpegImage and Photoshop classes
3 years ago
f07c88de5d
Use .front() to avoid warning from static analysis
3 years ago
4d99c2aca1
Use std::pair to return multiple values
3 years ago
4ee9c35799
Include missing iostream header in photoshop.cpp
3 years ago
f942ba89bd
Move Photoshopb class to internal namespace
3 years ago
047f6b733e
Change logic to determine if segment has size
...
Note that the failing tests that had to be adapted were bad formed files
from FUZZERs. We should not consider invalid markers like 0x00 or 0x52
but only undefined APPn markers.
3 years ago
400632f27b
Factor out function readSegmentSize()
3 years ago
24d2a7b8f0
JpegBase::markerHasLength moved to implementation details
3 years ago
23fe743d4d
Move private constants to .cpp
3 years ago
b00e460d76
Move static functions to anonymous namespace
3 years ago
c997b09a81
algorithm conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
d789968e90
replace malloc/free with new/delete
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a20ace20fc
clang-tidy: manual clang-tidy fixes
...
clang-tidy has issues applying these.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
ae66ecec0d
clang-tidy: use nullptr
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
49bf7e1387
clang-tidy: use delete
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
e654b2931c
clang-tidy: replace throw() with noexcept
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
1f05448d0e
clang-tidy: default member init
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
0d971e98e4
remove some unique_ptrs
...
They're not really used as pointers.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
89b8d4ea4e
try to actually fix null pointer deref
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
25ef5d7e77
replace ret variable with return statement
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
7bc9861301
clang-tidy: use strcmmp properly
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
7a826ac529
clang-tidy: add parentheses to macros
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
cacb54eaba
use auto
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
fdfcde5e4b
structured binding conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a505d6f06c
More unit tests for Photoshop methods
3 years ago
8ab7800477
Remove 2nd param from Photoshop::isIrb() since it is always hardcoded
3 years ago
e715243aa5
Fix integer overflow #2179
3 years ago
6e9eca445a
Merge pull request #2177 from neheb/1
...
clang-tidy and manual stuff
3 years ago
bd68c14de5
Detect integer-overflow and throw in that case
3 years ago
262d0ee4b3
struct to std::pair conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
e82be13b73
C to std::function
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
e9896d1f99
clang-tidy: fix inconsistent decleration
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
d190baac6c
clang-tidy: do not use using namespace
...
Found with google-build-using-namespace
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
c35fb7104b
clang-tidy: use any_of
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
3298fcf656
some chrono
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
b25e75dd7b
replace Sleep with sleep_for
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
dfb93dd8cd
clang-tidy: use C++ headers
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
aa41d557b2
function move
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
06d977d7bc
clang-tidy: use default
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
9f67620503
clang-tidy: add more nodiscard
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
b72e4b0e44
clang-tidy: use auto
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
d16ca65b01
Fix out of bounds read in isValidBoxFileType()
3 years ago
3b9fcb4b3d
Update .clang-format to align pointers to the types
3 years ago
790fc465f4
Merge pull request #2172 from Exiv2/mergify/bp/main/pr-2167
...
Initial support for OM System MakerNote (backport #2167 )
3 years ago
fafe999c6e
remove unused var from deleted stuff
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
8fa30d66b4
Initial support for OM System MakerNote
...
(manually adapted from 916436903d34b88ea0d49c5084c51e02cfae9bfb)
3 years ago
c0868aff31
std::function
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
389501462a
delete
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
043547cbd0
remove various usages of memset
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
bad4712df8
static constexpr conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
9dc35e7380
find to std::find
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
9cb1fcef5c
std::array conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
d7f35e33f0
Remove useless static_casts
3 years ago
ae4df71233
Remove DataBuf::copyBytes and use std::copy instead
3 years ago
5b0418d136
Improve compare function: no need to count chars
3 years ago
b05573fadc
Remove most of the asserts from codebase
3 years ago
1ad9e52f3c
Fix windows build
3 years ago
1545a1bc4a
JP2 - stronger checks on Signatuer and FileType boxes
3 years ago
e7478f744d
Jp2Image: Implement more checks from JP2 standard + fix bug
...
- add debug info when parsing Signature box
- Move definitions & static stuff to anonymous namespace
- cleanup while studying code
- Make exceptions more similar to other formats
3 years ago
b48e8e9379
Add unit tests for Jp2Image revealing bugs (see #2147 )
3 years ago
5d5354edee
clang-tidy: C array to std::array conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
30bf563f4d
Update .clang-format file & apply clang-format to whole project
3 years ago
b2b6d834ba
some std::array conversions ( #2148 )
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
573c3c79fc
Merge pull request #2145 from Exiv2/mainSizeT_n
...
More migration to size_t
3 years ago
04ae6c2c4c
Add key name to "Value not set" error message ( #2149 )
...
The error typically occurs when writeMetadata() is called. It's easier
to find the problem if you know which datum hasn't had a value set.
3 years ago
4355d635d4
More conversions to size_t while removing static_casts
3 years ago
7576a2757b
More size_t for sizes
3 years ago
137ea080b5
Change Metadatum::size() return value from long to size_t
3 years ago
62aad98d0b
Change Metadatum::copy return value from long to size_t
3 years ago
fa24fb22ca
Use compiler deduction guides for error list
3 years ago
7119b7676f
remove templating & simplify error message
...
+ clang-format in Error files
+ Remove AnyError
3 years ago
96f7f2e4c5
Convert Exiv2::ErrorCode into an enum class
3 years ago
5d08bb9bec
Merge pull request #2146 from Exiv2/mainDatesWithZeros
...
DateValue is now a bit more permissive with malformed dates
3 years ago
c115d4daf7
Merge pull request #2131 from Exiv2/mainCleanups
...
Include what you use + more SPDX identifiers + few other cleanups
3 years ago
56c52be8b5
DateValue is now a bit more permissive with malformed dates
3 years ago
5c36c690f9
Merge pull request #2137 from Exiv2/mainRecoverRecordId
...
Recover IptDataSets::recordId in the API
3 years ago
a009ac1f61
Merge pull request #2135 from neheb/1
...
manual nullptr removals
3 years ago
c1ae1bcb03
Recover IptDataSets::recordId in the API
3 years ago
8dadcdf72a
manual nullptr removals
...
unique_ptr has a bool overload. It's also easier to reason about.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
784cbe2965
manual move conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
eb49d66caf
Strip XMP raw packet before decoding
3 years ago
b8304fffa4
clang-tidy: don't use C casts
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
89e66ffd37
Merge pull request #2132 from neheb/2
...
misc cleanups
3 years ago
f894ee0568
Fix debug builds
3 years ago
c0a3242e73
C++-style headers
3 years ago
c2bcd4b08e
replace EXV_COUNTOF with std::size
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
61a5d8594c
remove some new
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
17a13072e6
manual unimplemented operator = delete
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
b3823f4c8d
conversions to make_unique
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
b6bdbf5574
clang-tidy: don't use else after return/throw
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
9f949195e4
clang-tidy: add ending namespace comment
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
09ca3ca1f2
manual namespace concatenations
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
c146ae5215
Fix mac build
3 years ago
bbc99ae581
Use auto for unique pointers
3 years ago
f156af46f3
Fix build on Windows
3 years ago
b3a216310a
Removing unused headers thanks to IWYU
3 years ago
22064c957d
Add missing header to the CMake configuration
3 years ago
2834fa5f05
Use [[maybe_unused]]
3 years ago
5508e6f466
hexdump to size_t
3 years ago
8b1fe379a1
Removing unused headers thanks to IWYU
3 years ago
3f3b651c04
Remove unused stuff
3 years ago
15697fcd1e
Remove unused file
3 years ago
23da0c3955
Do not define not needed stuff
3 years ago
7ed43037e3
Guard against parsing "inf" into an int64 in the EasyAccess/ISO API.
...
(Diff authored by clanmills)
3 years ago
f0d23eca9b
clang-tidy: add some missing operators
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
daf7c890e2
misc stuff
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
95355fe214
clang-tidy: remove C casts
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
8cda090e58
clang-tidy: get rid of compare() usage
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
63e41c3aeb
clang-tidy: simplify bool
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
133849c394
clang-tidy: remove pointless get()
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
6d1fa2ecea
clang-tidy: use empty() instead of size()
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
5833101b9b
manual nullptr conversions
...
Mostly not caught because I'm not running clang-tidy on Windows.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
e6d3315160
clang-tidy: use emplace_back
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
77e79b32f5
manual braced init conversion
...
clang-tidy's not converting these for some reason.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a25bbe133f
constexpr string conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
887b08b0b7
clang-tidy: range loop conversion
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
04bacdedd6
clang-tidy: use auto
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
962e3b7369
clang-tidy: use default
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a5c094b85f
clang-tidy: use concat namespaces
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
118aa78aa0
clang-tidy: use braced init list
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
f65848a590
simplify ReplaceStringInPlace slightly
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
5d60a91ebc
move initializations to class
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a67e0d525f
move namespace fs below includes
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
ae3e28c62a
make array constexpr
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
b17828b454
Use SPDX for licenses ( #2122 )
...
* Use SPDX identifier in header files
* Use SPDX identifier in rest of source files
* Fix usage of SPDX for files with 2 licenses
* Add global license file
* Fix compilation
3 years ago
5ca423d292
Merge pull request #2118 from Exiv2/main_NewDelete
...
Refactoring & Cleanup (Moving to size_t usage & less naked new/deletes)
3 years ago
a5b6db171c
Merge pull request #1919 from dimin/viqi
...
fix for reading jpeg-xr images
3 years ago
ac9b9e2c95
Merge pull request #2071 from Sturmflut/nikon-improve-lens-docs
...
[nikon] Add instructions for adding new Nikon F mount lenses
3 years ago
208ec70df8
Fix windows builds
3 years ago
e07c3771da
Fix more issues found by fuzzer
3 years ago
12738214f2
Fix warnings and place return statements separated from if
3 years ago
f6b17d2a4d
Fix issues found by fuzzer
3 years ago
b9f9d041ea
Several transformations on DataBuf + migration to size_t
...
- Provide begin/end iterators to DataBuf and simplify code
- Adapt test output after last changes
- Replacing long by size_t in value.hpp
- Use size_t in some Photoshop functions
- Remove some static_casts
3 years ago
7dea0050b1
Factor out duplicated piece of code
3 years ago
5d627433fc
Remove useless DataBuf::clear()
3 years ago
3a749e6861
No need to define copy & move ctors
3 years ago
2bacff0f5c
Simplify DataBuf
3 years ago
615ccff5ab
Fix another case revealed by tests
3 years ago
6e50714726
Replace c style arrays by std::array
3 years ago
f1e04ee866
Replace DataBuf internal buffer with std::vector
3 years ago
aec36f86d7
Replace naked new operators
3 years ago
9bf4967e5c
Merge pull request #2110 from mallman/nikon_ContrastDetectAFInFocus
...
Make Nikon ContrastDetectAFInFocus tags Bytes that print as "Yes" or "No"
3 years ago
5ff7d89a4c
Document origin of data size specifications for Nikon maker note tag 0xb7
3 years ago
54eab964a6
When selecting which version of nikonAf2 metadata to parse, include the
...
size of the data declared in the tag header as part of the lookup
3 years ago
c5a9dfd9af
Merge pull request #2109 from Exiv2/main_StringView
...
Refactoring & cleanup
3 years ago
a3e2410b88
Print value of ContrastDetectAFInFocus as Yes/No. Change internal
...
selection logic for NikonAf2* from tag data length to group version
3 years ago
5d86044c71
Merge pull request #2107 from kevinbackhouse/MetadataToLong
...
Replace Metadatum::toLong() with Metadatum::toInt64().
3 years ago
21eb0cec4f
Fix build when EXIV2_BUILD_MESSAGES is ON
3 years ago
8b3da36f42
Improvements from code review
3 years ago
a7ce4ee846
Move Metadatum::toUint32() implementation out of header file.
3 years ago
9541a89b13
Make Exif.NikonAf2.ContrastDetectAFInFocus and
...
Exif.NikonAf22.ContrastDetectAFInFocus byte types
3 years ago
5db9a25b19
Fix compiler warnings.
3 years ago
90aa007188
Convert type of pixelHeight/pixelWidth to platform-independent uint32_t.
3 years ago
f774a3b25e
Fix build on linux
3 years ago
9fb43f28e0
Use standard [[maybe_unused]]
3 years ago
76f01fd4d3
Clean more header inclusions
3 years ago
7e5ba7cb23
Remove many redundant or not needed header inclusions
3 years ago
b543f3e973
Use filesystem in getExiv2ConfigPath
...
It seems to have an important impact in performance. The execution of
ctest on Windows passed from 48.5 secs to 43.8. Check if this is the
same on Linux
3 years ago
476a5e23f9
Replace raw loop for any_of
3 years ago
59f4d0de27
cppcheck: reduce scope of variables
3 years ago
d11479e53c
Replace dynamic C array by std::vector
3 years ago
ea201ce613
Remove dead code
3 years ago
1d243ed40e
Remove dead code: copyXattrFrom
3 years ago
c0b663b7ea
Remove dead code (LSTAT)
3 years ago
798cf9baeb
Remove dead code (winNumberOfLinks)
3 years ago
a6185d29c6
Image::setComment now takes string_view
3 years ago
56b5ab9a29
Use remove from filesystem
3 years ago
9b3a643d33
Use rename from filesystem
3 years ago
8b2d17312e
ReplaceStringInPlace does it in-place now
3 years ago
45300ad667
BasicIo::path() returns const ref
3 years ago
0726104b1a
Hide pathOfFileUrl in the only place where it is used
3 years ago
6f762b4e66
Use std::filesystem for fileExist
3 years ago
f1ff3aaa4c
Make urldecode in-place
3 years ago
3d370cc2ae
Improvements in urlencode
3 years ago
8e0e00c459
make startsWith constexpr and use string_view
3 years ago
f5c89a4e62
Fix build on Windows
3 years ago
405f4b5f1b
Remove Util::dirname and finally the util files
3 years ago
1b912fa887
get rid of suffix
3 years ago
dad3e7f5c4
Replace suffix implementation with std::filesystem
3 years ago
2c51208622
Replace basename implementation with std::filesystem
3 years ago
d64c2aad67
Replace dirname implementation with std::filesystem
3 years ago
f1c8d5bbb4
Remove unused headers
3 years ago
7c6a7aefc2
Utils::strtol only used in the app
3 years ago
8c6e22e6aa
replace is only used in actions.cpp
3 years ago
49fbfb44a3
Remove startsWith from utils
3 years ago
d1524e3d96
simpler implementation of startsWith
3 years ago
a725d22ea5
add characterisation tests for utils
3 years ago
a8bb38ab6f
Move exiv2 app into its own folder
3 years ago
256365830a
Replace Metadatum::toLong() with Metadatum::toInt64().
3 years ago
15c91b4cc9
Merge pull request #2101 from Exiv2/main_LinuxDistrosOnPRs
...
Linux distros jobs on PRs + Fix linking issues on some platforms
3 years ago
38254be55e
Install new image_types.h header
3 years ago
b7d5c7e22a
Link against stdc++fs on Linux when it is needed
3 years ago
287744fa12
Merge pull request #2087 from Exiv2/update_canon_tags_2
...
Update canon tags 2
3 years ago
408d80bce8
Change order of ImageType values
3 years ago
f10283f118
bug: Fix crash when calling ImageFactory::create(none)
3 years ago
5a9799ffb2
Replace ImageType namespace by a enum class
3 years ago
0aa34c3098
fix(canon): cleanup canonAf2 and canonAf3 related code
3 years ago
800ed8959f
Rewire Canon MakerNote 0x0026 (AFInfo) to allow TiffDecoder::decodeCanonAFInfo to handle this tag.
...
Minor changes to test script.
Cosmetic code changes.
3 years ago
d19e2d42df
Use AutoRotate
3 years ago
e625f331f9
Include CanonFlashInfo (somehow missing after cherry-picking)
3 years ago
de036b2b2a
Fix remaining wrong brackets
3 years ago
4977b7d5c3
controlmode added
3 years ago
f247014ee6
AEB Bracket Value added
3 years ago
5800942a9b
OpticalZoomCode added
3 years ago
d72ca6806c
ExposureCompensation added
3 years ago
50390717f7
fix wrong brackets
3 years ago
c6b8be5498
wrong brackets fixed
3 years ago
Miloš Komarčević
Miloš Komarčević
Kevin Backhouse
Peter
Rosen Penev
norbertwg
Christoph Hasse
Luis Díaz Más
Viktor Schneider
Jim Easterbrook
Michael Allman
Robin Mills
Alex Esseling