1d64f482ff
fix: use vector::at() rather than operator[] (backport #1735 ) ( #1741 )
...
* fix: use vector::at() rather than operator[] (#1735 )
* Regression test for https://github.com/Exiv2/exiv2/issues/1706
* Use vector::at() rather than operator[].
* Print to stderr when exception is caught and EXIV2_DEBUG_MESSAGES is enabled.
* Check that it prints "Bad value" for the date.
(cherry picked from commit f4d3adbf91e6dc4e34aee5bac7b7fd9e127a5c00)
# Conflicts:
# src/value.cpp
* fix merge conflicts from mergify backport
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>
Co-authored-by: Christoph Hasse <hassec@users.noreply.github.com>
4 years ago
2b84f4bd64
fix: zero initialize local variables. ( #1743 )
...
* Zero initialize local variables.
* Initialize xmpID_
4 years ago
3e099da7b7
Remove obsolete snprintf macros.
4 years ago
2c57f214c5
clang-tidy: use nullptr
...
Found with modernize-use-nullptr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
ff39473c18
clang-tidy: convert to static
...
Found with readability-convert-member-functions-to-static
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
b8712188bb
clang-tidy: use auto
...
Found with modernize-use-auto
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
20dfab8036
manual for range loop conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
c73dfa0106
clang-tidy: use uppercase numeric literals
...
Found with readability-uppercase-literal-suffix
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
2e73aa9dc0
default con/destructors in headers
...
Helps to optimize trivially destructable stuff.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
8337462032
clang-tidy: use empty() instead of comparing size
...
Found with readability-container-size-empty
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
8128716287
clang-tidy: use = default
...
Found with modernize-use-equals-default
Ran through git clang-format
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
e93ad82734
clang-tidy: use braced init list
...
Found with modernize-return-braced-init-list
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
01a3bc716d
Fix warnings in VS
4 years ago
de4d43d4d1
Fix warnings EXIV2_TEAM_EXTRA_WARNINGS
...
Most of the warnings fixed were:
- Hiding of local variables
- Hiding of globals
- Useless casts
- Conversions between float/double
4 years ago
83dda6ccd7
Fix warnings related to -Wdeprecated-copy
4 years ago
0bbaa6eff3
cpp: Replace auto_ptr by unique_ptr
4 years ago
d632988bbd
Massive code prolog cleanup.
4 years ago
717fc098be
fix_1486_effort2 https://github.com/Exiv2/exiv2/pull/1486#discussion_r593161473
4 years ago
ba6a577ab9
https://github.com/Exiv2/exiv2/pull/1486#issuecomment-796843835
4 years ago
fa41e52c8a
Add comment and test case
4 years ago
26ba26e241
Terminate empty ASCII strings as well
4 years ago
5f563b5255
Fix spelling mistakes in LangAltValue::read()
...
Removed unneeded comments and empty space.
4 years ago
282d1d6995
Add static to LangAltValue::read() const values
4 years ago
6cd9263fa7
Fix langAltValue::read() parsing
...
+ Fix segmentation faults in langAlt parse
+ Fix mismatched quotation marks and incorrect values
+ Add Python testing
+ Some tests commented out as quotation marks are filtered, preventing them
from running.
Closes #1481 .
4 years ago
9b5108583b
Revert "Revert "fix_1431_binary_comment.""
...
This reverts commit 2866415322
5 years ago
c6167258ce
Revert "Restored 0.27.2 "toString()" behaviour of Exifdatum.value().toString() for CommentValue."
...
This reverts commit ecae9dc6eb
5 years ago
2866415322
Revert "fix_1431_binary_comment."
...
This reverts commit b6bf20a897
5 years ago
ecae9dc6eb
Restored 0.27.2 "toString()" behaviour of Exifdatum.value().toString() for CommentValue.
5 years ago
b6bf20a897
fix_1431_binary_comment.
5 years ago
963c91fe8a
fix_1266_GPSProcessingMethod
5 years ago
ec979d522a
Changes following review.
5 years ago
9df691c0c5
Report Comments as charset=encoding data (not charset="encoding" data)
5 years ago
cca0245d87
Fix compiler warning.
5 years ago
43b06b6814
Don't allow binary into the output stream!
5 years ago
aae84e4643
Add missing inclusions of cstdio and cstdarg
7 years ago
603692a1d8
Copyright to Exiv2 authors
7 years ago
da24df0ba0
snprintf versions for VS versions previous to 2015
7 years ago
41499b8ecd
Use snprintf instead of sprintf in TimeValue::copy
...
- Replaced assert by enforce
7 years ago
335607054c
Use enforce instead of std::assert to fix warning about unused variable in realease mode
7 years ago
bd40c18f1c
Use variable in TimeValue::copy to remove -Wunused-variable warning
7 years ago
a246c73d6f
Use unused variable instead of hard-coded values in DateValue::copy
7 years ago
efe2ccdcb6
Replaced all hardcoded error codes with ker... constants
7 years ago
5b5987a596
Remove obsolete EXIV2_RCSID
8 years ago
5df8b01b77
Remove obsolete svn revision
8 years ago
6d5c2c3256
Getting ready to release v0.26
8 years ago
fd80993ab0
Updated copyright notice.
10 years ago
ce1d4cfc75
#1058 . Calming the test suite. LangAltValue comparator causes harmless changes in order of lang reporting.
10 years ago
f2986148b5
CID: 982053/4. Restore os format
11 years ago
f09fceda6b
Updated copyright year in a few files, version in runner.txt.
12 years ago
8e325e1c32
#876 : Reverted changes made with r2966, r2976 and r2973 and added a fix to only output characters up to the first \0 in ASCII values.
12 years ago
mergify[bot]
Kevin Backhouse
Rosen Penev
Luis Díaz Más
Robin Mills
Miloš Komarčević
postscript-dev
Dan Čermák
tbeu
Andreas Huggel