1b9b77c51f
clang-tidy: add ending namespace comments
...
Found with google-readability-namespace-comments
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
091fd77885
clang-tidy: remove redundant member init
...
Found with readability-redundant-member-init
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
2e73aa9dc0
default con/destructors in headers
...
Helps to optimize trivially destructable stuff.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
9642e3cceb
clang-tidy: remove pointless string init
...
Found with readability-redundant-string-init
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
1dc1186760
clang-tidy: simplify boolean expressions
...
Found with readability-simplify-boolean-expr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
8128716287
clang-tidy: use = default
...
Found with modernize-use-equals-default
Ran through git clang-format
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
8314030604
Revert "Remove deprecated EPS format"
...
This reverts commit 537cdad99e
4 years ago
de4d43d4d1
Fix warnings EXIV2_TEAM_EXTRA_WARNINGS
...
Most of the warnings fixed were:
- Hiding of local variables
- Hiding of globals
- Useless casts
- Conversions between float/double
4 years ago
b5d3a1fd70
auto_ptr -> unique_ptr for code with WIN_UNICODE enabled
4 years ago
3eb1eee7fe
Remove deprecated RiffVideo support
4 years ago
061ec1a75d
Remove deprecated QuickTime support
4 years ago
8dcc07887a
Remove deprecated Matroska support
4 years ago
94b87a8dec
Remove deprecated SSH support
4 years ago
0bbaa6eff3
cpp: Replace auto_ptr by unique_ptr
4 years ago
537cdad99e
Remove deprecated EPS format
4 years ago
d632988bbd
Massive code prolog cleanup.
4 years ago
0da1a50afe
Revert style changes
4 years ago
e09d093ccf
Minor whitespace formatting
4 years ago
f0a321dedb
[WIP] Base Media File Format
4 years ago
0844e1bbfb
Rename class ISOBMFF => class bmffImage to match other image handlers. Removed C++11 style code. Removed unused code.
4 years ago
460a802671
Fix image handler to give jp2image code higher priority than the next isobmff code.
4 years ago
92469f4c27
[WIP] Add ISO/IEC Base Media File Format
4 years ago
48afa7548d
fix_1329_remove_bigtiff_0.27
5 years ago
f61fa2ed9d
Fix write ability flags of PSD files ( #1260 )
5 years ago
d07a1f94f8
fix_547_0.27
5 years ago
cc1a6033db
fix_1045_0.27
5 years ago
18ed65a25f
fix_Sony2010e_0.27 Thanks to @sridharb1
5 years ago
43683f1eff
Fix #531
7 years ago
ae49250942
Check in Image::printIFDStructure if seek and reads are OK
7 years ago
962962a8e9
Port Iptc::printStructure & getUshort to slices API
...
This fixes #211 , #210 , #209
7 years ago
fec6535ae8
[binaryToString] Reimplement using Slices
...
- reimplement binaryToString:
- it now accepts a Slice and nothing else
- it does not return a std::string but instead a proxy object that implements
operator<< (this should be more efficient, as we do not need to touch the
heap in most cases)
- addapt unit tests
- replace all occurences with the new API
7 years ago
7a7ae7a1df
[image_int] Move internal functions into separate translation unit
7 years ago
54ad1bc91a
Fix cppcheck issues: duplicateBreak
7 years ago
603692a1d8
Copyright to Exiv2 authors
7 years ago
7d9ed33bde
Initialize DataBuf with 0s => fix valgrind error
7 years ago
607b19111c
[DataBuf] Replace wrong usage of release() with free()
7 years ago
efe2ccdcb6
Replaced all hardcoded error codes with ker... constants
7 years ago
5b5987a596
Remove obsolete EXIV2_RCSID
8 years ago
5df8b01b77
Remove obsolete svn revision
8 years ago
87a83c89d5
Merge branch 'master' into stringFormat_update
8 years ago
36df4bc997
Fixed potential out of bounds file access
...
This commit adds a out-of-bounds protection in the case that the
extracted values for offset & count are summed up larger than the size
of the file. Also this function checks for overflows before performing
the addition.
This fixes #159
8 years ago
cfa5073a2c
Added short explanation to internal function stringFormat
8 years ago
06cafadf4f
Added assertion that call to vsnprintf succeeds
8 years ago
c0ea5f4fba
Rewrite the reallocation the C++ way
...
* Fix handling of the return value of vsnprintf
* In C++11 we could use buffer.data instead of &buffer[0]
8 years ago
7e90668011
Adding comment for issue #56
8 years ago
2f0104879a
Merge pull request #81 from piponazo/robinChanges
...
Robin changes
8 years ago
8ad49f6d73
Robin changes in sync with master changes
8 years ago
74cb5bab13
Fixed wrong brackets: size*count + pad can overflow before the cast
...
=> Should fix #76 (most of the work has been done by Robin Mills in
6e3855aed7#76 is the contents of the 26th IFD, with the
following contents:
tag: 0x8649
type: 0x1
count: 0xffff ffff
offset: 0x4974
The issue is the size of count (uint32_t), as adding anything to it
causes an overflow. Especially the expression:
(size*count + pad+20)
results in an overflow and gives 20 as a result instead of
0x100000014, thus the condition in the if in the next line is false
and the program continues to run (until it crashes at io.read).
To properly account for the overflow, the brackets have to be removed,
as then the result is saved in the correctly sized type and not cast
after being calculated in the smaller type.
The brackets have also been removed from bigtiffimage.cpp, where the
same issue is present.
8 years ago
d8ae4484ae
msvc support for bigtiffimage.cpp
8 years ago
6e3855aed7
Fix https://github.com/Exiv2/exiv2/issues/55
8 years ago
Rosen Penev
Luis Díaz Más
Robin Mills
Miloš Komarčević
Peter Kovář
tbeu
Dan Čermák
tbeu
Michał Walenciak