Dan Čermák
23e29e9527
[testsuite] Use system_tests.path() in some test cases
7 years ago
Dan Čermák
4e32929956
[testsuite] Add notes concerning escaping in commands
7 years ago
Dan Čermák
53c265f8a7
[testsuite] Add path conversion function
7 years ago
Dan Čermák
300b1dc0ef
[testsuite] Testsuite injects config file values into its namespace
7 years ago
Luis Diaz Mas
c26135a2da
CMake: indicate if XMP external is enabled
7 years ago
Luis Díaz Más
a3a24ce01e
Set libstdc++ with Xcode generator when using external XMP
7 years ago
Luis Diaz Mas
b590fa542a
Disable 'embedded' XMP when EXIV2_ENABLE_EXTERNAL_XMP is enabled
7 years ago
Luis Díaz Más
1ea0eb83df
Remove useless code for Mac
7 years ago
Luis Diaz Mas
88fecdef3e
Add additional compiler flags when external XMP is enabled on Mac
7 years ago
Luis Díaz Más
038bffd1dd
CMake: Print linker flags in the configuration summary
7 years ago
Luis Díaz Más
93edcc11b3
Doc: Add documentation about how to use the external XMP SDK with conan & cmake
7 years ago
Luis Díaz Más
b53465954a
CMake: FATAL_ERROR when both XMP cmake variables are one.
...
EXIV2_ENABLE_XMP and EXIV2_ENABLE_EXTERNAL_XMP are mutually exclusive.
7 years ago
Luis Díaz Más
9cd8cc0968
conan: Do not bring Expat when xmp=True.
...
Since the external XMP SDK is already adding the expat sources to the XMPCore library, we do not
need the Expat dependency for Exiv2.
7 years ago
Luis Diaz Mas
96aa7ef3d7
Add info about adding the piponazo's conan repository
7 years ago
Luis Diaz Mas
f2c5fcf49d
Format README-CONAN.md file
7 years ago
Luis Diaz Mas
85abdff080
AppVeyor: Remove explicit option EXIV2_ENABLE_XMP. Already ON by default
7 years ago
Luis Diaz Mas
9586928d29
Add CMake code to handle external XMP
...
Experiment: Try with testing package
7 years ago
D4N
e483856a61
Merge pull request #328 from Exiv2/memory_fixes
...
Memory issue fixes
7 years ago
Dan Čermák
a1a9c3d79a
Use reinterpret_cast instead of C style cast
7 years ago
Dan Čermák
088986e5fa
[unit_tests] Remove a memory leak from test_XmpKey.cpp
...
XmpProperties::registerNs allocates strings on the heap that must be freed
manually via XmpProperties::unregisterNs().
=> do this in TearDownTestCase()
7 years ago
Dan Čermák
b51b6fc52d
Prevent an out of bounds read in strstr in JpegBase::printStructure
...
The xmp byte array is not necessarily null terminated => strstr can read beyond
the bounds of the allocated array then.
Therefore use string_from_unterminated to remedy this issue.
Also replace xmp with a std::vector, as stl functions can throw and we don't
want a memory leak.
7 years ago
Dan Čermák
510560bbd1
Prevent out of bounds read in jpgimage.cpp JpegBase::printStructure
...
signature is extracted from an image and can lack the terminating \0, this
causes the std::string constructor and strcmp to read beyond the bounds of the
allocated array.
=> Use string_from_unterminated to construct a std::string safely and use it
in the subsequent code & use stl functions instead of C functions
7 years ago
Dan Čermák
dd52b1a832
Add helper_functions.cpp/hpp & unit tests
...
- add function which constructs a new std::string from a potentially not null
terminated char *
- add unit tests
7 years ago
Luis Diaz Mas
4713336c93
Add more unit tests for TiffHeader
7 years ago
Luis Diaz Mas
59493d1edc
Fix bug in Cr2Header::read
7 years ago
Luis Diaz Mas
b1c34ee11f
Add unit tests for Cr2Header
7 years ago
Luis Diaz Mas
1d27c21639
Rename files from cr2image_int to cr2header_int
7 years ago
Luis Diaz Mas
8eca055058
Add POC + regression test.
...
Note that we override here the method check_no_ASAN_UBSAN_errors to also
analyze the last two lines of got_stderr.
7 years ago
Luis Diaz Mas
67a5a74115
Throw when trying to write out of the buffer
7 years ago
Luis Diaz Mas
863aaebc92
Use index to access buf.pData_
7 years ago
Luis Diaz Mas
ed874703ad
Prevent call to memcpy with size==0
7 years ago
Luis Diaz Mas
f17636460f
Remove tags_int.cpp that was not used in the project
...
I introduced that file accidentally in the project while trying to move
the implementation details to xxx_int.cpp files. In this case, I found
out some issues and I just decided to leave the implementation in the
file tags.cpp.
7 years ago
D4N
89bd7d5ca1
Merge pull request #287 from Exiv2/port_redmine_issues
...
Port redmine issues 426-825 to the new test suite
7 years ago
Luis Díaz Más
b8b94dc67a
Escape characters properly once we started using python literals
7 years ago
Luis Díaz Más
48078e9c8b
Fix tests on windows by using os.path.join
7 years ago
Luis Díaz Más
72faa7331d
Fix issues with python strings & literals
7 years ago
Dan Čermák
90c8d754b7
[testsuite] Call subprocess.Popen() with shell=True on Windows
7 years ago
Dan Čermák
939ded283f
[testsuite] check stderr before stdout
...
That way you get to see error messages about wrong filenames instead of an
empty stdout
7 years ago
Dan Čermák
61dbba1396
[travis] Don't run python tests twice
...
make tests already runs the python test suite, no need to do so again
7 years ago
Dan Čermák
4826d87513
[Appveyor] Set environment variable for the Windows version of cat
7 years ago
Dan Čermák
f55cdce761
[testsuite] Port redmine issues 498-825
7 years ago
Dan Čermák
2356984274
[testsuite] Ported redmine bugfixes 426-495
7 years ago
Dan Čermák
de33dbc497
Add Vagrant VMs & combine it with gitlab-ci
...
- add Vagrantfile to contrib/vms
- add custom provisioning via shell scripts
- move gitlab-ci before_script: to ci/install_dependencies.sh which is also used
by vagrant
- change COPR setup on CentOS 7 (yum-plugin-copr does not seem to work)
7 years ago
Luis Diaz Mas
1371d677f9
Remove custom messages from enforce(xxx, Exiv2::kerCorruptedMetadata)
7 years ago
Luis Diaz Mas
c0a879aea4
Fix call to std::count, so that we count until the end of the array
7 years ago
Luis Diaz Mas
3ad0050469
Check validity of compressionFlag & compressionMethod
7 years ago
Luis Diaz Mas
2fb00c8a16
Analyze minimum needed number of null separators in PngChunk::parseTXTChunk
...
This commit fixes the heap-buffer-overflow in PngChunk::parseTXTChunk.
According to the specification:
http://www.libpng.org/pub/png/spec/1.2/PNG-Chunks.html
There must be 2 null separators when we start to analyze the language tag.
7 years ago
Luis Diaz Mas
234e5794f6
Add tests for #306
7 years ago
Luis Diaz Mas
a227fcda39
debug: Add new debug message to print the PNG chunk being processed
7 years ago
Luis Diaz Mas
b0696d4da6
style: Apply formatting guidelines to one-line ifs
7 years ago