Rosen Penev
55fffbb97e
cppcheck: add const to pointers
...
Found with constVariablePointer
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Rosen Penev
6b4732365b
remove boilerplate
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Rosen Penev
b832728988
add std::endian support if available
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Rosen Penev
100eabbc08
add std::byteswap support
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Rosen Penev
1837bf055e
memcpy to copy_n conversions
...
The latter is more strict regarding types
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Rosen Penev
d4f6c9cf40
coverity fixes
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Miloš Komarčević
c686bed5f8
Use compiler macros for endianness
2 years ago
Rosen Penev
e4a4791b35
endian check from runtime to compile time
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Rosen Penev
6fd143d6a4
sonarlint cleanups
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Rosen Penev
b9d94e61fe
coverity: remove dead code
...
Found with: CID 1521533
Unsigned compared against 0 (NO_EFFECT)
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Rosen Penev
5eebbbcbfb
make conversions explicit
...
Found with MSVC's C4244
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Rosen Penev
d2ddf228ad
replace switch with if/return
...
Fixes warning C4702: unreachable code
No other way to make all compilers gappy.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Rosen Penev
f21b2a2170
std to Exiv2 find
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Rosen Penev
376638259d
namespace enforce.hpp functions to Internal
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Rosen Penev
3e97850e97
manual default member init
...
clang-tidy suggests this but fails to apply it.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Mohamed Ali Chebbi
1c764358bb
Encapsulate video support with compilation variable EXV_ENABLE_VIDEO ( #2448 )
...
* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO
* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: add variable to unit test files
* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: encapsulate in makefile
* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: fix PR windows matrix
* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: activate only for concerned CI tests
* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: desable for linux release
* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: add to Fuzz PR
3 years ago
Mohamed Ali Chebbi
7fac35e19a
1748 Video Support in V1.0: part 3/3 : support Asfvideo ( #2416 )
...
* 1748 Video Support in V1.0: part 3/3 : support AsfVideo
* 1748 Video Support in V1.0: part 3/3 : support AsfVideo : fix Mac Os error compile
* 1748 Video Support in V1.0: part 3/3 : support AsfVideo : delete unuseful warnings
* code review and clean up some code
3 years ago
Mohamed Ali Chebbi
d755fc18b5
1748 Video Support in V1.0: part 2/3 : support Riffvideo ( #2415 )
...
* 1748 Video Support in V1.0: part 2/3 : support RiffVideo
* limit the buffer_size
* Update exiv2.md
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
* Code Review and cleanUp code
* Update riffvideo.hpp
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
3 years ago
Mohamed Ali Chebbi
1280f3b849
1748 Video Support in V1.0: part 1/3 : support MatroskaViedo ( #2413 )
...
* 1748 Video Support in V1.0: part 1/3 : support MatroskaViedo
* Simplify the code of matroskavideo
* protect conevrtuint64 method from overflow
* use size_t instead of uint64_t
3 years ago
Rosen Penev
fd7566fcd8
get rid of nested if conditions
...
Easier to read with lambdas.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Christoph Hasse
3456f30988
fix(video) clang-format quicktimevideo
3 years ago
Christoph Hasse
393815ffb0
fix(video) filetype detection: handle video via quicktimevideo.cpp and other ftyp files in bmffimage
3 years ago
Christoph Hasse
0a948c6a7d
feat(video) revive quicktime.{h,cpp} and adapt to codebase changes.
3 years ago
Rosen Penev
b8855fb3b5
misc sonarlint cleanups
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Kevin Backhouse
b0040e3bbe
Convert type of depth parameter to size_t.
3 years ago
Kevin Backhouse
0f1ea7571b
Refactor printTiffStructure depth increment
3 years ago
Kevin Backhouse
46f2ef8009
Refactor printIFDStructure depth increment
3 years ago
Rosen Penev
9ca7f861cf
remove string_view from headers
...
This should allow usage with C++11 projects. It's also wrong. The only
user of this assigns an std::string from a string_view, which is not
safe.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Kevin Backhouse
b9b2d7741b
Fix some "unsafe vector access" warnings.
3 years ago
Kevin Backhouse
7f673c766d
Fix some "signed shift" warnings
3 years ago
Kevin Backhouse
a5c521ea57
Merge pull request #2252 from neheb/2
...
clang-tidy: use default member init
3 years ago
Kevin Backhouse
1ada360774
Fix some incorrect format specifiers.
3 years ago
Rosen Penev
bae7da19ca
clang-tidy: use default member init
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Kevin Backhouse
ad4e13b827
Change return type of BasicIo::tell() to size_t.
3 years ago
Rosen Penev
b4c90b5e16
clang-tidy: replace pointer magic with data()
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Luis Díaz Más
25c47cd1cf
Merge pull request #2197 from Exiv2/mainRefactoringFormats
...
Refactoring in JpegImage and Photoshop classes
3 years ago
Luis Díaz Más
f942ba89bd
Move Photoshopb class to internal namespace
3 years ago
Rosen Penev
0d971e98e4
remove some unique_ptrs
...
They're not really used as pointers.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Rosen Penev
9dc35e7380
find to std::find
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Luis Díaz Más
d7f35e33f0
Remove useless static_casts
3 years ago
Luis Díaz Más
ae4df71233
Remove DataBuf::copyBytes and use std::copy instead
3 years ago
Luis Díaz Más
b05573fadc
Remove most of the asserts from codebase
3 years ago
Luis Díaz Más
30bf563f4d
Update .clang-format file & apply clang-format to whole project
3 years ago
Rosen Penev
b2b6d834ba
some std::array conversions ( #2148 )
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Luis Diaz
7576a2757b
More size_t for sizes
3 years ago
Luis Díaz Más
96f7f2e4c5
Convert Exiv2::ErrorCode into an enum class
3 years ago
Luis Díaz Más
c115d4daf7
Merge pull request #2131 from Exiv2/mainCleanups
...
Include what you use + more SPDX identifiers + few other cleanups
3 years ago
Rosen Penev
8dadcdf72a
manual nullptr removals
...
unique_ptr has a bool overload. It's also easier to reason about.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Luis Díaz Más
8b1fe379a1
Removing unused headers thanks to IWYU
3 years ago
Luis Díaz Más
3f3b651c04
Remove unused stuff
3 years ago