0dcd8605c9
fix mmap compilation
...
CI doesn't catch all cases failing.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
c9bdd6ed94
Merge pull request #2209 from Exiv2/mainTODOs
...
Improvements around TODO comments
3 years ago
d59e1433c0
replace readlink with std::filesystem
...
Simpler.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
707e22c577
Add some F mount lenses
3 years ago
6438305234
Merge pull request #2212 from neheb/1
...
1
3 years ago
bd1758c3c5
remove some double pointer stuff
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
65c5b772c9
fix misplaced const
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
c9c2a1847b
remove const std::function
...
std::move is used.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a86bc386da
reference conversions
...
There's no nullptr here.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
48f848f5bb
clang-tidy: remove const params in decls
...
Found with readability-avoid-const-params-in-decls
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
2e721a716e
std::function conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
d466c1e9eb
minor clang-tidy fixes ( #2213 )
...
* clang-tidy: add const to member function
Signed-off-by: Rosen Penev <rosenp@gmail.com>
* clang-tidy: remove duplicate access specifier
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
471b816491
Merge pull request #2211 from neheb/1
...
clang-tidy: default member init
3 years ago
3a8a8b29a2
std::pair conversion
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a8061e7ee9
clang-tidy: default member init
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
151b54ab3e
remove default constructor
...
This is rule of zero.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
f3f6ffb855
ci: move pvsStudio job to its own workflow & use new flag
...
The license will expire in approximately 1 month. I disabled the
expiration check.
3 years ago
2b74cc885d
Revert some boilerplate which is not needed
3 years ago
d4ffcb9497
utils are in Internal namespace
3 years ago
cc79051b79
Move 1-liner to header file
3 years ago
74da8a394f
Remove deprecated todo
3 years ago
ee855c0e71
Reduce amount of string transformations
3 years ago
d5742f449b
Move string helpers to utils
3 years ago
1a3e93856b
More tests for rational convertions
3 years ago
8da71e7133
Test parseUint32 and fix it when number is out of limits
3 years ago
331924612e
Remove duplication by using templates
3 years ago
2b91b5daf9
More tests for DataBuf read/write functions
3 years ago
6964f5f9f2
DataBuf::c_data() returns nullptr when empty + avoid duplication
...
After the previous commit, I realized that std::vector::data() also
returns nullptr when the vector is empty. So I decided to emulate this
behavior in DataBuf::c_data().
Anyways, the changes done in the previous commit are valid and allow us
to avoid some processing when the DataBuf is empty.
3 years ago
c3d0100d48
Fixing bad usages of DataBuf (when it is empty)
3 years ago
4a4a8c544c
Throwing when trying to access TooFar elements in DataBuf
3 years ago
941017d281
Fix issues on ARM builds ( #2205 )
...
* Specify base class initialization in Copy Constructor
* Fix printing of uint64_t variable in ARM 32bits
Use cinttypes
* Fix alignment issues on ARM 32 bits
* tests: add assertion with custom message
3 years ago
6203ded16f
add constexpr constructor
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
6c99577f1d
Merge pull request #2203 from Alan01/patch-1
...
Create da.po
3 years ago
8d2e1926ca
remove unused class declarations
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
25c47cd1cf
Merge pull request #2197 from Exiv2/mainRefactoringFormats
...
Refactoring in JpegImage and Photoshop classes
3 years ago
84ba579af4
Merge pull request #2200 from neheb/3
...
clang-tidy with headers
3 years ago
f07c88de5d
Use .front() to avoid warning from static analysis
3 years ago
4d99c2aca1
Use std::pair to return multiple values
3 years ago
4ee9c35799
Include missing iostream header in photoshop.cpp
3 years ago
f942ba89bd
Move Photoshopb class to internal namespace
3 years ago
047f6b733e
Change logic to determine if segment has size
...
Note that the failing tests that had to be adapted were bad formed files
from FUZZERs. We should not consider invalid markers like 0x00 or 0x52
but only undefined APPn markers.
3 years ago
400632f27b
Factor out function readSegmentSize()
3 years ago
24d2a7b8f0
JpegBase::markerHasLength moved to implementation details
3 years ago
23fe743d4d
Move private constants to .cpp
3 years ago
b00e460d76
Move static functions to anonymous namespace
3 years ago
c997b09a81
algorithm conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
d789968e90
replace malloc/free with new/delete
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
b53ed72fd8
clang-tidy: manual special functions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a20ace20fc
clang-tidy: manual clang-tidy fixes
...
clang-tidy has issues applying these.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
ae66ecec0d
clang-tidy: use nullptr
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Rosen Penev
Luis Díaz Más
Miloš Komarčević
Miloš Komarčević