78e9c8aa82
address + box_length == box_end
4 years ago
02d4ef2c5e
Support for 64-bit box lengths looked broken.
4 years ago
8c64e9abba
Add `pbox_end` param to `BmffImage::boxHandler` to enforce box nesting.
4 years ago
3e681c6730
fix: avoid processing MOV (quicktime) files when BMFF is enabled
...
(cherry picked from commit 1b6895927f293855e5bb437ad28f31da2c2cfe54)
4 years ago
2b84f4bd64
fix: zero initialize local variables. ( #1743 )
...
* Zero initialize local variables.
* Initialize xmpID_
4 years ago
f30022d73d
Fix issues detected with PVS-Studio + other little improvements ( #1689 )
...
* avoid re-declaration of constant variables
* Replace pthreads critical section with std::mutex
* ci - better naming
* cmake - increase minimum version to 3.11. Use project DESCRIPTION
* fix - do not treat string::find() return type as bool
* remove conditions that were always true
* remove condition that were always false
* Remove EXV_HAVE_GMTIME_R which is not used anymore
* pixelWidth_ was inherited from Exiv2::Image
The width & height variables in the TiffImage class need to be mutable
to be able to change their values on the getters pixelHeight() and
pixelWidth() ... Do not ask me why ...
* Remove superfluous if
* pvs:V766 item with identical key added already
* pvs:V730 not all members were initialized (time)
* pvs:V730 not all members are initialized
* pvs:v668 no point in testing pointer against null after new
* pvs:V1048 variable assigned the same value
* replace c-style dynamic vector with std one
* pvs:547 fakeData is always true
* Remove useless constructor in derived class
* pvs:V690 modern way to disable copy-ctor
* Replace malloc/free with new/delete. No need to check for null
* pvs:V1028 cast operands and not result
* Remove custom MIN/MAX functions
* pvs:V595 pointer used before verified against null
* pvs: index used before being checked
* pvs:V1028 possible overflow. Cast operands
* pvs:v575 potential null pointer passed to other functions
* pvs:V547 deal with always true/false expressions
* pvs:V560 part of conditional expressions always false or true
* pvs:V701 possible break in realloc -> move to std::vector
* Make some classes 'final'
* Replace sprintf with std::to_string()
* fix compilation on windows
4 years ago
743da1a564
clang-tidy: use C++ casting
...
Found with google-readability-casting
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
cdbee3c26c
clang-tidy: init in member initializer
...
Found with cppcoreguidelines-prefer-member-initializer
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
b8712188bb
clang-tidy: use auto
...
Found with modernize-use-auto
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
8388223deb
Check that the string is properly terminated.
4 years ago
e8422732af
Fix LGTM warning about format specifier
...
https://lgtm.com/projects/g/Exiv2/exiv2/rev/pr-6633ad1cc6e6c36bffd6655165c299c53e934b22
4 years ago
e97a9ff88a
Fix signed/unsigned compiler warning.
4 years ago
27e349e063
Fix signed/unsigned compiler warning.
4 years ago
285e7a4e72
Fix out-of-bounds read in bmffimage.cpp
4 years ago
f85f7f717a
Replace many of the iterators types with auto
4 years ago
01a3bc716d
Fix warnings in VS
4 years ago
0a1bf46a1c
revert changes that are affecting to VS
4 years ago
de4d43d4d1
Fix warnings EXIV2_TEAM_EXTRA_WARNINGS
...
Most of the warnings fixed were:
- Hiding of local variables
- Hiding of globals
- Useless casts
- Conversions between float/double
4 years ago
206a2c495c
fix_enableBMFF_v1
4 years ago
0bbaa6eff3
cpp: Replace auto_ptr by unique_ptr
4 years ago
aef9cf76f7
fix_1503_JXL_bmff
4 years ago
49cfe45323
Merge pull request #1513 from Exiv2/fix_1508_enableBMFF
...
Fix 1508 enable bmff
4 years ago
9da2aed5d2
Use the documented 5 line prolog in every sample application. Tidy up sample prologs and header code.
4 years ago
190106ca78
fix_1507_avif_size0x0
4 years ago
f95d97a0bf
Add mif1 brand to heif mime type
4 years ago
fcb3066950
Include a few more BMFF major brands
4 years ago
e3c78623f7
Include HEIC type explicitly
4 years ago
212f1b5ebb
Following review by @piponazo, I am clarifying the bool return from Exiv2::enableBMFF().
4 years ago
e3fd0c633e
Thank You @piponazo for the code review. I've made the changes you requested.
4 years ago
2f2dd7d56c
Fix ICC profile handling (my bad, iOS files are correct).
4 years ago
0ad46453ed
With good fortune, bmffimage is ready for review.
4 years ago
ee4d14340a
Fix box.length == to use bigEndian decode! Fix toAscii() to emit on ascii 32-127 bytes.
4 years ago
71d29fe60b
Fix MSVC build breaker and modify test_pr_1475_HIF.py to run on Windows.
4 years ago
55d2201892
Changed CI build default -DEXIV2_ENABLE_BMFF=On. Fixed suite to run with/without bmff. -pS and -pR same for bmff.
4 years ago
c84274ec19
Cosmetic change to -pR/-pS output.
4 years ago
fd9cb67fb7
WIP: adding BmffImage::printStructure() and support for colr box.
4 years ago
4ca05ed34a
Fix .CR3 files to call parseXmp().
4 years ago
ea1c91874f
Added parseXmp() to parse Xmp metadata.
4 years ago
44d976c2a1
Remove bmffimage::printStructure() as discussed in review with @hassec. Corpse removal and cleanup in bmpfimage.hpp
4 years ago
5c77888037
Revised following code review by @hassec. Thank You, Christoph.
4 years ago
4d3af08ad8
Add CR3 image dimensions
4 years ago
4ae0a1d2a3
Tidy up. Rename Tag::cr3_exif -> Tag:cmt2
4 years ago
9515e4658b
Cleanup. 1. Recursively process uuid/cano box. 2. Fix LGTM/CI sprintf grumbles. 3. Comment parseTiff() in bmffimage.hpp.
4 years ago
913ee33372
Parse Exif in .HEIC/.AVIF
4 years ago
108670b309
Corrected format string
4 years ago
28b41f59bd
run clang-format on new files
4 years ago
29f3d5cac9
introduce parseTiff method to parse exif
4 years ago
f190f496d1
Tidying up. 1. pixelHeight_. 2. refactored indenter() -> indent(). 3. EXIV2_DEBUG_MESSAGES outputs to std::cerr
4 years ago
4a96025294
Fixed recursion issue in the meta box.
4 years ago
bafea0f1b8
[WIP] Fixed Image Spatial Extents Property Handling
4 years ago
Kevin Backhouse
Christoph Hasse
Luis Díaz Más
Rosen Penev
Robin Mills
Miloš Komarčević
Peter Kovář
Christoph Hasse