5413 Commits (31b96b58e759e939f852c723218e9681dfed3cb2)
 

Author SHA1 Message Date
Dan Čermák 31b96b58e7 [safe_op] improved signed int overflow checks via integer promotion
The fallback signed integer overflow check is quite expensive, but the addition
can be safely performed when saved in an int due to integer promotion
rules. This makes the check a little less expensive.
7 years ago
Dan Čermák 029b997ca0 [safe_op] fixed typo in doc-comment 7 years ago
D4N 28fa146d97
Merge pull request #230 from D4N/fix_170
Fix for #170
7 years ago
Dan Čermák cabf756553 Add reproducer for #170 to the test suite 7 years ago
Dan Čermák 751fba8b54 Added dataBuf size check before calling PngChunk::decodeIHDRChunk
- cdataBuf must be at least 8 bytes long otherwise decodeIHDRChunk
  reads out of bounds
- pngImage::readMetadata now skips png chunks where the offset for
  IHDR chunks is invalid
- added assertion into PngChunk::decodeIHDRChunk() to ensure dataBuf
  size
7 years ago
D4N a1ab522eda
Merge pull request #231 from D4N/pngimage_documentation_fix
Fix outdated documentation of PngImage::doWriteMetadata()
7 years ago
Dan Čermák 22a7a8c2ed Fix outdated documentation of PngImage::doWriteMetadata()
The function does not return anything, it only throws exceptions.
7 years ago
D4N 9f74f247b4
Merge pull request #227 from frli8848/master
Nikon mount - Sigma Lens Updates
7 years ago
Dan Čermák 73ac02d7f2 Added test for Sigma lenses 7 years ago
Fredrik lingvall fc8b45dd12 Added the Sigma 120-300mm F2.8 DG OS HSM | S for Nikon mount. 7 years ago
Fredrik lingvall 34a3be025e Added Sigma 50mm F1.4 DG HSM | A mount/UPC code (for Nikon mount). 7 years ago
Fredrik Lingvall 215227024d Added Sigma 20mm F1.4 DG HSM | A mount/UPC code (for Nikon mount). 7 years ago
D4N f9d421b172
Merge pull request #109 from D4N/error_codes_enum
[WIP] Added error codes from src/error.cpp into an enumeration
7 years ago
Dan Čermák 3965a44df2 Replace error variable names in test suite with enum error codes 7 years ago
Dan Čermák a15f090f81 Modified test suite so that case sensitive keys are possible 7 years ago
Dan Čermák efe2ccdcb6 Replaced all hardcoded error codes with ker... constants 7 years ago
Dan Čermák d897997b29 Force error code usage to construct a Exiv2::BasicError
changed parameter code_'s type from int to ErrorCode => requires the
usage of the enum constants
7 years ago
Dan Čermák d3c3c036b8 Incorporated error codes into errList 7 years ago
Dan Čermák b80fa1b4ed Added error codes from src/error.cpp into an enumeration 7 years ago
D4N efee9a2b58
Merge pull request #205 from D4N/CVE-2017-1000127_reproducer
Added reproducer for CVE-2017-1000127
7 years ago
Dan Čermák ead7f309b0 Added reproducer for CVE-2017-1000127 7 years ago
Robin Mills 55001c8ddf
Merge pull request #222 from Exiv2/fix-220
Fix 220
7 years ago
clanmills 7d837d9c86 Changes to test/Makefile following Dan's review. 7 years ago
D4N 9cddfa514d
Merge pull request #207 from D4N/fix_cve_2018_4868
Fix CVE-2018-4868
7 years ago
Dan Čermák 72de0f96f3 Added reproducer for CVE-2018-4868 to the test suite 7 years ago
Dan Čermák fcb4257051 Add check for DataBuf.size_ in Jp2Image::readMetadata()
When parsing a subBox that is a ColorHeader, a length is extracted
from the input file and fed directly into DataBuf() (which calls
malloc). A crafted input file can provide arbitrarily (up to
max(uint32_t)-8) large values and result in excessive memory
allocation.

This commit adds a check for the new size of DataBuf so that it is not
larger than the remaining size of the file.

This fixes #202 aka CVE-2018-4868
7 years ago
Robin Mills 7f56236bb8
Merge pull request #212 from Kicer86/master
fix for crash in bigtiff (issue #208)
7 years ago
Robin Mills a1f1989cb5
Merge branch 'master' into master 7 years ago
clanmills 06e3570f10 Trivial Documentation Update 7 years ago
clanmills 552247c3d0 Update test/Makefile not to exit on error 7 years ago
clanmills c082537967 Fix #220 https://github.com/Exiv2/exiv2/issues/220 7 years ago
D4N 5f360a99af
Merge pull request #217 from D4N/fix_187
Fix for #187
8 years ago
Dan Čermák 80c4d95171 Add regression test for CVE 2017-17669 8 years ago
Dan Čermák e0ab5aaa87 Add error 14 text as a variable to the test suite 8 years ago
Dan Čermák 4429b962e1 Fix out of bounds read in src/pngchunk_int.cpp by @brianmay
- consider that key is advanced by 8 bytes if stripHeader is true
  => length is reduced by same amount
  Fixed by adding offset to the check in the loop
- Rewrote loop so that keysize is checked before the next
  iteration (preventing an out of bounds read)
8 years ago
Robin Mills df4113b765 changes to MemIo::reserve() for #200 (#213)
* changes to MemIo::reserve() for #200

* Changes following review by Dan (thanks, Dan).
8 years ago
Michał Walenciak d219e61586 be more error prone 8 years ago
Michał Walenciak 24348e85ca checks for valid reads 8 years ago
Michał Walenciak 421c6d6723 improvements for issue #208 8 years ago
D4N b7d76da9d5
Merge pull request #203 from Exiv2/fix_201
Fix #201
8 years ago
Michał Walenciak dba9fba725 test for issue #208 8 years ago
Michał Walenciak 1647908e00 fix for crash in bigtiff (issue #208) 8 years ago
Dan Čermák 9900f523fe Added reproducer for #201 to the test suite 8 years ago
Robin Mills 7d42da94d0 Removed wrong ExifData::const_iterator that shadowed the correct one 8 years ago
D4N 4be065595e
Merge pull request #155 from D4N/python_test_suite_wip
[WIP][RFC] Python test suite
8 years ago
Dan Čermák 27d7a5d968 Added new test suite to travis & Appveyor 8 years ago
Dan Čermák 5267123186 Ported tiff-test.sh 8 years ago
Dan Čermák 085c9715fc Added some example test cases to the new test suite 8 years ago
Dan Čermák 2e745b0b26 Added replacement for the current regression test suite 8 years ago
Luis Díaz Más 00f32316b2 Add missing header 8 years ago