Rosen Penev
6e6f709276
cppcheck: small bool simplification
...
Found with duplicateConditionalAssign
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Rosen Penev
d4f6c9cf40
coverity fixes
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Rosen Penev
7477293e41
avoid newer clang-format issue
...
More readable anyway.
Also remove specific version. Problems have been fixed already. All
versions should work the same now.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Rosen Penev
233f404ac7
direct initialize some structs
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Rosen Penev
22b12012a6
more SonarLint cleanups
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Rosen Penev
ca95edc6bd
random fixes
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Rosen Penev
725875497b
SonarLint cleanups
2 years ago
Rosen Penev
9f21b78311
add contains function
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Rosen Penev
629f94eea3
unreachable code
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Rosen Penev
6976aab5bd
replace substr with resize/pop_back
...
Shorter and more efficient.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
Rosen Penev
67df85135d
early exit
...
less indentation
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Rosen Penev
28d1880176
replace find/rfind with startsWith
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Rosen Penev
fc840405cc
revert std::function back to function pointers
...
The former has too much overhead. No point in it.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Rosen Penev
1d0530f04d
misc sonarlint changes
...
Mostly const changes.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Peter
dc4ae73013
Add tag description option to exiv2 app ( #2279 )
...
* Add `tagDesc()` to (Exif|Xmp|Iptc) Datums and Keys
* Add `--Print d` option to exiv2 app
* Add testing for all exiv2 application `--Print` options
* Update manpage
3 years ago
Rosen Penev
fc1a398488
clang-tidy: remove const
...
It doesn't do what it's supposed to here.
Found with misc-misplaced-const
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Rosen Penev
ae66ecec0d
clang-tidy: use nullptr
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Rosen Penev
fdfcde5e4b
structured binding conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Rosen Penev
aa41d557b2
function move
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Luis Díaz Más
30bf563f4d
Update .clang-format file & apply clang-format to whole project
3 years ago
Luis Díaz Más
573c3c79fc
Merge pull request #2145 from Exiv2/mainSizeT_n
...
More migration to size_t
3 years ago
Jim Easterbrook
04ae6c2c4c
Add key name to "Value not set" error message ( #2149 )
...
The error typically occurs when writeMetadata() is called. It's easier
to find the problem if you know which datum hasn't had a value set.
3 years ago
Luis Diaz
7576a2757b
More size_t for sizes
3 years ago
Luis Diaz
137ea080b5
Change Metadatum::size() return value from long to size_t
3 years ago
Luis Diaz
62aad98d0b
Change Metadatum::copy return value from long to size_t
3 years ago
Luis Díaz Más
96f7f2e4c5
Convert Exiv2::ErrorCode into an enum class
3 years ago
Luis Díaz Más
c115d4daf7
Merge pull request #2131 from Exiv2/mainCleanups
...
Include what you use + more SPDX identifiers + few other cleanups
3 years ago
Luis Díaz Más
a009ac1f61
Merge pull request #2135 from neheb/1
...
manual nullptr removals
3 years ago
Rosen Penev
8dadcdf72a
manual nullptr removals
...
unique_ptr has a bool overload. It's also easier to reason about.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Miloš Komarčević
eb49d66caf
Strip XMP raw packet before decoding
3 years ago
Luis Díaz Más
f894ee0568
Fix debug builds
3 years ago
Rosen Penev
61a5d8594c
remove some new
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Luis Díaz Más
b3a216310a
Removing unused headers thanks to IWYU
3 years ago
Rosen Penev
f0d23eca9b
clang-tidy: add some missing operators
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Rosen Penev
133849c394
clang-tidy: remove pointless get()
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Rosen Penev
5833101b9b
manual nullptr conversions
...
Mostly not caught because I'm not running clang-tidy on Windows.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
Luis Díaz Más
b17828b454
Use SPDX for licenses ( #2122 )
...
* Use SPDX identifier in header files
* Use SPDX identifier in rest of source files
* Fix usage of SPDX for files with 2 licenses
* Add global license file
* Fix compilation
3 years ago
Luis Díaz Más
208ec70df8
Fix windows builds
3 years ago
Luis Díaz Más
b9f9d041ea
Several transformations on DataBuf + migration to size_t
...
- Provide begin/end iterators to DataBuf and simplify code
- Adapt test output after last changes
- Replacing long by size_t in value.hpp
- Use size_t in some Photoshop functions
- Remove some static_casts
3 years ago
Kevin Backhouse
256365830a
Replace Metadatum::toLong() with Metadatum::toInt64().
3 years ago
Kevin Backhouse
2a3dd2def9
Replace Value::toLong with Value::toInt64. ( #2062 )
...
* Replace Value::toLong with Value::toInt64.
* Fix compiler warning.
* Fix compile error.
* Fix declaration of canonEv
* Fix compiler warning.
* Fix compiler warning.
* Use int64_t for offsets in tiffcomposite_int.cpp
* Fix compiler warning.
* Fix compiler warnings.
* Fix compiler warning.
* Fix compiler warning.
* Fix compiler warning.
* Fix compiler warning.
* Remove static_cast<long int> in TagDetails initializer.
3 years ago
Luis Díaz Más
b67dee8a57
Fix build on linux
3 years ago
Luis Díaz Más
0f03e77634
Simplify code around UniquePtr(s) & use make_unique over new
3 years ago
Luis Díaz Más
9d8dd86945
Use auto to reduce verbosity around code dealing with iterators
3 years ago
mergify[bot]
2d80891837
Only include expat.h when XMP is enabled. ( #1973 )
...
(cherry picked from commit 03cc59122249e79c5a72982b25dad88f4c2803d6)
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>
4 years ago
Kevin Backhouse
ce02361a64
Only build XMLValidator when XMP is enabled.
4 years ago
Kevin Backhouse
b35cc5ffa6
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=37363
...
Do some basic XML validation before running the xmpsdk library to avoid bugs in xmpsdk.
4 years ago
Kevin Backhouse
944e68fa15
Merge pull request #1787 from Exiv2/mergify/bp/main/pr-1766
...
Extra checking to prevent loop counter from wrapping around (backport #1766 )
4 years ago
Kevin Backhouse
69d82ffe01
Defensive coding changes to avoid integer overflow in loop conditions.
4 years ago
Kevin Backhouse
dc2c77ce81
Safer std::vector indexing.
4 years ago