5386 Commits (72de0f96f35d05ba68b28f4fa82f51a1df2778ca)
 

Author SHA1 Message Date
Dan Čermák 72de0f96f3 Added reproducer for CVE-2018-4868 to the test suite 7 years ago
Dan Čermák fcb4257051 Add check for DataBuf.size_ in Jp2Image::readMetadata()
When parsing a subBox that is a ColorHeader, a length is extracted
from the input file and fed directly into DataBuf() (which calls
malloc). A crafted input file can provide arbitrarily (up to
max(uint32_t)-8) large values and result in excessive memory
allocation.

This commit adds a check for the new size of DataBuf so that it is not
larger than the remaining size of the file.

This fixes #202 aka CVE-2018-4868
7 years ago
Robin Mills 7f56236bb8
Merge pull request #212 from Kicer86/master
fix for crash in bigtiff (issue #208)
7 years ago
Robin Mills a1f1989cb5
Merge branch 'master' into master 7 years ago
D4N 5f360a99af
Merge pull request #217 from D4N/fix_187
Fix for #187
7 years ago
Dan Čermák 80c4d95171 Add regression test for CVE 2017-17669 7 years ago
Dan Čermák e0ab5aaa87 Add error 14 text as a variable to the test suite 7 years ago
Dan Čermák 4429b962e1 Fix out of bounds read in src/pngchunk_int.cpp by @brianmay
- consider that key is advanced by 8 bytes if stripHeader is true
  => length is reduced by same amount
  Fixed by adding offset to the check in the loop
- Rewrote loop so that keysize is checked before the next
  iteration (preventing an out of bounds read)
7 years ago
Robin Mills df4113b765 changes to MemIo::reserve() for #200 (#213)
* changes to MemIo::reserve() for #200

* Changes following review by Dan (thanks, Dan).
7 years ago
Michał Walenciak d219e61586 be more error prone 8 years ago
Michał Walenciak 24348e85ca checks for valid reads 8 years ago
Michał Walenciak 421c6d6723 improvements for issue #208 8 years ago
D4N b7d76da9d5
Merge pull request #203 from Exiv2/fix_201
Fix #201
8 years ago
Michał Walenciak dba9fba725 test for issue #208 8 years ago
Michał Walenciak 1647908e00 fix for crash in bigtiff (issue #208) 8 years ago
Dan Čermák 9900f523fe Added reproducer for #201 to the test suite 8 years ago
Robin Mills 7d42da94d0 Removed wrong ExifData::const_iterator that shadowed the correct one 8 years ago
D4N 4be065595e
Merge pull request #155 from D4N/python_test_suite_wip
[WIP][RFC] Python test suite
8 years ago
Dan Čermák 27d7a5d968 Added new test suite to travis & Appveyor 8 years ago
Dan Čermák 5267123186 Ported tiff-test.sh 8 years ago
Dan Čermák 085c9715fc Added some example test cases to the new test suite 8 years ago
Dan Čermák 2e745b0b26 Added replacement for the current regression test suite 8 years ago
Luis Díaz Más 00f32316b2 Add missing header 8 years ago
Luis Díaz Más 22527f0927 Add reproducer for issue #188 8 years ago
Luis Díaz Más 14ff034fb4 Catch std::overflow_error exception in Print::run 8 years ago
Luis Diaz Mas d09c4bb7cd Fix arithmetic operation overflow 8 years ago
Luis Diaz Mas d1b4df5533 Show the Appveyor badge corresponding to the master branch 8 years ago
D4N 2c1d5288c2
Merge pull request #198 from Exiv2/fix_errno_failure_Fedora
Reset errno to 0 before unit test probing strerror(errno)
8 years ago
Dan Čermák 1de633ad37 Reset errno to 0 before unit test probing strerror(errno)
errno can be set to a non-zero value from a previously failed system
call, it is not reset by successful ones
=> have to do that manually or the unit test fails because it detects
   an "outdated" error message
8 years ago
D4N eec3f9a0c5
Merge pull request #194 from Exiv2/integer_overflow_checks
Add Integer addition overflow checks
8 years ago
Luis Díaz Más a1023c39ab Add safe_op.hpp to LIBEXIV2_PRIVATE_HDR (to be shown in IDEs) 8 years ago
Dan Čermák 7c00e9128d Fix compilation error with gcc < 5
- overflow builtins were added with gcc 5.0
8 years ago
Dan Čermák 3b3283e37d Added unit tests for new overflow checking addition functions 8 years ago
Dan Čermák ca7c699aa1 Added overflow safe addition function 8 years ago
Luis Díaz Más 39377b8c02 Fix strError tests on Mac 8 years ago
Luis Díaz Más 9b463708a4 Test runner return the gtest return value 8 years ago
Luis Díaz Más 3cf3635ae2 [travis] Fix unit tests on Mac.
- Use libc++ instead of libstdc++ in the conan profile
- Add CMAKE_OPTIONS for Mac
8 years ago
Luis Díaz Más 6d41884245 [AppVeyor] Re-enable unit tests and compile project in release mode
The problem was that we were not indicating the CMAKE_BUILD_TYPE when
calling CMake. It is important to set that CMake variable when using
the Ninja generator.
8 years ago
Luis Díaz Más a1213c1d90 Use the DEBUG compiler definition in Debug mode 8 years ago
Luis Díaz Más 74a5c5f770 [travis] Fix mac osx jobs
- Specify concrete ubuntu and mac versions
- Use latest conan version
- Fix the profiles for linux and mac
- Use new version of expat (avilable in conan-center)
- Install urllib3 as suggested in python guidelines
- Use virtualenv with python3
8 years ago
Luis Díaz Más 3ccc64d713 [travis] Re-enable osx 8 years ago
Robin Mills 8f5b795eaa Fixes to autotools build to respect mn_int.cpp files (#186)
* Fixes to autotools build to respect mn_int.cpp files

* Changes following Luis' code review.
8 years ago
D4N 6b29822670
Merge pull request #169 from D4N/reproducer_redmine_1305
Added reproducer for redmine issue 1305
8 years ago
Dan Čermák 42090c1625 Updated bugfixes-test.out 8 years ago
Dan Čermák 305d22136c Added reproducer for issue 1305 on exiv2 redmine
http://dev.exiv2.org/issues/1305
8 years ago
Luis Díaz Más f36bea3801 exiv2::getEnv throws std::out_of_range on unexpected EnVar
This change define explicitly the behavior that exiv2::getEnv should have
on response to unexpected inputs.

There are some other minor changes:

- Use _putenv_s for the unit tests on Windows
- Add todo comment
- Remove deprecated note about freeing memory
8 years ago
Luis Díaz Más 8dc3c1f0a0 Replace malloc/free by new/delete. Use const char* for input arg 8 years ago
Luis Díaz Más bfe057ca20 Auto-formatting done by the IDE while touching code in the previous commits 8 years ago
Luis Díaz Más 8b049922d7 Change exiv2::urlencode signature to return std::string
The goal of this change is to remove the responsibility from the client code to
free the memory of the returned string.
8 years ago
Luis Díaz Más fd5f131f4e Add characterisation test for exiv2::urlencode 8 years ago