Rosen Penev
cdbee3c26c
clang-tidy: init in member initializer
...
Found with cppcoreguidelines-prefer-member-initializer
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
8564d0b394
clang-tidy: pass by value
...
Found with modernize-pass-by-value
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
b8712188bb
clang-tidy: use auto
...
Found with modernize-use-auto
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
fdf9d3799c
clang-tidy: don't use else after return
...
Found with llvm-else-after-return
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
674fdcd38b
clang-tidy: fix declartation names
...
Found with readability-inconsistent-declaration-parameter-name
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
2e73aa9dc0
default con/destructors in headers
...
Helps to optimize trivially destructable stuff.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
5d716c7df4
clang-tidy: empty() conversions
...
Found with readability-container-size-empty
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
143a1fbbe2
clang-tidy: don't use string compare
...
Found with readability-string-compare
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
8337462032
clang-tidy: use empty() instead of comparing size
...
Found with readability-container-size-empty
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
af7b2430c5
clang-tidy: use override
...
Found with modernize-use-override
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
15f0a600ed
clang-tidy: use default member init
...
Found with modernize-use-default-member-init
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
bd6a996181
clang-tidy: use using
...
Found with modernize-use-using
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
b3040da54c
clang-tidy: don't check for NULL with delete
...
Found with readability-delete-null-pointer
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
1dc1186760
clang-tidy: simplify boolean expressions
...
Found with readability-simplify-boolean-expr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
8128716287
clang-tidy: use = default
...
Found with modernize-use-equals-default
Ran through git clang-format
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Luis Díaz Más
9de534976f
msvc: fix compiler warning on x86
4 years ago
Luis Díaz Más
90dde02359
Win - Disable UNICODE which is failing at the moment
4 years ago
Rosen Penev
84220855b2
clang-tidy: use = delete
...
Found with modernize-use-equals-delete
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Luis Díaz Más
75bf666d3b
Remove typedef to Dictionary::const_iterator
4 years ago
Luis Díaz Más
94b87a8dec
Remove deprecated SSH support
4 years ago
Robin Mills
d632988bbd
Massive code prolog cleanup.
4 years ago
clanmills
37cc2db72d
fix 1307 ASAN issues with RemoteIo
5 years ago
Robin Mills
7bf40a2408
fix_1211_c++11_0.27. I'll explain this in the PR.
5 years ago
clanmills
5b4743301e
The smart robot at codeCover/lgtm spotted typos in the code! Robot's almost as smart as Dan!
5 years ago
clanmills
c920f2ac44
CurlIo/http object to throw kerFileOpenFailed and not kerTiffDirectoryTooLarge
5 years ago
clanmills
f768fc0a42
RemoteIo/http object to throw kerFileOpenFailed and not kerTiffDirectoryTooLarge
5 years ago
clanmills
63a13e8620
Adding option -DEXIV2_BUILD_USE_C++11
5 years ago
Luis Diaz Mas
235087af4e
Do not call tell() in File::eof() - Fix tests & performance
5 years ago
clanmills
7658d8aefd
fix_macOS_0.27
5 years ago
Robin Mills
4852bd2ab2
fix_910_remote_io_block+1
6 years ago
Kevin Backhouse
edb4bf78ca
Add bounds check to MemIo::seek(). ( #944 )
...
- Regression test for missing bounds check in MemIo::seek()
- Add bounds check to MemIo::seek(), this fixes CVE-2019-13504
(cherry picked from commit bd0afe0390439b2c424d881c8c6eb0c5624e31d9)
Additional fixes for 0.27:
- Add fix for the linux variant of MemIo::seek
- Change type of variable from unsigned to signed
6 years ago
Luis Díaz Más
113136e134
Replace DEBUG with EXIV2_DEBUG_MESSAGES
...
Fixes #926
6 years ago
clanmills
ab0b97c729
fix895-ICCProfile-FalseWarning
6 years ago
Luis Diaz Mas
6f8d8e3da6
cleanup header inclusions in API
7 years ago
Luis Díaz Más
59ba209fe8
Move BlockMap to .cpp file (Remove it from API)
...
- Also make some BlockMap methods const
7 years ago
Luis Díaz Más
59013f2e2f
Formatting code
7 years ago
Luis Díaz Más
603692a1d8
Copyright to Exiv2 authors
7 years ago
Dan Čermák
39399ac5e8
Remove memory leak in SshIo::SshImpl::getDataByRange
...
The buffer array is not deleted, when an exception is thrown
(happens for nBytes< 0).
=> use std::vector<char> instead
7 years ago
Dan Čermák
bc58752d18
Remove useless casts
...
This commit removes only casts where type A is cast to the exactly same
type (and not to a platform dependent typedefs)
7 years ago
Dan Čermák
fc60d97a29
Prevent passing of null-pointers to libc functions
7 years ago
Dan Čermák
2bf89f4854
Store pointers to Impl classes in auto_ptr
...
Pimpl class Impl is stored in raw pointers which are allocated on the heap in
the constructor. However, the constructor can throw an exception resulting in a
memory leak as the destructor is **not** invoked.
=> A smart pointer is however properly deallocated.
7 years ago
Dan Čermák
efe2ccdcb6
Replaced all hardcoded error codes with ker... constants
7 years ago
Robin Mills
df4113b765
changes to MemIo::reserve() for #200 ( #213 )
...
* changes to MemIo::reserve() for #200
* Changes following review by Dan (thanks, Dan).
8 years ago
Luis Díaz Más
bfe057ca20
Auto-formatting done by the IDE while touching code in the previous commits
8 years ago
Luis Díaz Más
8b049922d7
Change exiv2::urlencode signature to return std::string
...
The goal of this change is to remove the responsibility from the client code to
free the memory of the returned string.
8 years ago
tbeu
5b5987a596
Remove obsolete EXIV2_RCSID
8 years ago
tbeu
5df8b01b77
Remove obsolete svn revision
8 years ago
Luis Díaz Más
8ad49f6d73
Robin changes in sync with master changes
8 years ago
clanmills
6e3855aed7
Fix https://github.com/Exiv2/exiv2/issues/55
8 years ago
clanmills
d366943297
Refactoring EXV_USE_CURL and EXV_USE_SSH
8 years ago
Robin Mills
82dbe6199d
https://github.com/Exiv2/exiv2/issues/11 Closed. Coincidentally Raphael reported issues with Visual Studio 2015 Community Edition. Issue 11 and Raphael's issues should now be resolved.
8 years ago
Robin Mills
559ace375b
#1291 Reverting change in r4763 relating to windows.h as they break the Cygwin build. Retain changes in exiv2/exiv2.hpp and exv_msvc.h
8 years ago
Robin Mills
f36cccefa2
#1291 include header simplification
8 years ago
Robin Mills
67859f4f4e
#1175 I'm going to accept the recommendation to change BasicIo::size() to return size_t. This passes the test suite. The only "ripple" outside of basicio is to iotest.cpp. This change enables several casts to be removed.
8 years ago
Robin Mills
7da3ad2e41
#1175 . Thanks to LaserSoft for reporting this and providing a patch.
8 years ago
Robin Mills
192a2a83cf
#1279 Cleaned up doxygen warnings for doc and website.
8 years ago
Robin Mills
6d5c2c3256
Getting ready to release v0.26
8 years ago
Robin Mills
2ebacb6b0b
#1272 Use in-memory temporary files.
8 years ago
Robin Mills
9f06ff2971
#1272 Submitting modified version of Ben's patch.
8 years ago
Robin Mills
b9f584fbbf
#1430 Correcting MSVC build breaker in r4639
9 years ago
Robin Mills
a057af1616
#1244 . Removing experimental APIs introduced by r4637. I submitted those APIs just to retain the code somewhere. I have no plan to release such as API.
9 years ago
Robin Mills
f5956d5db2
#1230 Fixes to read tiff with web-ready. Includes the BasicIo expiremental API readUnmarked() and markRead() which I will remove later.
9 years ago
Robin Mills
2f86b6bbc0
#1244 Fix submitted.
9 years ago
Robin Mills
957f71f6a6
#1230 Fix MinGW stdin-test breaker
9 years ago
Robin Mills
c10bc003a7
#1023 Fix getDataByRange CURLOPT_SSL_VERIFYHOST. Fix http-test.sh (and associated test/data/http-test.out).
9 years ago
Robin Mills
c78a76c45c
#1109 MinGW/32. Correction to r4538 for all versions of msvc.
9 years ago
Robin Mills
f44f706478
MinGW changes following discussion about building with Qt5.6/MinGW 4.9.2 http://dev.exiv2.org/boards/3/topics/2705
9 years ago
Robin Mills
d7463fd114
#1074 and #1057 Fixing build breakers on Cygwin and msvc MinGW to be further investigaged. add checkSum to test functions
9 years ago
Robin Mills
8afd3f43aa
#1198 . Fixed issue with http I/O failing a test file.
9 years ago
Robin Mills
04f871cc4c
#1152 Fix submitted. Also added new static function FileIo::temporaryPath() which I require for tgt - code and fixed typo in tiffvisitor.cpp
10 years ago
tbeu
e0a408ca6d
Replace LoadLibraryA/FreeLibrary by GetModuleHandleA for kernel32.dll (which is loaded by default)
10 years ago
Robin Mills
d88a3f5556
#1132 . Fix submitted.
10 years ago
Robin Mills
abd5ecedd4
#1129 . Fix submitted.
10 years ago
Andreas Huggel
910f389e50
#1116 : Reverted changes to BasicIo::BasicIo() introduced in r3933
10 years ago
Robin Mills
8ff86b6875
#1110 . Xcode project moved to contrib/xcode. Interesting errors in samples/Makefile. Replaced gsoc13 Exiv2::dict_t with (identical twin) Exiv2::Dictionary
10 years ago
Robin Mills
6767878fb8
#1116 . Fix submitted.
10 years ago
Andreas Huggel
b030a4de7c
#1077 : Removed msync() calls from MemIo.
10 years ago
Andreas Huggel
533668808d
Fixed cross-compiler warnings.
10 years ago
Andreas Huggel
108310bfb4
Prefix published precompiler define as usual.
10 years ago
Andreas Huggel
fd80993ab0
Updated copyright notice.
10 years ago
tbeu
a2edf47056
refs 1038: Fix eof detection in MemIo::getb and avoid crash on truncated jpeg files (Vitaliy Filippov)
10 years ago
tbeu
8f5e5a8c4a
refs #922 :
...
* Fix MSVC warning introduced by r3650
* Change first argument of BasicIo::seek to signed integer type
10 years ago
Robin Mills
e51425046e
#1043 #1042 #812 . Thank You to Thomas for this "polishing" patch. Thank you to everybody who has worked on this issue. Adding all the comments on the three issues together comes to about 60 items by at least 6 contributors. And it involves platform issues, networking, Linux and Windows APIs. One of the most complex issues to arise in Exiv2. Well done everybody. And we've dealt with this quickly. Only 9 days since Calvin first reported #1042 .
...
I use the term "complex" to mean many threads of technology. "complex" != "complicated". "complicated" = "difficult to understand". We try to avoid "complicated".
10 years ago
Robin Mills
6b20a636b7
#1043 and #1042 . Thanks to Thomas for showing that r3627 reintroduced #812 . Thanks to Thoralf for suggesting msync MemIo fix.
10 years ago
Robin Mills
7817180351
#1042 and #1043 . Don't use a MemIo object for small temporary files.
10 years ago
Robin Mills
41243f8653
#1038 . Thank You to Vitaliy for reporting this and providing the patch.
10 years ago
Robin Mills
ccfc4b62fd
trunk: webready integration. split preview-test.sh and added eps-preview-test.sh (and fix basicio.cpp and svn_version.sh issues).
11 years ago
Robin Mills
d393b0fa7e
trunk: exiv2 v0.25
11 years ago
Robin Mills
0312a8ee0b
Issue: 984. Thanks, Thomas. I should not have modified your code. You were correct. My apologies.
11 years ago
Robin Mills
3c7264c487
Issue: #984 . Thank You, Thomas for the patch.
11 years ago
Robin Mills
d09658a5eb
Issue: 984. Correction to r3345. I submitted Axel's patched file in error.
...
This version deals with older MSVC (such as 2005) which do not provide REPLACEFILE_IGNORE_MERGE_ERRORS.
11 years ago
Robin Mills
f93877f94b
Issue: #984 . Thank You, Axel for reporting this, the patch, and the test code.
11 years ago
Robin Mills
fdd6c337db
Issue# 983. Thank You, Nehal for the patch.
11 years ago
Robin Mills
4e530fbce0
Bumping the copyright notice again. (re-doing 3089 without breaking the build!)
12 years ago
Robin Mills
a297d2b69e
Rollback 3089 - somehow it's broken the build!
12 years ago
Robin Mills
da1ed8c536
Bumping the copyright notice in src &samples from 2012 to 2013
12 years ago
Robin Mills
0ae729dcf8
Mac build #906 fix compilation error (thanks to Tuan for this fix).
12 years ago
Robin Mills
cc8953be16
Issue: #906
12 years ago
Robin Mills
67fe779212
MSVC/video port. Simplification of basicio.{hpp|cpp}. CMake updates to eliminate warnings in Cygwin. By default, don't build intl with CMake.
13 years ago
Robin Mills
159b2d285b
MSVC/video port. Fixing code to build on Linux (and Cygwin).
13 years ago