941017d281
Fix issues on ARM builds ( #2205 )
...
* Specify base class initialization in Copy Constructor
* Fix printing of uint64_t variable in ARM 32bits
Use cinttypes
* Fix alignment issues on ARM 32 bits
* tests: add assertion with custom message
3 years ago
0d971e98e4
remove some unique_ptrs
...
They're not really used as pointers.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
ae4df71233
Remove DataBuf::copyBytes and use std::copy instead
3 years ago
1ad9e52f3c
Fix windows build
3 years ago
1545a1bc4a
JP2 - stronger checks on Signatuer and FileType boxes
3 years ago
e7478f744d
Jp2Image: Implement more checks from JP2 standard + fix bug
...
- add debug info when parsing Signature box
- Move definitions & static stuff to anonymous namespace
- cleanup while studying code
- Make exceptions more similar to other formats
3 years ago
b48e8e9379
Add unit tests for Jp2Image revealing bugs (see #2147 )
3 years ago
30bf563f4d
Update .clang-format file & apply clang-format to whole project
3 years ago
b2b6d834ba
some std::array conversions ( #2148 )
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
7576a2757b
More size_t for sizes
3 years ago
96f7f2e4c5
Convert Exiv2::ErrorCode into an enum class
3 years ago
f894ee0568
Fix debug builds
3 years ago
f156af46f3
Fix build on Windows
3 years ago
8b1fe379a1
Removing unused headers thanks to IWYU
3 years ago
6d1fa2ecea
clang-tidy: use empty() instead of size()
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
b17828b454
Use SPDX for licenses ( #2122 )
...
* Use SPDX identifier in header files
* Use SPDX identifier in rest of source files
* Fix usage of SPDX for files with 2 licenses
* Add global license file
* Fix compilation
3 years ago
b9f9d041ea
Several transformations on DataBuf + migration to size_t
...
- Provide begin/end iterators to DataBuf and simplify code
- Adapt test output after last changes
- Replacing long by size_t in value.hpp
- Use size_t in some Photoshop functions
- Remove some static_casts
3 years ago
5d627433fc
Remove useless DataBuf::clear()
3 years ago
8b3da36f42
Improvements from code review
3 years ago
ea201ce613
Remove dead code
3 years ago
a6185d29c6
Image::setComment now takes string_view
3 years ago
0f03e77634
Simplify code around UniquePtr(s) & use make_unique over new
3 years ago
81cfc162c1
Use std::move to transfer ownership of DataBufs.
4 years ago
9ff72e5ca5
Make offset=0 the default parameter.
4 years ago
c9d0cf3643
Make fields of DataBuf private.
4 years ago
ffde235336
Add comment to explain the bounds-check.
4 years ago
67e2ef5ccd
Check size before allocation to avoid out-of-memory errors.
4 years ago
ff00771425
Better bounds checking in Jp2Image::printStructure
...
(cherry picked from commit 0fcdde80997913dde284ea98f06f9305d06cb160)
4 years ago
d30c95d07e
fix incorrect loop condition ( #1752 )
4 years ago
743da1a564
clang-tidy: use C++ casting
...
Found with google-readability-casting
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
b8712188bb
clang-tidy: use auto
...
Found with modernize-use-auto
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
c73dfa0106
clang-tidy: use uppercase numeric literals
...
Found with readability-uppercase-literal-suffix
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
8337462032
clang-tidy: use empty() instead of comparing size
...
Found with readability-container-size-empty
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
170b18db74
Merge pull request #1621 from Exiv2/mergify/bp/main/pr-1591
...
Fix infinite loop caused by subBox with zero size. (backport #1591 )
4 years ago
566ea272a1
Prevent large allocation.
...
(cherry picked from commit f154f0ae540deeb9251467187d01c2a5846d27b5)
4 years ago
aac34630d4
Fix infinite loop caused by subBox with zero size.
...
(cherry picked from commit 2736126e7b92c5654f56620c097f9a4580c0f73b)
4 years ago
1dc1186760
clang-tidy: simplify boolean expressions
...
Found with readability-simplify-boolean-expr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
57cad2619b
Add bounds check in Jp2Image::doWriteMetadata().
...
(cherry picked from commit e6a0982f7cd9282052b6e3485a458d60629ffa0b)
4 years ago
b3de96f4b4
Add more bounds checks in Jp2Image::encodeJp2Header
4 years ago
23c1cda99d
Fix signed/unsigned compiler warnings.
4 years ago
f930883919
Better bounds checking in Jp2Image::encodeJp2Header()
4 years ago
de4d43d4d1
Fix warnings EXIV2_TEAM_EXTRA_WARNINGS
...
Most of the warnings fixed were:
- Hiding of local variables
- Hiding of globals
- Useless casts
- Conversions between float/double
4 years ago
d73dd0874d
Fix icc_test which is failing on Linux:
...
luis@ryzenLinux:/media/linuxDev/programming/exiv2/buildReleaseSanitizers$ cp large.icc Reagan2.icc
luis@ryzenLinux:/media/linuxDev/programming/exiv2/buildReleaseSanitizers$ bin/exiv2 -iC /tmp/Reagan2.jp2
/media/linuxDev/programming/exiv2/src/jp2image.cpp:661:28: runtime error: reference binding to misaligned address 0x61f000002a9e for type 'const struct Jp2BoxHeader', which requires 4 byte alignment
0x61f000002a9e: note: pointer points here
07 07 01 00 00 00 0c 53 63 6f 6c 72 02 00 00 00 00 0c 48 4c 69 6e 6f 02 10 00 00 6d 6e 74 72 52
4 years ago
0bbaa6eff3
cpp: Replace auto_ptr by unique_ptr
4 years ago
13e5a3e023
Fix out of buffer access in #1529
4 years ago
22ea582c6b
fix_1522_jp2image_exif_asan
4 years ago
d632988bbd
Massive code prolog cleanup.
4 years ago
22ed9b157b
Fixed typo declaration of pad when writing ICC profile.
5 years ago
181dd47385
Fix correctly this time and tested with the user files. Test suite updated to use Reagan2.jp2
5 years ago
b91de7acd0
fix_1236_0.27
5 years ago
Luis Díaz Más
Rosen Penev
Kevin Backhouse
Robin Mills
Pydera