Rosen Penev
|
86c71ae6c3
|
clang-tidy: avoid global non const variables
Found with cppcoreguidelines-avoid-non-const-global-variables
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
d1e116a8ef
|
remove some pointless std::set
Partially found by gcc's -fanalyzer
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
4c4f8da338
|
remove initializers
these were moved outside the constructor body.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
e5894d71e1
|
default con/destructors in headers
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
ce47de67b5
|
use auto in template
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
c44c289d76
|
clang-tidy: fix ending namespace comnments
Found with llvm-namespace-comment
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
a74bceacb0
|
clang-tidy: remove pointless return
Found with readability-redundant-control-flow
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
743da1a564
|
clang-tidy: use C++ casting
Found with google-readability-casting
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
8dbc699858
|
clang-tidy: add missing explicit
Found with google-explicit-constructor
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
ff39473c18
|
clang-tidy: convert to static
Found with readability-convert-member-functions-to-static
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
6da49fd29b
|
more constexpr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
cdbee3c26c
|
clang-tidy: init in member initializer
Found with cppcoreguidelines-prefer-member-initializer
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
036af68a71
|
remove pointless constructors
Replaced with Uniform initialization. Allows constexpr usage.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
8564d0b394
|
clang-tidy: pass by value
Found with modernize-pass-by-value
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
f9d394adf0
|
clang-tidy: run through performance checks
Found with performance*
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
b8712188bb
|
clang-tidy: use auto
Found with modernize-use-auto
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
20dfab8036
|
manual for range loop conversions
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
8e52032ee0
|
clang-tidy: range loop conversions
Found with: modernize-loop-convert
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
c73dfa0106
|
clang-tidy: use uppercase numeric literals
Found with readability-uppercase-literal-suffix
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
8e178e912e
|
replace {} initialization with fill
Old compilers don't implement {} correctly.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
fdf9d3799c
|
clang-tidy: don't use else after return
Found with llvm-else-after-return
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
4aa5566cf6
|
clang-tidy: make several member functions const
Found with readability-make-member-function-const
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
24a8139233
|
clang-tidy: fix badly indented if
Found with readability-misleading-indentation
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
1b9b77c51f
|
clang-tidy: add ending namespace comments
Found with google-readability-namespace-comments
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
bf290e84e5
|
fix compilation with EXIV2_DEBUG_MESSAGES
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Miloš Komarčević
|
3416b631c5
|
Add Sony ARW compression to dict
|
4 years ago |
Rosen Penev
|
fddb035106
|
clang-tidy: remove pointless const
Found with readability-avoid-const-params-in-decls
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
80595f8468
|
clang-tidy: remove duplicate public
Found with readability-redundant-access-specifiers
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Kevin Backhouse
|
ca66136092
|
Use readOrThrow to check error conditions of iIo.read().
(cherry picked from commit 0f9eb74c44c908e170a64cab590949d53749af8e)
|
4 years ago |
Rosen Penev
|
5dc4292b40
|
fix bad for range loop
This loop is supposed to break when it encounters a match.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
091fd77885
|
clang-tidy: remove redundant member init
Found with readability-redundant-member-init
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
674fdcd38b
|
clang-tidy: fix declartation names
Found with readability-inconsistent-declaration-parameter-name
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
2e73aa9dc0
|
default con/destructors in headers
Helps to optimize trivially destructable stuff.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
428c436629
|
clang-tidy: simplify boolean expression
Found with readability-simplify-boolean-expr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
5d716c7df4
|
clang-tidy: empty() conversions
Found with readability-container-size-empty
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
9642e3cceb
|
clang-tidy: remove pointless string init
Found with readability-redundant-string-init
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
143a1fbbe2
|
clang-tidy: don't use string compare
Found with readability-string-compare
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
8337462032
|
clang-tidy: use empty() instead of comparing size
Found with readability-container-size-empty
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
af7b2430c5
|
clang-tidy: use override
Found with modernize-use-override
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
15f0a600ed
|
clang-tidy: use default member init
Found with modernize-use-default-member-init
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Kevin Backhouse
|
170b18db74
|
Merge pull request #1621 from Exiv2/mergify/bp/main/pr-1591
Fix infinite loop caused by subBox with zero size. (backport #1591)
|
4 years ago |
Luis Díaz Más
|
b4b8061478
|
Early access is always compiled
|
4 years ago |
Kevin Backhouse
|
566ea272a1
|
Prevent large allocation.
(cherry picked from commit f154f0ae540deeb9251467187d01c2a5846d27b5)
|
4 years ago |
Kevin Backhouse
|
aac34630d4
|
Fix infinite loop caused by subBox with zero size.
(cherry picked from commit 2736126e7b92c5654f56620c097f9a4580c0f73b)
|
4 years ago |
Luis Díaz Más
|
9dbffa719b
|
Add missing public headers to install target
|
4 years ago |
Rosen Penev
|
5a9c29303e
|
clang-tidy: remove pointless static
Found with readability-static-definition-in-anonymous-namespace
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
bd6a996181
|
clang-tidy: use using
Found with modernize-use-using
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
b3040da54c
|
clang-tidy: don't check for NULL with delete
Found with readability-delete-null-pointer
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
1dc1186760
|
clang-tidy: simplify boolean expressions
Found with readability-simplify-boolean-expr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |
Rosen Penev
|
8128716287
|
clang-tidy: use = default
Found with modernize-use-equals-default
Ran through git clang-format
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
4 years ago |