MSVCRT requires wide string APIs, which were removed. Instead of dealing
with this, just error out on it. MSVCRT is deprecated anyway.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
time_t is 64-bit with UCRT.
__USE_MINGW_ANSI_STDIO is used only to get proper printf formats under
msvcrt. UCRT has them. Hence why it's deprecated.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Compiling this file with all dependencies as part of the main library
causes it to have the include directories of all dependencies, but iconv
is a bit of a special case: it can have a libc builtin or an external
library version. The external library might be installed to the same
directory as other dependencies, for example on FreeBSD -- but if exiv2
is not supposed to be built with GNU libiconv, then it will expect to
see the libc builtin.
The leaky include directories means that iconv.h gets pulled in from the
GNU libiconv version instead, though, which then forces -liconv to be
necessary for no reason.
There are two general solutions to ensuring that everything links
correctly:
- expect exiv2 to be built with *global* -I/usr/local/include -L/usr/local/lib
thus forcing the use of GNU libiconv
- carefully compiling the iconv support without any other dependencies
Let's do the latter since it allows for more choice and is easier to
enforce.
sys headers must come before libprocstat
meson is missing a libprocstat dependency. iconv is also broken with
meson and freebsd.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
FeRD (Frank Dana)
Miguel Borges de Freitas
Rosen Penev
Miloš Komarčević
Miloš Komarčević
Eli Schwartz