9a1f37ecbe
get rid of Key() move operations
...
Because of Impl, there's no way this can work properly.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
55d16ac76b
use GetCurrentProcessId on Windows
...
matches what is done elsewhere
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
35b6780d02
clang-tidy: don't assign in if
...
Found with bugprone-assignment-in-if-condition
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
d874fc4dd8
use __has_include
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
376638259d
namespace enforce.hpp functions to Internal
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
77834807c2
add support for gcc and clang 7
...
Uses std::experimental::filesystem
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
6976aab5bd
replace substr with resize/pop_back
...
Shorter and more efficient.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
bb311ba728
clang-tidy on Windows
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2 years ago
b6c2062fae
std::to_string conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
6cf06c6534
remove constructor
...
It can be implicitly generated.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
fc840405cc
revert std::function back to function pointers
...
The former has too much overhead. No point in it.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
5c90684441
simplify some defines
...
As far as I can tell, _WIN32 is defined for true Windows platforms.
Cygwin is a POSIX platform.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
e74feff4d8
strcmp to == conversions
...
Does the same thing.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
1d0530f04d
misc sonarlint changes
...
Mostly const changes.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
5b737ca541
sonarlint: add an empty do while loop
...
Avoids warnings regarding unnecessary semicolons.
Remove _fileno as it is unused.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
aae02babba
sonarlint: replace lock_guard with scoped_lock
...
C++17 allows scoped_lock, which sonarlint recommends.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
3ae1d3b48e
return make_unique directly
...
Simpler
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
dc4ae73013
Add tag description option to exiv2 app ( #2279 )
...
* Add `tagDesc()` to (Exif|Xmp|Iptc) Datums and Keys
* Add `--Print d` option to exiv2 app
* Add testing for all exiv2 application `--Print` options
* Update manpage
3 years ago
1ceddb2962
Replace long with int64_t in exiv2app.hpp
3 years ago
2e0ab1a037
More bounds checking in Adjust::adjustDateTime
3 years ago
c9bdd6ed94
Merge pull request #2209 from Exiv2/mainTODOs
...
Improvements around TODO comments
3 years ago
2e721a716e
std::function conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
c3d0100d48
Fixing bad usages of DataBuf (when it is empty)
3 years ago
043547cbd0
remove various usages of memset
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
ae4df71233
Remove DataBuf::copyBytes and use std::copy instead
3 years ago
b05573fadc
Remove most of the asserts from codebase
3 years ago
30bf563f4d
Update .clang-format file & apply clang-format to whole project
3 years ago
b2b6d834ba
some std::array conversions ( #2148 )
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
7576a2757b
More size_t for sizes
3 years ago
7119b7676f
remove templating & simplify error message
...
+ clang-format in Error files
+ Remove AnyError
3 years ago
c115d4daf7
Merge pull request #2131 from Exiv2/mainCleanups
...
Include what you use + more SPDX identifiers + few other cleanups
3 years ago
8dadcdf72a
manual nullptr removals
...
unique_ptr has a bool overload. It's also easier to reason about.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
cca6f74200
windows.h
3 years ago
b3a216310a
Removing unused headers thanks to IWYU
3 years ago
5508e6f466
hexdump to size_t
3 years ago
867132f7c7
_fileno is only for Windows
3 years ago
23da0c3955
Do not define not needed stuff
3 years ago
6d1fa2ecea
clang-tidy: use empty() instead of size()
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
04bacdedd6
clang-tidy: use auto
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
b17828b454
Use SPDX for licenses ( #2122 )
...
* Use SPDX identifier in header files
* Use SPDX identifier in rest of source files
* Fix usage of SPDX for files with 2 licenses
* Add global license file
* Fix compilation
3 years ago
208ec70df8
Fix windows builds
3 years ago
b9f9d041ea
Several transformations on DataBuf + migration to size_t
...
- Provide begin/end iterators to DataBuf and simplify code
- Adapt test output after last changes
- Replacing long by size_t in value.hpp
- Use size_t in some Photoshop functions
- Remove some static_casts
3 years ago
f1e04ee866
Replace DataBuf internal buffer with std::vector
3 years ago
7caf4090b1
Use fs::file_size instead of stat
3 years ago
ea201ce613
Remove dead code
3 years ago
56b5ab9a29
Use remove from filesystem
3 years ago
9b3a643d33
Use rename from filesystem
3 years ago
6f762b4e66
Use std::filesystem for fileExist
3 years ago
f5c89a4e62
Fix build on Windows
3 years ago
405f4b5f1b
Remove Util::dirname and finally the util files
3 years ago
Rosen Penev
Peter
Kevin Backhouse
Luis Díaz Más