4ceb325c8f
clang-tidy: range for loop conversions
...
Found with modernize-loop-convert
Ran through git clang-format.
Also removed several questionable loops and replaced with simpler
algorithms.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
e93ad82734
clang-tidy: use braced init list
...
Found with modernize-return-braced-init-list
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
294372f2ad
cmake: revert change due to old cmake versions on CentOS & debian9
4 years ago
582edd399c
cmake: ignore PDBs warnings on Win/Debug/Static buils
4 years ago
9de534976f
msvc: fix compiler warning on x86
4 years ago
90dde02359
Win - Disable UNICODE which is failing at the moment
4 years ago
84220855b2
clang-tidy: use = delete
...
Found with modernize-use-equals-delete
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
53f18cf408
conan: use cmake_paths generator instead of cmake
...
We also upgraded the xcode version on Travis-CI
4 years ago
f601d23d5e
conan: update conan recipe versions
4 years ago
b3de96f4b4
Add more bounds checks in Jp2Image::encodeJp2Header
4 years ago
e366c786b9
Fix -Werror=shadow warning after recovering EPS
4 years ago
9b9154d137
fix warning (hiding local variable)
4 years ago
d5240a4bda
eps: Fix code after usage of unique_ptr. Remove deprecation tags
4 years ago
8314030604
Revert "Remove deprecated EPS format"
...
This reverts commit 537cdad99e
4 years ago
8388223deb
Check that the string is properly terminated.
4 years ago
e8422732af
Fix LGTM warning about format specifier
...
https://lgtm.com/projects/g/Exiv2/exiv2/rev/pr-6633ad1cc6e6c36bffd6655165c299c53e934b22
4 years ago
e97a9ff88a
Fix signed/unsigned compiler warning.
4 years ago
27e349e063
Fix signed/unsigned compiler warning.
4 years ago
285e7a4e72
Fix out-of-bounds read in bmffimage.cpp
4 years ago
783b3a6ff1
Improve bound checking in WebPImage::doWriteMetadata()
4 years ago
23c1cda99d
Fix signed/unsigned compiler warnings.
4 years ago
f930883919
Better bounds checking in Jp2Image::encodeJp2Header()
4 years ago
f85f7f717a
Replace many of the iterators types with auto
4 years ago
75e4bd9059
Remove rest of useless typedefs from datasets.hpp
4 years ago
01a3bc716d
Fix warnings in VS
4 years ago
75bf666d3b
Remove typedef to Dictionary::const_iterator
4 years ago
0a1bf46a1c
revert changes that are affecting to VS
4 years ago
de4d43d4d1
Fix warnings EXIV2_TEAM_EXTRA_WARNINGS
...
Most of the warnings fixed were:
- Hiding of local variables
- Hiding of globals
- Useless casts
- Conversions between float/double
4 years ago
6c0059b5a0
cmake: Treat xmpsdk headers as system ones
...
This is done so that when we use EXIV2_TEAM_EXTRA_WARNINGS we do not get
warnings about XMPSDK (we do not want to deal with those)
4 years ago
83dda6ccd7
Fix warnings related to -Wdeprecated-copy
4 years ago
3682bce15e
Fix Ubuntu 20.04/Release/Sanitizer test breaker
4 years ago
d73dd0874d
Fix icc_test which is failing on Linux:
...
luis@ryzenLinux:/media/linuxDev/programming/exiv2/buildReleaseSanitizers$ cp large.icc Reagan2.icc
luis@ryzenLinux:/media/linuxDev/programming/exiv2/buildReleaseSanitizers$ bin/exiv2 -iC /tmp/Reagan2.jp2
/media/linuxDev/programming/exiv2/src/jp2image.cpp:661:28: runtime error: reference binding to misaligned address 0x61f000002a9e for type 'const struct Jp2BoxHeader', which requires 4 byte alignment
0x61f000002a9e: note: pointer points here
07 07 01 00 00 00 0c 53 63 6f 6c 72 02 00 00 00 00 0c 48 4c 69 6e 6f 02 10 00 00 6d 6e 74 72 52
4 years ago
b5d3a1fd70
auto_ptr -> unique_ptr for code with WIN_UNICODE enabled
4 years ago
2de3bad869
Remove EXIV2_ENABLE_VIDEO and related stuff
4 years ago
3eb1eee7fe
Remove deprecated RiffVideo support
4 years ago
061ec1a75d
Remove deprecated QuickTime support
4 years ago
8dcc07887a
Remove deprecated Matroska support
4 years ago
94b87a8dec
Remove deprecated SSH support
4 years ago
384a5edfcf
Remove deprecated ASF Video
4 years ago
3ddef8f8b8
Correct GDS distance unit in description
...
knot is a measure of speed...
4 years ago
94adf1b038
Improve precision of GPS lat/lon printed values
4 years ago
3f3bbc28ad
Improve printing of GPS info
4 years ago
206a2c495c
fix_enableBMFF_v1
4 years ago
f700043a6d
Add Exif Gamma tag
4 years ago
ede33f5eba
Initialization of variables (fix issue detected with sanitizers)
4 years ago
5fcea2b4e2
Use stack variables instead of java style
4 years ago
0bbaa6eff3
cpp: Replace auto_ptr by unique_ptr
4 years ago
537cdad99e
Remove deprecated EPS format
4 years ago
9e6a520089
Merge pull request #1539 from Exiv2/FixIssue1530
...
Fix integer overflow
4 years ago
9b7a19f957
Fix integer overflow.
4 years ago
0a91b56616
Fix incorrect delete.
4 years ago
13e5a3e023
Fix out of buffer access in #1529
4 years ago
22ea582c6b
fix_1522_jp2image_exif_asan
4 years ago
aef9cf76f7
fix_1503_JXL_bmff
4 years ago
49cfe45323
Merge pull request #1513 from Exiv2/fix_1508_enableBMFF
...
Fix 1508 enable bmff
4 years ago
9da2aed5d2
Use the documented 5 line prolog in every sample application. Tidy up sample prologs and header code.
4 years ago
190106ca78
fix_1507_avif_size0x0
4 years ago
d632988bbd
Massive code prolog cleanup.
4 years ago
99600c6aaf
exiv2 --verbose --version was reporting have_strerror_r twice!
4 years ago
6fad24cd11
Merge pull request #1491 from Exiv2/fix_1486_effort2
...
fix_1486_effort2
4 years ago
717fc098be
fix_1486_effort2 https://github.com/Exiv2/exiv2/pull/1486#discussion_r593161473
4 years ago
f95d97a0bf
Add mif1 brand to heif mime type
4 years ago
fcb3066950
Include a few more BMFF major brands
4 years ago
b3dfabdde0
Merge pull request #1486 from Exiv2/fix_1484_empty_ascii
...
Terminate empty ASCII strings
4 years ago
ba6a577ab9
https://github.com/Exiv2/exiv2/pull/1486#issuecomment-796843835
4 years ago
09567b477b
Merge pull request #1487 from kmilos/housekeep_bmff
...
Include HEIC type explicitly
4 years ago
fa41e52c8a
Add comment and test case
4 years ago
bf1be5cb50
fix_1473_LocationShown
4 years ago
e3c78623f7
Include HEIC type explicitly
4 years ago
26ba26e241
Terminate empty ASCII strings as well
4 years ago
9e2ac47cf9
Merge pull request #1475 from 1div0/BMFF
...
Base Media File Format
4 years ago
02477faf4e
Following review by @hassec, I use static base64_encoding vector in both Exiv2::base64encode() and Exiv2::base64decode().
...
I'm a little uneasy about changes to the API of the shared object/DLL. I will investigate #890 during the release process. So I have a plan to identify this if it's an issue. I think it's OK.
```
703 rmills@rmillsmm-local:~/gnu/github/exiv2/bmff/build $ nm --demangle lib/libexiv2.dylib | grep base64
00000000000384a0 T Exiv2::base64decode(char const*, char*, unsigned long)
0000000000038340 T Exiv2::base64encode(void const*, unsigned long, char*, unsigned long)
00000000001c33a0 s Exiv2::base64_encode
704 rmills@rmillsmm-local:~/gnu/github/exiv2/bmff/build $ nm -g --demangle lib/libexiv2.dylib | grep base64
00000000000384a0 T Exiv2::base64decode(char const*, char*, unsigned long)
0000000000038340 T Exiv2::base64encode(void const*, unsigned long, char*, unsigned long)
705 rmills@rmillsmm-local:~/gnu/github/exiv2/bmff/build $
```
4 years ago
212f1b5ebb
Following review by @piponazo, I am clarifying the bool return from Exiv2::enableBMFF().
4 years ago
e3fd0c633e
Thank You @piponazo for the code review. I've made the changes you requested.
4 years ago
5f563b5255
Fix spelling mistakes in LangAltValue::read()
...
Removed unneeded comments and empty space.
4 years ago
0da1a50afe
Revert style changes
4 years ago
4c52861a74
Fix msvc build breaker.
4 years ago
e09d093ccf
Minor whitespace formatting
4 years ago
282d1d6995
Add static to LangAltValue::read() const values
4 years ago
f1303cbcda
Another effort to fix base64decode and associated unit test.
4 years ago
87e536dadf
Fix #1358 . This should be in a different PR. Keep changes to base64 encode/decode together.
4 years ago
db9bec3e01
Restore -pC --binary to output everything. Test suite updated to suit.
4 years ago
21c610e952
Restoring i < dataLength trigraph that I should not have removed.
4 years ago
2f2dd7d56c
Fix ICC profile handling (my bad, iOS files are correct).
4 years ago
c59c53acf5
Trick to avoid msvc issue with final line of base64 data.
4 years ago
1eeeecea50
Replaced Exiv2::base64encode() because last effort failed unit test on msvc.
4 years ago
6cd9263fa7
Fix langAltValue::read() parsing
...
+ Fix segmentation faults in langAlt parse
+ Fix mismatched quotation marks and incorrect values
+ Add Python testing
+ Some tests commented out as quotation marks are filtered, preventing them
from running.
Closes #1481 .
4 years ago
80e20304cb
Fix Linux build breakers.
4 years ago
5410395576
Replaced the ugly code in Exiv2::base64encode() and update the test suite.
4 years ago
0ad46453ed
With good fortune, bmffimage is ready for review.
4 years ago
ee4d14340a
Fix box.length == to use bigEndian decode! Fix toAscii() to emit on ascii 32-127 bytes.
4 years ago
df68648dc3
refactored setModeAndPrintStructure() to respect class Task.binary_ when printing ICC profiles.
4 years ago
b983a9db75
Re-awaken obsolete command-line argument --binary and store class Task.
4 years ago
71d29fe60b
Fix MSVC build breaker and modify test_pr_1475_HIF.py to run on Windows.
4 years ago
55d2201892
Changed CI build default -DEXIV2_ENABLE_BMFF=On. Fixed suite to run with/without bmff. -pS and -pR same for bmff.
4 years ago
c84274ec19
Cosmetic change to -pR/-pS output.
4 years ago
fd9cb67fb7
WIP: adding BmffImage::printStructure() and support for colr box.
4 years ago
2b38d221dc
Adding DNG 1.6 triple-illuminant calibration tags
4 years ago
4ca05ed34a
Fix .CR3 files to call parseXmp().
4 years ago
ea1c91874f
Added parseXmp() to parse Xmp metadata.
4 years ago
44d976c2a1
Remove bmffimage::printStructure() as discussed in review with @hassec. Corpse removal and cleanup in bmpfimage.hpp
4 years ago
dcfe538a09
Revert "Add artist tag"
...
This reverts commit c46e800c0a
4 years ago
c46e800c0a
Add artist tag
4 years ago
5c77888037
Revised following code review by @hassec. Thank You, Christoph.
4 years ago
4d3af08ad8
Add CR3 image dimensions
4 years ago
4ae0a1d2a3
Tidy up. Rename Tag::cr3_exif -> Tag:cmt2
4 years ago
9515e4658b
Cleanup. 1. Recursively process uuid/cano box. 2. Fix LGTM/CI sprintf grumbles. 3. Comment parseTiff() in bmffimage.hpp.
4 years ago
913ee33372
Parse Exif in .HEIC/.AVIF
4 years ago
108670b309
Corrected format string
4 years ago
28b41f59bd
run clang-format on new files
4 years ago
29f3d5cac9
introduce parseTiff method to parse exif
4 years ago
f190f496d1
Tidying up. 1. pixelHeight_. 2. refactored indenter() -> indent(). 3. EXIV2_DEBUG_MESSAGES outputs to std::cerr
4 years ago
4a96025294
Fixed recursion issue in the meta box.
4 years ago
bafea0f1b8
[WIP] Fixed Image Spatial Extents Property Handling
4 years ago
8d7133d7bc
WIP: Added class Iloc and related code.
4 years ago
8976a23f2d
More fixes for LGTM/CI warnings.
4 years ago
64866cc568
Fixing warnings from LGTM/CI.
4 years ago
0b4b7c695e
Fix msvc/CI build breakers.
4 years ago
630fb23046
Fixing a build breaker.
4 years ago
6d13e44e5a
WIP: Refactored readMetadata() into recursive boxHandler()
4 years ago
0360a7ded5
[WIP] Yet another type cast correction to make Travis CI happy
4 years ago
a75ac74417
[WIP] Correction to make Travis CI happy
4 years ago
04481dd753
[WIP] 64-bit length
4 years ago
d455f473e8
C++ simplification.
4 years ago
7beb4e3e0d
fix_1471_sony2010_0.27
4 years ago
4fa0a88097
[WIP] Correction
...
https://ci.appveyor.com/project/piponazo/exiv2-wutfp/builds/37795261/job/23l6a0u0wt6ax79l
4 years ago
81e0f99254
[WIP] Another try
4 years ago
7b5854e26e
[WIP] Redefine tags
4 years ago
f0a321dedb
[WIP] Base Media File Format
4 years ago
c40eccd062
fix_1464_sony2010e Fix c++ code
4 years ago
c608148820
[WIP] Added box types
4 years ago
a6a47346a8
Use a.rfind(b, 0) == 0 instead of a.find(b) == 0 to reduce processing time when checking that a starts wit b, #1459
4 years ago
e19fca6640
Small corrections
4 years ago
f5c6e7595f
Fix Linux build-breaker when ENABLE_ISOBMFF=False and EXIV2_TEAM_WARNINGS_AS_ERRORS=On
4 years ago
fa39234275
Fixing Linux build/test issues.
4 years ago
0844e1bbfb
Rename class ISOBMFF => class bmffImage to match other image handlers. Removed C++11 style code. Removed unused code.
4 years ago
460a802671
Fix image handler to give jp2image code higher priority than the next isobmff code.
4 years ago
92469f4c27
[WIP] Add ISO/IEC Base Media File Format
4 years ago
ddd326fc18
Update canonmn_int.cpp
...
Added Sigma 35mm/1.4 to lens id 368 and changed resolver to look at both focal length and aperture. Fixed canonEv so lenses with f/6.3 report as f/6.3 (they actually report f/6.2 to camera)
4 years ago
056359d89b
fix formatting
4 years ago
93869e1311
use EXV_PRINT_TAG macro instead of specific print function
4 years ago
51bd57e387
add shutter mode and mechanical shutter count to nikon makernote 3
4 years ago
cf9be2cc3b
fixing exceptions and reordering tags
4 years ago
ff2ffb1909
add_cr3_tags
4 years ago
19decc1193
Merge pull request #1436 from Exiv2/dng_1.6
...
Add DNG 1.6 support
5 years ago
4c2ac99673
try and fix ci-build 3/N
5 years ago
f740fcd823
try and fix ci-build 2/N
5 years ago
814357a6d1
try and fix ci-build
5 years ago
2909e9cacc
Implement handling of new Nikon LensData version 8.0 and 8.01
5 years ago
240179514c
Add DNG 1.6 support
5 years ago
9b5108583b
Revert "Revert "fix_1431_binary_comment.""
...
This reverts commit 2866415322
5 years ago
c6167258ce
Revert "Restored 0.27.2 "toString()" behaviour of Exifdatum.value().toString() for CommentValue."
...
This reverts commit ecae9dc6eb
5 years ago
2866415322
Revert "fix_1431_binary_comment."
...
This reverts commit b6bf20a897
5 years ago
af8699a8ac
Revert "Fixing test suite."
...
This reverts commit 23f39b60f7
5 years ago
23f39b60f7
Fixing test suite.
5 years ago
ecae9dc6eb
Restored 0.27.2 "toString()" behaviour of Exifdatum.value().toString() for CommentValue.
5 years ago
b6bf20a897
fix_1431_binary_comment.
5 years ago
01a146e014
Merge pull request #1427 from Exiv2/prettyprint_planarconfig
...
Pretty print PlanarConfig
5 years ago
5e7a563407
Pretty print PlanarConfig
5 years ago
85e3a31242
Promote remaining SHORT/LONG tags default type
5 years ago
866d213983
Merge pull request #1409 from Exiv2/fix_1402_rafimage_0.27
...
fix_1402_rafimage_0.27
5 years ago
2466c78fe6
Calming Test Suite concerning Continuous and CropMode confusion.
5 years ago
a71eb24956
Pointless change to trigger CI to build again.
5 years ago
e032586d74
Code/comment tidy.
5 years ago
9b877f8506
Success. It's working!
5 years ago
0b5ba68e54
Merge pull request #1412 from Exiv2/dng15_0.27
...
Add DNG 1.5 tags and values
5 years ago
c48189afa7
Add FujiIFD to TiffCreator::tiffGroupStruct_
5 years ago
a8b549f7df
Remove debugging code.
5 years ago
4ab2eb3ec6
Add DNG 1.5 tags and values
5 years ago
13032f44f1
Fix Pana tag typo and improve Fuji tag description
5 years ago
45119e3260
WIP: working to understand how to support tiffIfd in tiffvisitor_int.cpp
5 years ago
b410eb3550
Complete DNG 1.4 spec support
5 years ago
a2f4082beb
Revert exv commit and remove empty line.
5 years ago
abce0ac300
Fix typo and remove empty line.
5 years ago
01a449544c
Adding support for DefaultUserCrop and BaselineExposureOffset
...
Nothing special, copied from dng 1.5 reference.
5 years ago
76514a1654
WIP #1402 rafimage::printStructure() improved formatting.
5 years ago
49fa54d7f2
Merge pull request #1407 from FreddieWitherden/0.27-maintenance
...
Add support for Fuji's CropMode tag.
5 years ago
8f1f6fce1f
Add support for Fuji's CropMode tag.
5 years ago
e045fd666a
Merge pull request #1389 from Exiv2/fix_929_exif2.31_0.27
...
fix_929_exif2.32_0.27
5 years ago
5f9daf725b
Moved orphaned declaration of exifGPSDirRef.
5 years ago
c688ed448d
Moved ambient tags to Exif only list, other refactoring
...
Handle more TIFF/EP vs Exif differences
Moved translated values (GPS, Exif) closer to their respective lists
5 years ago
829ed7da15
Clarified definition and use of enum SectionId @kmilos: please review/approve.
5 years ago
4017f79c83
Merge pull request #1400 from Exiv2/fix_1393_iptc_tags_web_0.27
...
fix_1393_iptc_tags_web_0.27
5 years ago
4c52891549
Fix tag GPSHPositioningError to use printValue() pretty-printer.
5 years ago
a59a382961
I hope I've made a better job of this at this attempt. I don't thing the "section" enum is of much importance. I don't believe anything in particular is done with with it.
...
```cpp
/*!
@brief Section identifiers to logically group tags. A section consists
of nothing more than a name, based on the Exif standard.
*/
enum SectionId { sectionIdNotSet,
imgStruct, recOffset, imgCharacter, otherTags, exifFormat,
exifVersion, imgConfig, userInfo, relatedFile, dateTime,
captureCond, gpsTags, iopTags, mpfTags, makerTags, dngTags, panaRaw,
tiffEp, tiffPm6, adobeOpi,
lastSectionId };
```
I pleased with the documentation and drawing I have added to the book concerning the Exif Specification.
https://clanmills.com/exiv2/book/#Exif
5 years ago
e887b6487f
fix_1393_iptc_tags_web_0.27
5 years ago
ff0dc4b1df
Add support for Sony lens aberration correction parameters.
5 years ago
12f7002493
Minor DNG related changes after review
5 years ago
e92d5f2e61
Add remaining DNG 1.3 tag values
5 years ago
682927ee25
Also use existing light source pretty print for DNG
5 years ago
2113dfeb8a
Add DNG CFALayout values
5 years ago
04a9743a1c
Fix syntax error, improve value name style
5 years ago
a2a7ee2733
Add some DNG related tag values
5 years ago
58ae0b0752
fix_929_exif2.31_0.27
5 years ago
3e78cac3f4
Merge pull request #1384 from Exiv2/fix_1380_binary
...
Disable exiv2 option --binary (0.27->maintenance)
5 years ago
1038e62a42
actions: simplify print summary using easyaccess
5 years ago
f6abec4432
exiv2 pr uses easyaccess API (co-authored with clanmills)
5 years ago
5e92d5e078
Fix easyaccess-test
5 years ago
98f4effeea
Add DateTimeOriginal to easyaccess
5 years ago
189e0c9338
Add more easy accessors for Exif & TIFF/EP overlap
5 years ago
Rosen Penev
Luis Díaz Más
Kevin Backhouse
Robin Mills
Miloš Komarčević
Miloš Komarčević
Pydera
postscript-dev
Peter Kovář
Christoph Hasse
Ingo Weyrich
czgnp
Alex Esseling
hanno@schwalm-bremen.de
Freddie Witherden