Kevin Backhouse
c2b52119d4
Check that findKey didn't return end().
4 years ago
mergify[bot]
1d64f482ff
fix: use vector::at() rather than operator[] (backport #1735 ) ( #1741 )
...
* fix: use vector::at() rather than operator[] (#1735 )
* Regression test for https://github.com/Exiv2/exiv2/issues/1706
* Use vector::at() rather than operator[].
* Print to stderr when exception is caught and EXIV2_DEBUG_MESSAGES is enabled.
* Check that it prints "Bad value" for the date.
(cherry picked from commit f4d3adbf91e6dc4e34aee5bac7b7fd9e127a5c00)
# Conflicts:
# src/value.cpp
* fix merge conflicts from mergify backport
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>
Co-authored-by: Christoph Hasse <hassec@users.noreply.github.com>
4 years ago
Rosen Penev
2c57f214c5
clang-tidy: use nullptr
...
Found with modernize-use-nullptr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
ce47de67b5
use auto in template
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
743da1a564
clang-tidy: use C++ casting
...
Found with google-readability-casting
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
8dbc699858
clang-tidy: add missing explicit
...
Found with google-explicit-constructor
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
b8712188bb
clang-tidy: use auto
...
Found with modernize-use-auto
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
1b9b77c51f
clang-tidy: add ending namespace comments
...
Found with google-readability-namespace-comments
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
bf290e84e5
fix compilation with EXIV2_DEBUG_MESSAGES
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
2e73aa9dc0
default con/destructors in headers
...
Helps to optimize trivially destructable stuff.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
af7b2430c5
clang-tidy: use override
...
Found with modernize-use-override
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
bd6a996181
clang-tidy: use using
...
Found with modernize-use-using
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
8128716287
clang-tidy: use = default
...
Found with modernize-use-equals-default
Ran through git clang-format
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Rosen Penev
4ceb325c8f
clang-tidy: range for loop conversions
...
Found with modernize-loop-convert
Ran through git clang-format.
Also removed several questionable loops and replaced with simpler
algorithms.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
Luis Díaz Más
f85f7f717a
Replace many of the iterators types with auto
4 years ago
Luis Díaz Más
0bbaa6eff3
cpp: Replace auto_ptr by unique_ptr
4 years ago
Robin Mills
d632988bbd
Massive code prolog cleanup.
4 years ago
clanmills
43b06b6814
Don't allow binary into the output stream!
5 years ago
Robin Mills
05538ebea2
fix1001_rename_AFPrimaryPoint
6 years ago
clanmills
90f9f0bc19
Add support for Exif.Canon.AF tags to be read from images
...
This PR (and fix981_canonAutoFocus2) use a decoder listed in TiffMappingInfo to
decode Exif.Canon.AFInfo. The decoding function "manufactures" Exif tags such as
Exif.Canon.AFNumPoints from the data in Exif.Canon.AFInfo. These tags must never
be written to file and are removed from the metadata in
exif.cpp/ExifParser::encode().
Three of the tags created (AFPointsInFocus,AFPointsSelected, AFPrimaryPoint) are
bitmasks. As the camera can have up to 64 focus points, the tags are a 64 bit
mask to say which points are active. The function printBitmask() reports data
such as 1,2,3 or (none).
This decoding function decodeCanonAFInfo() added to TiffMappingInfo manufactures
the new tags. Normally, tags are processed by the binary tag decoder and that
approach was taken in branch fix981_canonAf. However, the binary tag decoder
cannot deal with AFInfo because the size of some metadata arrays cannot be
determined at compile time.
6 years ago
Luis Díaz Más
113136e134
Replace DEBUG with EXIV2_DEBUG_MESSAGES
...
Fixes #926
6 years ago
Robin Mills
9c516116c8
Fix #401 by fixing iteration over exif data tags
7 years ago
Luis Díaz Más
603692a1d8
Copyright to Exiv2 authors
7 years ago
Dan Čermák
316548d2de
Fix shadowing issues
...
- renamed variables that were shadowing a previously defined variables
7 years ago
Dan Čermák
efe2ccdcb6
Replaced all hardcoded error codes with ker... constants
7 years ago
tbeu
5b5987a596
Remove obsolete EXIV2_RCSID
8 years ago
tbeu
5df8b01b77
Remove obsolete svn revision
8 years ago
Robin Mills
82dbe6199d
https://github.com/Exiv2/exiv2/issues/11 Closed. Coincidentally Raphael reported issues with Visual Studio 2015 Community Edition. Issue 11 and Raphael's issues should now be resolved.
8 years ago
Robin Mills
6d5c2c3256
Getting ready to release v0.26
8 years ago
Robin Mills
5f9807cbef
#1216 . Rollback r4448/6/2/1 r4439/38 to restabilize test suite on trunk. r4449 is copy of r4448 to branches/develop
9 years ago
sridharb
d78dec24e3
Moved ExifDatum::ignore from exif.hpp to the exif.cpp.
...
This frees up exif.hpp from needing to include tags_int.hpp.
The downside is that this function is no longer inline.
9 years ago
Andreas Huggel
fd80993ab0
Updated copyright notice.
10 years ago
Robin Mills
d393b0fa7e
trunk: exiv2 v0.25
11 years ago
Robin Mills
4e530fbce0
Bumping the copyright notice again. (re-doing 3089 without breaking the build!)
12 years ago
Robin Mills
a297d2b69e
Rollback 3089 - somehow it's broken the build!
12 years ago
Robin Mills
da1ed8c536
Bumping the copyright notice in src &samples from 2012 to 2013
12 years ago
Robin Mills
bdbdbf2360
fixed typos to build with ./configure "CXXFLAGS=-DDEBUG -ggdb"
13 years ago
Andreas Huggel
58044f9feb
#819 : Added the PentaxDng Preview image to the tags potentially stripped when encoding the Exif metadata for JPEG (related to #820 ).
13 years ago
Andreas Huggel
7fc3739b2c
#820 : Added SamsungPreview to the list of previews to potentially remove when encoding Exif metadata for JPEG.
13 years ago
Andreas Huggel
0d397b95c7
Updated copyright message for 2012.
13 years ago
Andreas Huggel
0e0845d7be
#635 : Added experimental write-support for CR2.
13 years ago
Andreas Huggel
7770151915
Updated Copyright message for 2011.
15 years ago
Andreas Huggel
ae501bba1c
#759 : Undid r2444. Instead, don't encode any tags larger than 40kB as a last resort when writing to JPEGs.
15 years ago
Andreas Huggel
ac0fc376a9
#759 : Do not write Exif.Image.DNGPrivateData to JPEGs.
15 years ago
Andreas Huggel
f25fca8808
#726 : Added support for thumbnail found in sub-IFD of IFD1 of Samsung .SRW files.
15 years ago
Andreas Huggel
a0bdc5528e
#721 : Removed Exif-specific reference functions from the ExifKey interface again.
15 years ago
Andreas Huggel
dc264bc00d
#476 , #614 : Introduced class LogMsg for enhanced logging, migrated all existing warnings and error messages (not the exceptions) to use the new logic. Every log message now has a type (debug, info, warning, error). Applications can set a logging level to determine which messages are processed and supply a custom log message handler at runtime. (Based on a contribution by Simson Garfinkel.)
15 years ago
Andreas Huggel
717d789c8e
#721 : Renamed ifdItem to groupName and big internal clean-up: consolidated groups and IfdIds.
15 years ago
Andreas Huggel
708bba8159
#721 : Removed IfdId from the published API. ExifKey now gives access to reference tag data. (Needs some polishing.)
15 years ago
Andreas Huggel
45c2eb2d34
#721 : Use Pimpl idiom for class ExifKey in preparation for more changes.
15 years ago