ea201ce613
Remove dead code
3 years ago
a6185d29c6
Image::setComment now takes string_view
3 years ago
0726104b1a
Hide pathOfFileUrl in the only place where it is used
3 years ago
408d80bce8
Change order of ImageType values
3 years ago
f10283f118
bug: Fix crash when calling ImageFactory::create(none)
3 years ago
5a9799ffb2
Replace ImageType namespace by a enum class
3 years ago
7933ff401d
Remove dead code around EXV_UNICODE_PATH
3 years ago
0f03e77634
Simplify code around UniquePtr(s) & use make_unique over new
3 years ago
a94d648d05
Rest of tests to have 100% coverage in BMP class
3 years ago
6758e7288d
Merge branch 'main' into fix_exiv2_-pR
4 years ago
bd676bedc6
Fix `exiv2 -pR` for Sony images ( #1805 )
...
`exiv2 -pR` failed to process Sony makernotes. Fix checks if
makernotes header has Sony string, then uses correct offset.
Fix supplied by @clanmills
4 years ago
68473d9d10
Remove static functions readOrThrow and seekOrThrow.
4 years ago
44542a9f94
Add readOrThrow and seekOrThrow to BasicIo.
4 years ago
81cfc162c1
Use std::move to transfer ownership of DataBufs.
4 years ago
9ff72e5ca5
Make offset=0 the default parameter.
4 years ago
c9d0cf3643
Make fields of DataBuf private.
4 years ago
593fcbd865
Add fuzzing dictionary and test all printStructure() options
4 years ago
c3239e3187
&bytes[0] will crash if bytes has zero elements.
...
(cherry picked from commit 3e72d129e53b14e0b62d74aefed6bbd326562d63)
4 years ago
e4e3362284
Defensive programming in Image::printIFDStructure
4 years ago
caf08b229e
dirLength == 0 can cause an infinite loop.
4 years ago
2b84f4bd64
fix: zero initialize local variables. ( #1743 )
...
* Zero initialize local variables.
* Initialize xmpID_
4 years ago
f30022d73d
Fix issues detected with PVS-Studio + other little improvements ( #1689 )
...
* avoid re-declaration of constant variables
* Replace pthreads critical section with std::mutex
* ci - better naming
* cmake - increase minimum version to 3.11. Use project DESCRIPTION
* fix - do not treat string::find() return type as bool
* remove conditions that were always true
* remove condition that were always false
* Remove EXV_HAVE_GMTIME_R which is not used anymore
* pixelWidth_ was inherited from Exiv2::Image
The width & height variables in the TiffImage class need to be mutable
to be able to change their values on the getters pixelHeight() and
pixelWidth() ... Do not ask me why ...
* Remove superfluous if
* pvs:V766 item with identical key added already
* pvs:V730 not all members were initialized (time)
* pvs:V730 not all members are initialized
* pvs:v668 no point in testing pointer against null after new
* pvs:V1048 variable assigned the same value
* replace c-style dynamic vector with std one
* pvs:547 fakeData is always true
* Remove useless constructor in derived class
* pvs:V690 modern way to disable copy-ctor
* Replace malloc/free with new/delete. No need to check for null
* pvs:V1028 cast operands and not result
* Remove custom MIN/MAX functions
* pvs:V595 pointer used before verified against null
* pvs: index used before being checked
* pvs:V1028 possible overflow. Cast operands
* pvs:v575 potential null pointer passed to other functions
* pvs:V547 deal with always true/false expressions
* pvs:V560 part of conditional expressions always false or true
* pvs:V701 possible break in realloc -> move to std::vector
* Make some classes 'final'
* Replace sprintf with std::to_string()
* fix compilation on windows
4 years ago
758dd6bbc6
refactor!: remove free() function from DataBuf to avoid potential problems, see #1542
4 years ago
2c57f214c5
clang-tidy: use nullptr
...
Found with modernize-use-nullptr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
743da1a564
clang-tidy: use C++ casting
...
Found with google-readability-casting
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
ff39473c18
clang-tidy: convert to static
...
Found with readability-convert-member-functions-to-static
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
b8712188bb
clang-tidy: use auto
...
Found with modernize-use-auto
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
1b9b77c51f
clang-tidy: add ending namespace comments
...
Found with google-readability-namespace-comments
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
091fd77885
clang-tidy: remove redundant member init
...
Found with readability-redundant-member-init
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
2e73aa9dc0
default con/destructors in headers
...
Helps to optimize trivially destructable stuff.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
9642e3cceb
clang-tidy: remove pointless string init
...
Found with readability-redundant-string-init
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
1dc1186760
clang-tidy: simplify boolean expressions
...
Found with readability-simplify-boolean-expr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
8128716287
clang-tidy: use = default
...
Found with modernize-use-equals-default
Ran through git clang-format
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
8314030604
Revert "Remove deprecated EPS format"
...
This reverts commit 537cdad99e
4 years ago
de4d43d4d1
Fix warnings EXIV2_TEAM_EXTRA_WARNINGS
...
Most of the warnings fixed were:
- Hiding of local variables
- Hiding of globals
- Useless casts
- Conversions between float/double
4 years ago
b5d3a1fd70
auto_ptr -> unique_ptr for code with WIN_UNICODE enabled
4 years ago
3eb1eee7fe
Remove deprecated RiffVideo support
4 years ago
061ec1a75d
Remove deprecated QuickTime support
4 years ago
8dcc07887a
Remove deprecated Matroska support
4 years ago
94b87a8dec
Remove deprecated SSH support
4 years ago
0bbaa6eff3
cpp: Replace auto_ptr by unique_ptr
4 years ago
537cdad99e
Remove deprecated EPS format
4 years ago
d632988bbd
Massive code prolog cleanup.
4 years ago
0da1a50afe
Revert style changes
4 years ago
e09d093ccf
Minor whitespace formatting
4 years ago
f0a321dedb
[WIP] Base Media File Format
4 years ago
0844e1bbfb
Rename class ISOBMFF => class bmffImage to match other image handlers. Removed C++11 style code. Removed unused code.
4 years ago
460a802671
Fix image handler to give jp2image code higher priority than the next isobmff code.
4 years ago
92469f4c27
[WIP] Add ISO/IEC Base Media File Format
4 years ago
48afa7548d
fix_1329_remove_bigtiff_0.27
5 years ago
f61fa2ed9d
Fix write ability flags of PSD files ( #1260 )
5 years ago
d07a1f94f8
fix_547_0.27
5 years ago
cc1a6033db
fix_1045_0.27
5 years ago
18ed65a25f
fix_Sony2010e_0.27 Thanks to @sridharb1
5 years ago
43683f1eff
Fix #531
7 years ago
ae49250942
Check in Image::printIFDStructure if seek and reads are OK
7 years ago
962962a8e9
Port Iptc::printStructure & getUshort to slices API
...
This fixes #211 , #210 , #209
7 years ago
fec6535ae8
[binaryToString] Reimplement using Slices
...
- reimplement binaryToString:
- it now accepts a Slice and nothing else
- it does not return a std::string but instead a proxy object that implements
operator<< (this should be more efficient, as we do not need to touch the
heap in most cases)
- addapt unit tests
- replace all occurences with the new API
7 years ago
7a7ae7a1df
[image_int] Move internal functions into separate translation unit
7 years ago
54ad1bc91a
Fix cppcheck issues: duplicateBreak
7 years ago
603692a1d8
Copyright to Exiv2 authors
7 years ago
7d9ed33bde
Initialize DataBuf with 0s => fix valgrind error
7 years ago
607b19111c
[DataBuf] Replace wrong usage of release() with free()
7 years ago
efe2ccdcb6
Replaced all hardcoded error codes with ker... constants
7 years ago
5b5987a596
Remove obsolete EXIV2_RCSID
8 years ago
5df8b01b77
Remove obsolete svn revision
8 years ago
87a83c89d5
Merge branch 'master' into stringFormat_update
8 years ago
36df4bc997
Fixed potential out of bounds file access
...
This commit adds a out-of-bounds protection in the case that the
extracted values for offset & count are summed up larger than the size
of the file. Also this function checks for overflows before performing
the addition.
This fixes #159
8 years ago
cfa5073a2c
Added short explanation to internal function stringFormat
8 years ago
06cafadf4f
Added assertion that call to vsnprintf succeeds
8 years ago
c0ea5f4fba
Rewrite the reallocation the C++ way
...
* Fix handling of the return value of vsnprintf
* In C++11 we could use buffer.data instead of &buffer[0]
8 years ago
7e90668011
Adding comment for issue #56
8 years ago
2f0104879a
Merge pull request #81 from piponazo/robinChanges
...
Robin changes
8 years ago
8ad49f6d73
Robin changes in sync with master changes
8 years ago
74cb5bab13
Fixed wrong brackets: size*count + pad can overflow before the cast
...
=> Should fix #76 (most of the work has been done by Robin Mills in
6e3855aed7#76 is the contents of the 26th IFD, with the
following contents:
tag: 0x8649
type: 0x1
count: 0xffff ffff
offset: 0x4974
The issue is the size of count (uint32_t), as adding anything to it
causes an overflow. Especially the expression:
(size*count + pad+20)
results in an overflow and gives 20 as a result instead of
0x100000014, thus the condition in the if in the next line is false
and the program continues to run (until it crashes at io.read).
To properly account for the overflow, the brackets have to be removed,
as then the result is saved in the correctly sized type and not cast
after being calculated in the smaller type.
The brackets have also been removed from bigtiffimage.cpp, where the
same issue is present.
8 years ago
d8ae4484ae
msvc support for bigtiffimage.cpp
8 years ago
6e3855aed7
Fix https://github.com/Exiv2/exiv2/issues/55
8 years ago
9acc1c56a7
adding ifd8 and long longs to is8ByteType()
8 years ago
b6e79357de
Adding 8-byte swap functions + consts
8 years ago
5ab1a0809d
adopt to style
8 years ago
c008ad2403
making tag related functions private
8 years ago
bc6eed0b03
registering new file type
8 years ago
21ac4ac61a
Test suite changes due to https://github.com/Exiv2/exiv2/pull/68
8 years ago
dff941ad7f
Do not print offset when it is used as tag's value
8 years ago
d366943297
Refactoring EXV_USE_CURL and EXV_USE_SSH
8 years ago
20582a93c6
Marking members in a proper way.
8 years ago
4e25435afb
Changing return type of Image::tagName to std::string
8 years ago
ddb87fe0cf
Moving static tagName() into Image class to prevent multithread crashes.
...
static variables inside of tagName() were not protected against multithread access.
It could cause a crash in case of simultaneous initialization of map of tags.
8 years ago
d3c2b99385
#1297 Fix submitted.
8 years ago
77616c3204
#1289 Thanks to Asdiel (AlienSkin) for reporting this and providing a test file. Thanks to Ben for investigation and patch.
8 years ago
6d5c2c3256
Getting ready to release v0.26
8 years ago
012c544704
#1268 Fix submitted. Ben and Robin both discovered and fixed this independantly with the same fix!
8 years ago
dd4faaf831
#1277 Fix submitted. Thank You to Ben for reporting this and providing a patch.
8 years ago
fe6c71d0fa
#1108 exiv2 -pR to dump type == tiffIfd
9 years ago
49fbd1d761
#1108 Add support to dump MakerNote IFDs with exiv2 -pR
9 years ago
81265684f0
#1108 Fixed bugs in printStructure(kpsRecursive) handling of RATIONAL data.
9 years ago
dd39d165e2
#1247 Fix Linux/GCC compilation warning. Added Hanno's file to the test suite.
9 years ago
021bf5c237
#1247 Thank You Hanno for reporting this and providing a patch.
9 years ago
a057af1616
#1244 . Removing experimental APIs introduced by r4637. I submitted those APIs just to retain the code somewhere. I have no plan to release such as API.
9 years ago
f5956d5db2
#1230 Fixes to read tiff with web-ready. Includes the BasicIo expiremental API readUnmarked() and markRead() which I will remove later.
9 years ago
Luis Díaz Más
Kevin Backhouse
postscript-dev
Christoph Hasse
Rosen Penev
Robin Mills
Miloš Komarčević
Peter Kovář
tbeu
Dan Čermák
tbeu
Michał Walenciak