d59e1433c0
replace readlink with std::filesystem
...
Simpler.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
6438305234
Merge pull request #2212 from neheb/1
...
1
3 years ago
bd1758c3c5
remove some double pointer stuff
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
65c5b772c9
fix misplaced const
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
c9c2a1847b
remove const std::function
...
std::move is used.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a86bc386da
reference conversions
...
There's no nullptr here.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
48f848f5bb
clang-tidy: remove const params in decls
...
Found with readability-avoid-const-params-in-decls
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
2e721a716e
std::function conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
d466c1e9eb
minor clang-tidy fixes ( #2213 )
...
* clang-tidy: add const to member function
Signed-off-by: Rosen Penev <rosenp@gmail.com>
* clang-tidy: remove duplicate access specifier
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
471b816491
Merge pull request #2211 from neheb/1
...
clang-tidy: default member init
3 years ago
3a8a8b29a2
std::pair conversion
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a8061e7ee9
clang-tidy: default member init
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
151b54ab3e
remove default constructor
...
This is rule of zero.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
f3f6ffb855
ci: move pvsStudio job to its own workflow & use new flag
...
The license will expire in approximately 1 month. I disabled the
expiration check.
3 years ago
941017d281
Fix issues on ARM builds ( #2205 )
...
* Specify base class initialization in Copy Constructor
* Fix printing of uint64_t variable in ARM 32bits
Use cinttypes
* Fix alignment issues on ARM 32 bits
* tests: add assertion with custom message
3 years ago
6203ded16f
add constexpr constructor
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
6c99577f1d
Merge pull request #2203 from Alan01/patch-1
...
Create da.po
3 years ago
8d2e1926ca
remove unused class declarations
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
25c47cd1cf
Merge pull request #2197 from Exiv2/mainRefactoringFormats
...
Refactoring in JpegImage and Photoshop classes
3 years ago
84ba579af4
Merge pull request #2200 from neheb/3
...
clang-tidy with headers
3 years ago
f07c88de5d
Use .front() to avoid warning from static analysis
3 years ago
4d99c2aca1
Use std::pair to return multiple values
3 years ago
4ee9c35799
Include missing iostream header in photoshop.cpp
3 years ago
f942ba89bd
Move Photoshopb class to internal namespace
3 years ago
047f6b733e
Change logic to determine if segment has size
...
Note that the failing tests that had to be adapted were bad formed files
from FUZZERs. We should not consider invalid markers like 0x00 or 0x52
but only undefined APPn markers.
3 years ago
400632f27b
Factor out function readSegmentSize()
3 years ago
24d2a7b8f0
JpegBase::markerHasLength moved to implementation details
3 years ago
23fe743d4d
Move private constants to .cpp
3 years ago
b00e460d76
Move static functions to anonymous namespace
3 years ago
c997b09a81
algorithm conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
d789968e90
replace malloc/free with new/delete
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
b53ed72fd8
clang-tidy: manual special functions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a20ace20fc
clang-tidy: manual clang-tidy fixes
...
clang-tidy has issues applying these.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
ae66ecec0d
clang-tidy: use nullptr
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
49bf7e1387
clang-tidy: use delete
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
e654b2931c
clang-tidy: replace throw() with noexcept
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
1f05448d0e
clang-tidy: default member init
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
0d971e98e4
remove some unique_ptrs
...
They're not really used as pointers.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
053f516072
Merge pull request #2198 from neheb/3
...
some clang-tidy
3 years ago
89b8d4ea4e
try to actually fix null pointer deref
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
25ef5d7e77
replace ret variable with return statement
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
7bc9861301
clang-tidy: use strcmmp properly
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
7a826ac529
clang-tidy: add parentheses to macros
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
cacb54eaba
use auto
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
fdfcde5e4b
structured binding conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
bd0eefdab7
ci: Try to fix job which is killed due to low memory?
3 years ago
235bf522b2
Merge pull request #2181 from Exiv2/main_issue2179
...
[main] Fix integer overflow #2179
3 years ago
a505d6f06c
More unit tests for Photoshop methods
3 years ago
8ab7800477
Remove 2nd param from Photoshop::isIrb() since it is always hardcoded
3 years ago
7366a64d44
Add unit tests for Photoshop::isIrb().
...
It has been detected that we need to always pass the size==4 in the call
to isIrb. Probably it is better to remove that parameter and document
that it is assumed for the buffer to have a length of 4 bytes.
3 years ago
Rosen Penev
Luis Díaz Más
Miloš Komarčević