01a5d863ad
Apply clang-format to Print::printMetadatum
7 years ago
45fe44aa2f
Move condition in if statement to discard work earlier
7 years ago
d82b9434e1
Only print items (Params::prValue) when size > 0
7 years ago
185d0e9482
#199 Fix for getopt(). Use src/getopt_win32 code instead of libc/getopt()
7 years ago
a4a0516dc4
Merge pull request #238 from D4N/safe_op_improvements
...
Addition overflow checks improvements
7 years ago
06ec1e6984
[safe_op] Refactored addition overflow checks using functions only
...
- templated structs were not required, SFINAE works for functions too
=> use instead, removes some unneeded code
- fix non-usage of builtins with clang
- adjust unit tests
7 years ago
684c8c89de
[safe_op] Simplified unsigned int overflow check
...
Simply check for overflows after the addition, as no undefined behavior can
occur here.
7 years ago
31b96b58e7
[safe_op] improved signed int overflow checks via integer promotion
...
The fallback signed integer overflow check is quite expensive, but the addition
can be safely performed when saved in an int due to integer promotion
rules. This makes the check a little less expensive.
7 years ago
029b997ca0
[safe_op] fixed typo in doc-comment
7 years ago
28fa146d97
Merge pull request #230 from D4N/fix_170
...
Fix for #170
7 years ago
cabf756553
Add reproducer for #170 to the test suite
7 years ago
751fba8b54
Added dataBuf size check before calling PngChunk::decodeIHDRChunk
...
- cdataBuf must be at least 8 bytes long otherwise decodeIHDRChunk
reads out of bounds
- pngImage::readMetadata now skips png chunks where the offset for
IHDR chunks is invalid
- added assertion into PngChunk::decodeIHDRChunk() to ensure dataBuf
size
7 years ago
a1ab522eda
Merge pull request #231 from D4N/pngimage_documentation_fix
...
Fix outdated documentation of PngImage::doWriteMetadata()
7 years ago
22a7a8c2ed
Fix outdated documentation of PngImage::doWriteMetadata()
...
The function does not return anything, it only throws exceptions.
7 years ago
9f74f247b4
Merge pull request #227 from frli8848/master
...
Nikon mount - Sigma Lens Updates
7 years ago
73ac02d7f2
Added test for Sigma lenses
7 years ago
fc8b45dd12
Added the Sigma 120-300mm F2.8 DG OS HSM | S for Nikon mount.
7 years ago
34a3be025e
Added Sigma 50mm F1.4 DG HSM | A mount/UPC code (for Nikon mount).
7 years ago
215227024d
Added Sigma 20mm F1.4 DG HSM | A mount/UPC code (for Nikon mount).
7 years ago
f9d421b172
Merge pull request #109 from D4N/error_codes_enum
...
[WIP] Added error codes from src/error.cpp into an enumeration
7 years ago
3965a44df2
Replace error variable names in test suite with enum error codes
7 years ago
a15f090f81
Modified test suite so that case sensitive keys are possible
7 years ago
efe2ccdcb6
Replaced all hardcoded error codes with ker... constants
7 years ago
d897997b29
Force error code usage to construct a Exiv2::BasicError
...
changed parameter code_'s type from int to ErrorCode => requires the
usage of the enum constants
7 years ago
d3c3c036b8
Incorporated error codes into errList
7 years ago
b80fa1b4ed
Added error codes from src/error.cpp into an enumeration
7 years ago
efee9a2b58
Merge pull request #205 from D4N/CVE-2017-1000127_reproducer
...
Added reproducer for CVE-2017-1000127
7 years ago
ead7f309b0
Added reproducer for CVE-2017-1000127
7 years ago
55001c8ddf
Merge pull request #222 from Exiv2/fix-220
...
Fix 220
7 years ago
7d837d9c86
Changes to test/Makefile following Dan's review.
7 years ago
9cddfa514d
Merge pull request #207 from D4N/fix_cve_2018_4868
...
Fix CVE-2018-4868
7 years ago
72de0f96f3
Added reproducer for CVE-2018-4868 to the test suite
7 years ago
fcb4257051
Add check for DataBuf.size_ in Jp2Image::readMetadata()
...
When parsing a subBox that is a ColorHeader, a length is extracted
from the input file and fed directly into DataBuf() (which calls
malloc). A crafted input file can provide arbitrarily (up to
max(uint32_t)-8) large values and result in excessive memory
allocation.
This commit adds a check for the new size of DataBuf so that it is not
larger than the remaining size of the file.
This fixes #202 aka CVE-2018-4868
7 years ago
7f56236bb8
Merge pull request #212 from Kicer86/master
...
fix for crash in bigtiff (issue #208 )
7 years ago
a1f1989cb5
Merge branch 'master' into master
7 years ago
06e3570f10
Trivial Documentation Update
7 years ago
552247c3d0
Update test/Makefile not to exit on error
7 years ago
c082537967
Fix #220 https://github.com/Exiv2/exiv2/issues/220
7 years ago
5f360a99af
Merge pull request #217 from D4N/fix_187
...
Fix for #187
8 years ago
80c4d95171
Add regression test for CVE 2017-17669
8 years ago
e0ab5aaa87
Add error 14 text as a variable to the test suite
8 years ago
4429b962e1
Fix out of bounds read in src/pngchunk_int.cpp by @brianmay
...
- consider that key is advanced by 8 bytes if stripHeader is true
=> length is reduced by same amount
Fixed by adding offset to the check in the loop
- Rewrote loop so that keysize is checked before the next
iteration (preventing an out of bounds read)
8 years ago
df4113b765
changes to MemIo::reserve() for #200 ( #213 )
...
* changes to MemIo::reserve() for #200
* Changes following review by Dan (thanks, Dan).
8 years ago
d219e61586
be more error prone
8 years ago
24348e85ca
checks for valid reads
8 years ago
421c6d6723
improvements for issue #208
8 years ago
b7d76da9d5
Merge pull request #203 from Exiv2/fix_201
...
Fix #201
8 years ago
dba9fba725
test for issue #208
8 years ago
1647908e00
fix for crash in bigtiff (issue #208 )
8 years ago
9900f523fe
Added reproducer for #201 to the test suite
8 years ago
Luis Díaz Más
Robin Mills
D4N
Dan Čermák
Fredrik lingvall
Fredrik Lingvall
Michał Walenciak