a20ace20fc
clang-tidy: manual clang-tidy fixes
...
clang-tidy has issues applying these.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
ae66ecec0d
clang-tidy: use nullptr
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
49bf7e1387
clang-tidy: use delete
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
e654b2931c
clang-tidy: replace throw() with noexcept
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
1f05448d0e
clang-tidy: default member init
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
0d971e98e4
remove some unique_ptrs
...
They're not really used as pointers.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
89b8d4ea4e
try to actually fix null pointer deref
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
25ef5d7e77
replace ret variable with return statement
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
7bc9861301
clang-tidy: use strcmmp properly
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
7a826ac529
clang-tidy: add parentheses to macros
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
cacb54eaba
use auto
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
fdfcde5e4b
structured binding conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a505d6f06c
More unit tests for Photoshop methods
3 years ago
8ab7800477
Remove 2nd param from Photoshop::isIrb() since it is always hardcoded
3 years ago
e715243aa5
Fix integer overflow #2179
3 years ago
6e9eca445a
Merge pull request #2177 from neheb/1
...
clang-tidy and manual stuff
3 years ago
bd68c14de5
Detect integer-overflow and throw in that case
3 years ago
262d0ee4b3
struct to std::pair conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
e82be13b73
C to std::function
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
e9896d1f99
clang-tidy: fix inconsistent decleration
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
d190baac6c
clang-tidy: do not use using namespace
...
Found with google-build-using-namespace
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
c35fb7104b
clang-tidy: use any_of
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
3298fcf656
some chrono
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
b25e75dd7b
replace Sleep with sleep_for
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
dfb93dd8cd
clang-tidy: use C++ headers
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
aa41d557b2
function move
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
06d977d7bc
clang-tidy: use default
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
9f67620503
clang-tidy: add more nodiscard
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
b72e4b0e44
clang-tidy: use auto
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
d16ca65b01
Fix out of bounds read in isValidBoxFileType()
3 years ago
3b9fcb4b3d
Update .clang-format to align pointers to the types
3 years ago
790fc465f4
Merge pull request #2172 from Exiv2/mergify/bp/main/pr-2167
...
Initial support for OM System MakerNote (backport #2167 )
3 years ago
fafe999c6e
remove unused var from deleted stuff
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
8fa30d66b4
Initial support for OM System MakerNote
...
(manually adapted from 916436903d34b88ea0d49c5084c51e02cfae9bfb)
3 years ago
c0868aff31
std::function
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
389501462a
delete
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
043547cbd0
remove various usages of memset
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
bad4712df8
static constexpr conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
9dc35e7380
find to std::find
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
9cb1fcef5c
std::array conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
d7f35e33f0
Remove useless static_casts
3 years ago
ae4df71233
Remove DataBuf::copyBytes and use std::copy instead
3 years ago
5b0418d136
Improve compare function: no need to count chars
3 years ago
b05573fadc
Remove most of the asserts from codebase
3 years ago
1ad9e52f3c
Fix windows build
3 years ago
1545a1bc4a
JP2 - stronger checks on Signatuer and FileType boxes
3 years ago
e7478f744d
Jp2Image: Implement more checks from JP2 standard + fix bug
...
- add debug info when parsing Signature box
- Move definitions & static stuff to anonymous namespace
- cleanup while studying code
- Make exceptions more similar to other formats
3 years ago
b48e8e9379
Add unit tests for Jp2Image revealing bugs (see #2147 )
3 years ago
5d5354edee
clang-tidy: C array to std::array conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
30bf563f4d
Update .clang-format file & apply clang-format to whole project
3 years ago
b2b6d834ba
some std::array conversions ( #2148 )
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
573c3c79fc
Merge pull request #2145 from Exiv2/mainSizeT_n
...
More migration to size_t
3 years ago
04ae6c2c4c
Add key name to "Value not set" error message ( #2149 )
...
The error typically occurs when writeMetadata() is called. It's easier
to find the problem if you know which datum hasn't had a value set.
3 years ago
4355d635d4
More conversions to size_t while removing static_casts
3 years ago
7576a2757b
More size_t for sizes
3 years ago
137ea080b5
Change Metadatum::size() return value from long to size_t
3 years ago
62aad98d0b
Change Metadatum::copy return value from long to size_t
3 years ago
fa24fb22ca
Use compiler deduction guides for error list
3 years ago
7119b7676f
remove templating & simplify error message
...
+ clang-format in Error files
+ Remove AnyError
3 years ago
96f7f2e4c5
Convert Exiv2::ErrorCode into an enum class
3 years ago
5d08bb9bec
Merge pull request #2146 from Exiv2/mainDatesWithZeros
...
DateValue is now a bit more permissive with malformed dates
3 years ago
c115d4daf7
Merge pull request #2131 from Exiv2/mainCleanups
...
Include what you use + more SPDX identifiers + few other cleanups
3 years ago
56c52be8b5
DateValue is now a bit more permissive with malformed dates
3 years ago
5c36c690f9
Merge pull request #2137 from Exiv2/mainRecoverRecordId
...
Recover IptDataSets::recordId in the API
3 years ago
a009ac1f61
Merge pull request #2135 from neheb/1
...
manual nullptr removals
3 years ago
c1ae1bcb03
Recover IptDataSets::recordId in the API
3 years ago
8dadcdf72a
manual nullptr removals
...
unique_ptr has a bool overload. It's also easier to reason about.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
784cbe2965
manual move conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
eb49d66caf
Strip XMP raw packet before decoding
3 years ago
b8304fffa4
clang-tidy: don't use C casts
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
89e66ffd37
Merge pull request #2132 from neheb/2
...
misc cleanups
3 years ago
f894ee0568
Fix debug builds
3 years ago
c0a3242e73
C++-style headers
3 years ago
c2bcd4b08e
replace EXV_COUNTOF with std::size
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
61a5d8594c
remove some new
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
17a13072e6
manual unimplemented operator = delete
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
b3823f4c8d
conversions to make_unique
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
b6bdbf5574
clang-tidy: don't use else after return/throw
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
9f949195e4
clang-tidy: add ending namespace comment
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
09ca3ca1f2
manual namespace concatenations
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
c146ae5215
Fix mac build
3 years ago
bbc99ae581
Use auto for unique pointers
3 years ago
f156af46f3
Fix build on Windows
3 years ago
b3a216310a
Removing unused headers thanks to IWYU
3 years ago
22064c957d
Add missing header to the CMake configuration
3 years ago
2834fa5f05
Use [[maybe_unused]]
3 years ago
5508e6f466
hexdump to size_t
3 years ago
8b1fe379a1
Removing unused headers thanks to IWYU
3 years ago
3f3b651c04
Remove unused stuff
3 years ago
15697fcd1e
Remove unused file
3 years ago
23da0c3955
Do not define not needed stuff
3 years ago
7ed43037e3
Guard against parsing "inf" into an int64 in the EasyAccess/ISO API.
...
(Diff authored by clanmills)
3 years ago
f0d23eca9b
clang-tidy: add some missing operators
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
daf7c890e2
misc stuff
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
95355fe214
clang-tidy: remove C casts
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
8cda090e58
clang-tidy: get rid of compare() usage
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
63e41c3aeb
clang-tidy: simplify bool
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
133849c394
clang-tidy: remove pointless get()
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
6d1fa2ecea
clang-tidy: use empty() instead of size()
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
5833101b9b
manual nullptr conversions
...
Mostly not caught because I'm not running clang-tidy on Windows.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
e6d3315160
clang-tidy: use emplace_back
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
77e79b32f5
manual braced init conversion
...
clang-tidy's not converting these for some reason.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a25bbe133f
constexpr string conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
887b08b0b7
clang-tidy: range loop conversion
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
04bacdedd6
clang-tidy: use auto
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
962e3b7369
clang-tidy: use default
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a5c094b85f
clang-tidy: use concat namespaces
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
118aa78aa0
clang-tidy: use braced init list
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
f65848a590
simplify ReplaceStringInPlace slightly
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
5d60a91ebc
move initializations to class
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a67e0d525f
move namespace fs below includes
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
ae3e28c62a
make array constexpr
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
b17828b454
Use SPDX for licenses ( #2122 )
...
* Use SPDX identifier in header files
* Use SPDX identifier in rest of source files
* Fix usage of SPDX for files with 2 licenses
* Add global license file
* Fix compilation
3 years ago
5ca423d292
Merge pull request #2118 from Exiv2/main_NewDelete
...
Refactoring & Cleanup (Moving to size_t usage & less naked new/deletes)
3 years ago
a5b6db171c
Merge pull request #1919 from dimin/viqi
...
fix for reading jpeg-xr images
3 years ago
ac9b9e2c95
Merge pull request #2071 from Sturmflut/nikon-improve-lens-docs
...
[nikon] Add instructions for adding new Nikon F mount lenses
3 years ago
208ec70df8
Fix windows builds
3 years ago
e07c3771da
Fix more issues found by fuzzer
3 years ago
12738214f2
Fix warnings and place return statements separated from if
3 years ago
f6b17d2a4d
Fix issues found by fuzzer
3 years ago
b9f9d041ea
Several transformations on DataBuf + migration to size_t
...
- Provide begin/end iterators to DataBuf and simplify code
- Adapt test output after last changes
- Replacing long by size_t in value.hpp
- Use size_t in some Photoshop functions
- Remove some static_casts
3 years ago
7dea0050b1
Factor out duplicated piece of code
3 years ago
5d627433fc
Remove useless DataBuf::clear()
3 years ago
3a749e6861
No need to define copy & move ctors
3 years ago
2bacff0f5c
Simplify DataBuf
3 years ago
615ccff5ab
Fix another case revealed by tests
3 years ago
6e50714726
Replace c style arrays by std::array
3 years ago
f1e04ee866
Replace DataBuf internal buffer with std::vector
3 years ago
aec36f86d7
Replace naked new operators
3 years ago
9bf4967e5c
Merge pull request #2110 from mallman/nikon_ContrastDetectAFInFocus
...
Make Nikon ContrastDetectAFInFocus tags Bytes that print as "Yes" or "No"
3 years ago
5ff7d89a4c
Document origin of data size specifications for Nikon maker note tag 0xb7
3 years ago
54eab964a6
When selecting which version of nikonAf2 metadata to parse, include the
...
size of the data declared in the tag header as part of the lookup
3 years ago
c5a9dfd9af
Merge pull request #2109 from Exiv2/main_StringView
...
Refactoring & cleanup
3 years ago
a3e2410b88
Print value of ContrastDetectAFInFocus as Yes/No. Change internal
...
selection logic for NikonAf2* from tag data length to group version
3 years ago
5d86044c71
Merge pull request #2107 from kevinbackhouse/MetadataToLong
...
Replace Metadatum::toLong() with Metadatum::toInt64().
3 years ago
21eb0cec4f
Fix build when EXIV2_BUILD_MESSAGES is ON
3 years ago
8b3da36f42
Improvements from code review
3 years ago
a7ce4ee846
Move Metadatum::toUint32() implementation out of header file.
3 years ago
9541a89b13
Make Exif.NikonAf2.ContrastDetectAFInFocus and
...
Exif.NikonAf22.ContrastDetectAFInFocus byte types
3 years ago
5db9a25b19
Fix compiler warnings.
3 years ago
90aa007188
Convert type of pixelHeight/pixelWidth to platform-independent uint32_t.
3 years ago
f774a3b25e
Fix build on linux
3 years ago
9fb43f28e0
Use standard [[maybe_unused]]
3 years ago
76f01fd4d3
Clean more header inclusions
3 years ago
7e5ba7cb23
Remove many redundant or not needed header inclusions
3 years ago
b543f3e973
Use filesystem in getExiv2ConfigPath
...
It seems to have an important impact in performance. The execution of
ctest on Windows passed from 48.5 secs to 43.8. Check if this is the
same on Linux
3 years ago
476a5e23f9
Replace raw loop for any_of
3 years ago
59f4d0de27
cppcheck: reduce scope of variables
3 years ago
d11479e53c
Replace dynamic C array by std::vector
3 years ago
ea201ce613
Remove dead code
3 years ago
1d243ed40e
Remove dead code: copyXattrFrom
3 years ago
c0b663b7ea
Remove dead code (LSTAT)
3 years ago
798cf9baeb
Remove dead code (winNumberOfLinks)
3 years ago
a6185d29c6
Image::setComment now takes string_view
3 years ago
56b5ab9a29
Use remove from filesystem
3 years ago
9b3a643d33
Use rename from filesystem
3 years ago
8b2d17312e
ReplaceStringInPlace does it in-place now
3 years ago
45300ad667
BasicIo::path() returns const ref
3 years ago
0726104b1a
Hide pathOfFileUrl in the only place where it is used
3 years ago
6f762b4e66
Use std::filesystem for fileExist
3 years ago
f1ff3aaa4c
Make urldecode in-place
3 years ago
3d370cc2ae
Improvements in urlencode
3 years ago
8e0e00c459
make startsWith constexpr and use string_view
3 years ago
f5c89a4e62
Fix build on Windows
3 years ago
405f4b5f1b
Remove Util::dirname and finally the util files
3 years ago
1b912fa887
get rid of suffix
3 years ago
dad3e7f5c4
Replace suffix implementation with std::filesystem
3 years ago
2c51208622
Replace basename implementation with std::filesystem
3 years ago
d64c2aad67
Replace dirname implementation with std::filesystem
3 years ago
f1c8d5bbb4
Remove unused headers
3 years ago
7c6a7aefc2
Utils::strtol only used in the app
3 years ago
8c6e22e6aa
replace is only used in actions.cpp
3 years ago
49fbfb44a3
Remove startsWith from utils
3 years ago
d1524e3d96
simpler implementation of startsWith
3 years ago
a725d22ea5
add characterisation tests for utils
3 years ago
a8bb38ab6f
Move exiv2 app into its own folder
3 years ago
256365830a
Replace Metadatum::toLong() with Metadatum::toInt64().
3 years ago
15c91b4cc9
Merge pull request #2101 from Exiv2/main_LinuxDistrosOnPRs
...
Linux distros jobs on PRs + Fix linking issues on some platforms
3 years ago
38254be55e
Install new image_types.h header
3 years ago
b7d5c7e22a
Link against stdc++fs on Linux when it is needed
3 years ago
287744fa12
Merge pull request #2087 from Exiv2/update_canon_tags_2
...
Update canon tags 2
3 years ago
408d80bce8
Change order of ImageType values
3 years ago
f10283f118
bug: Fix crash when calling ImageFactory::create(none)
3 years ago
5a9799ffb2
Replace ImageType namespace by a enum class
3 years ago
0aa34c3098
fix(canon): cleanup canonAf2 and canonAf3 related code
3 years ago
800ed8959f
Rewire Canon MakerNote 0x0026 (AFInfo) to allow TiffDecoder::decodeCanonAFInfo to handle this tag.
...
Minor changes to test script.
Cosmetic code changes.
3 years ago
d19e2d42df
Use AutoRotate
3 years ago
e625f331f9
Include CanonFlashInfo (somehow missing after cherry-picking)
3 years ago
de036b2b2a
Fix remaining wrong brackets
3 years ago
4977b7d5c3
controlmode added
3 years ago
f247014ee6
AEB Bracket Value added
3 years ago
5800942a9b
OpticalZoomCode added
3 years ago
d72ca6806c
ExposureCompensation added
3 years ago
50390717f7
fix wrong brackets
3 years ago
c6b8be5498
wrong brackets fixed
3 years ago
b70a3fb572
Canon AF Info 2 Tag
3 years ago
5cc52feb4b
Adding Canon RawBurst Tag
3 years ago
cf36feaa61
Adding Canon AF Config Tag
3 years ago
56a455422d
Adding LensSerialNumber Tag
3 years ago
e3311b9a4f
canon filter options
3 years ago
d6f1f7c614
Adding of Canon Vignetting Correction Tag 2
3 years ago
8b174900fa
Adding Canon Lighting Optimization Tag
3 years ago
524b33e5df
Canon MultiExposure tag added
3 years ago
e2b1028973
Adding tag Canon AFMicroAdj
3 years ago
80d67b89c6
Adding Ambience Selection to tag list
3 years ago
3ffe9938f8
Decoding of Canon HDRInfo tag
3 years ago
b589ced049
update to tags
3 years ago
5f2dee4d40
update canonrf tags, new lenses
3 years ago
081f458bf1
update tags ID
3 years ago
f41e7e59e3
second rund
3 years ago
23293064bb
work on canon tags
3 years ago
23f089a1b6
Apply suggestions from code review
...
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>
3 years ago
f59a9abfe3
Remove unused PRINTUCS2 CMake option
3 years ago
432555eae8
Replace platform specific code with std::filesystem
3 years ago
fdfb295cc4
windows: Trick to get UTF-8 encoded argv in main entry point
...
- Adapt exifprint to the new wmain strategy
- Delete have_unicode_path
- wmain does not work with MSYS & MinGW
- cmake: entry point via cmake instead of pragma
- cmake: better doc for MSVC flags
- Fix entry point in sample apps
- Adapt CMake code to work with MSVC & MinGW
3 years ago
7933ff401d
Remove dead code around EXV_UNICODE_PATH
3 years ago
2a3dd2def9
Replace Value::toLong with Value::toInt64. ( #2062 )
...
* Replace Value::toLong with Value::toInt64.
* Fix compiler warning.
* Fix compile error.
* Fix declaration of canonEv
* Fix compiler warning.
* Fix compiler warning.
* Use int64_t for offsets in tiffcomposite_int.cpp
* Fix compiler warning.
* Fix compiler warnings.
* Fix compiler warning.
* Fix compiler warning.
* Fix compiler warning.
* Fix compiler warning.
* Remove static_cast<long int> in TagDetails initializer.
3 years ago
f2385a35aa
[nikon] Add Tokina ATX-i 11-20mm F2.8 CF lens ( #2072 )
...
* [nikon] Add Tokina ATX-i 11-20mm F2.8 CF lens
* [nikon] Add test for Tokina ATX-i 11-20mm F2.8 CF lens
Co-authored-by: Sturmflut <Simon Raffeiner>
Co-authored-by: Luis Díaz Más <piponazo@gmail.com>
3 years ago
50f34f4561
[nikon] Add instructions for adding new Nikon F mount lenses
...
- Also cleans up a dead link
3 years ago
eeb1e1d5f7
[nikon] Add Tokina AT-X 14-20 F2 PRO DX lens
3 years ago
1f07715141
Revert "Delete dead code"
...
This reverts commit 1d6bac61f2
3 years ago
b96091880a
Merge pull request #2061 from Exiv2/main_pvs
...
Adding static analysis with PVS-Studio
3 years ago
ac9439e931
Merge pull request #2063 from Exiv2/main_iterators
...
Modernise code around iterators & smart pointers
3 years ago
46c329081f
Fix `exiv2`: verbose extract stdout mutli-file ( #2068 )
...
When using `exiv2 --verbose --extract` with stdout and multiple files, the output is concatenated together.
3 years ago
524fad42e1
Remove useless ops
3 years ago
93fe2086e4
Simplify TaskFactory
3 years ago
f18d04cb8f
Modern implementation of Singleton
...
With this implementation we also make the initialization of the Singleton instance thread-safe
3 years ago
d20f014807
Simplify cloning in actions
3 years ago
b67dee8a57
Fix build on linux
3 years ago
0f03e77634
Simplify code around UniquePtr(s) & use make_unique over new
3 years ago
db4b63937e
Add some TODO comments
3 years ago
9d8dd86945
Use auto to reduce verbosity around code dealing with iterators
3 years ago
3b1d31e0af
Add Sigma 12-24mm F4 DG HSM Art lens for Nikon
3 years ago
a42501864a
Recover some documentation strings
3 years ago
c531c4abf5
More tests for IptcDataSets
3 years ago
476a254dfc
Remove dead code
...
No way to obtain nullptr DataSet* when we are checking already the 2
only existing DataSets above.
3 years ago
9b40f948eb
More tests
3 years ago
15e8c75a38
Delete unused IptcKey copy operator
3 years ago
d8fcbc4562
Add new tests for Iptc classes
3 years ago
df0b7c450d
Hide public details
3 years ago
8f9a780375
clang-format on datasets.cpp
3 years ago
1d6bac61f2
Delete dead code
3 years ago
071e73fa4d
Add many tests for datasets
3 years ago
a94d648d05
Rest of tests to have 100% coverage in BMP class
3 years ago
edf39e00dd
Add new BMP tests
3 years ago
e56abfa10a
Spelling ( #2067 )
...
* spelling: accelerometer
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: address
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: anonymous
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: available
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: baby
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: buffer
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: build
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: builds
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: by inclusion
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: byte order
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: camera
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: command
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: consistency
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: constructor
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: continuous
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: continuously
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: correspond
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: decompression
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dedicated
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: denominator
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dependencies
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: detector
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dlighting
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dragging
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: duplicate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dynamic
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: empty
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: enable
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: endianness
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: examining
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: exceed
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: extension
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: fact
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: fails
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: fixed
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: fluorescent
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: focuspoint
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: focuspoints
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: from
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: happened
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: hierarchy
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: initiate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: interesting
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: internal
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: javascript
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: language
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: libiconv
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: libraries
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: library
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: localization
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: macros
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: member
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: members
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: metadata
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: miscellaneous
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: mnemonic
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: modified
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: multiple
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: multithreaded
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: mysterious
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: photoshop
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: platforms
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: preliminary
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: priority
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: properties
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: qualifier
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: recognition
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: recognized
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: reentrancy
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: remaining
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: remotetest
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: requested
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: sensitivity
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: standardize
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: successful
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: such
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: tags
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: temperature
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: test
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: the
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: these
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: third
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: this
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: transparent
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unable
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: underwater
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: uninterpreted
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: using
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: utc - coordinated universal time
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: which
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: with
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
3 years ago
da320f35a7
Remove experimental code from pr#2053
3 years ago
6c59437319
Add IPTC 2021.1 source comments for pr#2053
3 years ago
fe83240bb8
Update XMP IPTC tags to 2021.1 standard
...
Changes:
1. Add/update tags.
2. According to the standard, several tags in
`Xmp.iptc.<property>` and `Xmp.iptcExt.<property>`, had been
wrongly added, as they only exist as part of a struct used by a
tag. The incorrect tags have been marked as deprecated in the
label and description.
3. Update existing test with translated output.
Ref: [IPTC Photo Metadata Standard 2021.1](https://www.iptc.org/std/photometadata/specification/IPTC-PhotoMetadata-2021.1.html )
3 years ago
b0318c36be
Upgrade C++ standard to c++17 ( #2052 )
...
* Enable C++17 and use new inline specifier for const variable members
* Silence deprecation warning on MSVC
* Disable samples by default
* improvements after review
3 years ago
629442df9d
Merge pull request #1929 from postscript-dev/fix_exiv2_-pR
...
Fix `exiv2 -pR` for Sony images (#1805 )
4 years ago
825c0c72bc
Check array index before inspecting it
4 years ago
240a72468e
Clang-format in pngchunk_int.cpp
4 years ago
ec21f65dca
Replace magicValue with constant variable
4 years ago
ceae86899d
Initialize uninitialized variables
4 years ago
b96f5af037
Remove dead code
4 years ago
061df50cea
keyTXTChunk improvement
4 years ago
c19425f6a4
Add unit tests for PngChunk::keyTXTChunk
4 years ago
c898f56ab2
cmake: Add missing source file
4 years ago
813566526c
Revisiting cmake code for generating coverage reports ( #2047 )
...
* cmake: better usage of gcovr for coverage reports
* Add test for FileIo::setPath
* Remove useless seek() overload
* Add missing override specifiers
* ignore .vs folder
* Small refactors in BasicIo implementations
* Remove duplicated doxygen doc
* Refactor & add tests for MemIO
* Fix compilation warnings on windows
4 years ago
a094dde1de
Merge pull request #2040 from kevinbackhouse/TiffEntryBaseStorage
...
Use std::shared_ptr for storage in TiffEntryBase
4 years ago
b52b6db39f
Output of -PV was not suitable for inputting to -m-, key was missing. ( #1970 )
...
* Output of -PV was not suitable for inputting to -m-, key was missing.
Fix #1969
* Make V flag to -P also print the type
This makes -PV work also for non-built-in tags (of which their type is
not known by exiv2).
* Adjust man to accomodate for the V flag change
4 years ago
9268279b47
Add comments.
4 years ago
b6a4fd1c67
Add storage parameter to setData.
4 years ago
29f7d0ccf0
Remove DataBuf::release() which is no longer used.
4 years ago
9f3240c91c
Delete TiffEntryBase::isMalloced_ field and use a std::shared_ptr instead.
4 years ago
29cc981180
Merge pull request #2028 from kevinbackhouse/FixIssue2027
...
Use memmove in TiffEncoder::updateDirEntry
4 years ago
13a2cf336d
fix_1416_iptc_DateCreated ( #1547 )
...
* fix_1416_iptc_DateCreated
* Fix unit tests
* DateValue:read 2nd iteration on pre-condition
* test with ISO_8601 date format
* Use std::regex for ISO 8601 basic & extended date formats
* Use std::regex for ISO 8601 basic & extended time formats
* Add more tests & notes for DateValue & TimeValue
* Comment tests using local calendar times
* DateValue::write also adds padding to year field
Co-authored-by: Luis Díaz Más <piponazo@gmail.com>
4 years ago
e34eacc467
Use memmove, rather than memcpy, because memory regions might overlap.
4 years ago
fd8447129c
Add more DNG 1.6 tags ( #2023 )
...
* Add more DNG 1.6 tags
* Update CinemaDNG, add more spec links
4 years ago
65fad9db0e
Merge pull request #2007 from kevinbackhouse/FixIssue2006
...
Fix integer overflow in PanasonicMakerNote::printAccelerometer
4 years ago
aebb3fb2c0
Merge pull request #2015 from kevinbackhouse/SonyPreviewUndefined
...
Treat Exif.Sony1.PreviewImage as undefined tag
4 years ago
0a1fa497d5
Merge pull request #1999 from jim-easterbrook/bug_1998
...
Restore modified tags after TZ manipulation
4 years ago
a1ad29edf3
Treat Exif.Sony1.PreviewImage as undefined tag.
4 years ago
35f48ae5c9
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=41438
...
Replace weird sign-conversion code with a simple static_cast.
4 years ago
6758e7288d
Merge branch 'main' into fix_exiv2_-pR
4 years ago
797f86c226
Fix minor whitespace formatting
...
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>
4 years ago
9c294ef4fd
Fix exiv2: verbose extract to stdout (see #1934 )
...
Fix ignores `--verbose` when extracting to stdout.
4 years ago
02ce7e9aff
Restore modified tags after TZ manipulation
...
This ensures that Xmp date/times that have been set by the user aren't
over written by the TZ restoration efforts. This fixes bug #1998
4 years ago
fde8ed07b3
Merge pull request #1967 from kevinbackhouse/ReadOrThrow
...
Add readOrThrow and seekOrThrow to BasicIo
4 years ago
1ae9f42cd8
Add camera models for NikonFl3 makernotes group ( #1994 )
...
* Add camera models for NikonFl3
* Python test for new NikonFl3 camera models
4 years ago
562b10f2c7
Fix Exif.NikonFl7.FlashCompensation
4 years ago
bd676bedc6
Fix `exiv2 -pR` for Sony images ( #1805 )
...
`exiv2 -pR` failed to process Sony makernotes. Fix checks if
makernotes header has Sony string, then uses correct offset.
Fix supplied by @clanmills
4 years ago
277b1875f7
Fix Exif.NikonFl7.FlashGroupBCControlData output
4 years ago
b3ca98c1e7
Fix Exif.NikonFl7.FlashCompensation pretty print
4 years ago
8ebf10f921
Fix condition in Exif.NikonFl7.FlashCompensation
4 years ago
f23d965643
Add limits check: Exif.NikonFl7.FlashCompensation
4 years ago
f0f3c7e8a2
Fix compile issues for NikonFl7 makernotes group
...
+ Fix fuzzing CI errors of `exp2` and `round` not being in `std` by adding
`#include <cmath>`
+ Fix Windows CI warning C4305 by explicitly defining value as a float
4 years ago
eb134d1946
Add testing for NikonFl7 makernotes group
4 years ago
ab90d430c7
Merge pull request #1979 from postscript-dev/fix_exiv2_sample_thumb_stdout
...
Add exiv2 extract thumb to stdout (#1934 )
4 years ago
68473d9d10
Remove static functions readOrThrow and seekOrThrow.
4 years ago
44542a9f94
Add readOrThrow and seekOrThrow to BasicIo.
4 years ago
8b7d8729b7
Expose unsupported CR3 previews as binary
4 years ago
31a2467a61
Add exiv2 extract thumb to stdout ( #1934 ): src
4 years ago
40e5021577
Limit CR3 previews to JPEG only
4 years ago
0ae85cc4ca
Merge pull request #1974 from dhoulder/skip-isobmff-boxes
...
Performance boost: don't read boxes we're not interested in
4 years ago
2d80891837
Only include expat.h when XMP is enabled. ( #1973 )
...
(cherry picked from commit 03cc59122249e79c5a72982b25dad88f4c2803d6)
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>
4 years ago
4e587fa931
Performance boost: don't read boxes we're not interested in
4 years ago
b385f2db1c
Canon cr3 previews ( #1958 )
...
* Extract THMB and PRVW images from Canon CR3 file
* Added test for Canon CR3 preview extraction.
Added test data Canon-R6-pruned.CR3 (first 492016 bytes of https://raw.pixls.us/getfile.php/4659/nice/Canon%20-%20Canon%20EOS%20R6%20-%203:2.CR3 ).
See https://github.com/Exiv2/exiv2/issues/1893
* Fixed format specifier
* Update src/bmffimage.cpp
Co-authored-by: Miloš Komarčević <4973094+kmilos@users.noreply.github.com>
* Update src/bmffimage.cpp
Co-authored-by: Miloš Komarčević <4973094+kmilos@users.noreply.github.com>
* retrigger checks
Co-authored-by: Miloš Komarčević <4973094+kmilos@users.noreply.github.com>
4 years ago
71744d5f7f
Merge pull request #1944 from Exiv2/nikon_colorbalance
...
Extending Nikon3.ColorBalance version coverage
4 years ago
Rosen Penev
Luis Diaz
Miloš Komarčević
Jim Easterbrook
Michael Allman
Robin Mills
Kevin Backhouse
Christoph Hasse
Alex Esseling
Christoph Hasse
Sturmflut
Sturmflut
Peter
Josh Soref
Facundo
Miloš Komarčević
mergify[bot]
David Houlder