e6d3315160
clang-tidy: use emplace_back
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
77e79b32f5
manual braced init conversion
...
clang-tidy's not converting these for some reason.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a25bbe133f
constexpr string conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
887b08b0b7
clang-tidy: range loop conversion
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
04bacdedd6
clang-tidy: use auto
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
962e3b7369
clang-tidy: use default
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a5c094b85f
clang-tidy: use concat namespaces
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
118aa78aa0
clang-tidy: use braced init list
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
f65848a590
simplify ReplaceStringInPlace slightly
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
5d60a91ebc
move initializations to class
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
a67e0d525f
move namespace fs below includes
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
ae3e28c62a
make array constexpr
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years ago
b17828b454
Use SPDX for licenses ( #2122 )
...
* Use SPDX identifier in header files
* Use SPDX identifier in rest of source files
* Fix usage of SPDX for files with 2 licenses
* Add global license file
* Fix compilation
3 years ago
5ca423d292
Merge pull request #2118 from Exiv2/main_NewDelete
...
Refactoring & Cleanup (Moving to size_t usage & less naked new/deletes)
3 years ago
a5b6db171c
Merge pull request #1919 from dimin/viqi
...
fix for reading jpeg-xr images
3 years ago
ac9b9e2c95
Merge pull request #2071 from Sturmflut/nikon-improve-lens-docs
...
[nikon] Add instructions for adding new Nikon F mount lenses
3 years ago
208ec70df8
Fix windows builds
3 years ago
e07c3771da
Fix more issues found by fuzzer
3 years ago
12738214f2
Fix warnings and place return statements separated from if
3 years ago
f6b17d2a4d
Fix issues found by fuzzer
3 years ago
b9f9d041ea
Several transformations on DataBuf + migration to size_t
...
- Provide begin/end iterators to DataBuf and simplify code
- Adapt test output after last changes
- Replacing long by size_t in value.hpp
- Use size_t in some Photoshop functions
- Remove some static_casts
3 years ago
7dea0050b1
Factor out duplicated piece of code
3 years ago
5d627433fc
Remove useless DataBuf::clear()
3 years ago
3a749e6861
No need to define copy & move ctors
3 years ago
2bacff0f5c
Simplify DataBuf
3 years ago
615ccff5ab
Fix another case revealed by tests
3 years ago
6e50714726
Replace c style arrays by std::array
3 years ago
f1e04ee866
Replace DataBuf internal buffer with std::vector
3 years ago
aec36f86d7
Replace naked new operators
3 years ago
9bf4967e5c
Merge pull request #2110 from mallman/nikon_ContrastDetectAFInFocus
...
Make Nikon ContrastDetectAFInFocus tags Bytes that print as "Yes" or "No"
3 years ago
5ff7d89a4c
Document origin of data size specifications for Nikon maker note tag 0xb7
3 years ago
54eab964a6
When selecting which version of nikonAf2 metadata to parse, include the
...
size of the data declared in the tag header as part of the lookup
3 years ago
c5a9dfd9af
Merge pull request #2109 from Exiv2/main_StringView
...
Refactoring & cleanup
3 years ago
a3e2410b88
Print value of ContrastDetectAFInFocus as Yes/No. Change internal
...
selection logic for NikonAf2* from tag data length to group version
3 years ago
5d86044c71
Merge pull request #2107 from kevinbackhouse/MetadataToLong
...
Replace Metadatum::toLong() with Metadatum::toInt64().
3 years ago
21eb0cec4f
Fix build when EXIV2_BUILD_MESSAGES is ON
3 years ago
8b3da36f42
Improvements from code review
3 years ago
a7ce4ee846
Move Metadatum::toUint32() implementation out of header file.
3 years ago
9541a89b13
Make Exif.NikonAf2.ContrastDetectAFInFocus and
...
Exif.NikonAf22.ContrastDetectAFInFocus byte types
3 years ago
5db9a25b19
Fix compiler warnings.
3 years ago
90aa007188
Convert type of pixelHeight/pixelWidth to platform-independent uint32_t.
3 years ago
f774a3b25e
Fix build on linux
3 years ago
9fb43f28e0
Use standard [[maybe_unused]]
3 years ago
76f01fd4d3
Clean more header inclusions
3 years ago
7e5ba7cb23
Remove many redundant or not needed header inclusions
3 years ago
b543f3e973
Use filesystem in getExiv2ConfigPath
...
It seems to have an important impact in performance. The execution of
ctest on Windows passed from 48.5 secs to 43.8. Check if this is the
same on Linux
3 years ago
476a5e23f9
Replace raw loop for any_of
3 years ago
59f4d0de27
cppcheck: reduce scope of variables
3 years ago
d11479e53c
Replace dynamic C array by std::vector
3 years ago
ea201ce613
Remove dead code
3 years ago
1d243ed40e
Remove dead code: copyXattrFrom
3 years ago
c0b663b7ea
Remove dead code (LSTAT)
3 years ago
798cf9baeb
Remove dead code (winNumberOfLinks)
3 years ago
a6185d29c6
Image::setComment now takes string_view
3 years ago
56b5ab9a29
Use remove from filesystem
3 years ago
9b3a643d33
Use rename from filesystem
3 years ago
8b2d17312e
ReplaceStringInPlace does it in-place now
3 years ago
45300ad667
BasicIo::path() returns const ref
3 years ago
0726104b1a
Hide pathOfFileUrl in the only place where it is used
3 years ago
6f762b4e66
Use std::filesystem for fileExist
3 years ago
f1ff3aaa4c
Make urldecode in-place
3 years ago
3d370cc2ae
Improvements in urlencode
3 years ago
8e0e00c459
make startsWith constexpr and use string_view
3 years ago
f5c89a4e62
Fix build on Windows
3 years ago
405f4b5f1b
Remove Util::dirname and finally the util files
3 years ago
1b912fa887
get rid of suffix
3 years ago
dad3e7f5c4
Replace suffix implementation with std::filesystem
3 years ago
2c51208622
Replace basename implementation with std::filesystem
3 years ago
d64c2aad67
Replace dirname implementation with std::filesystem
3 years ago
f1c8d5bbb4
Remove unused headers
3 years ago
7c6a7aefc2
Utils::strtol only used in the app
3 years ago
8c6e22e6aa
replace is only used in actions.cpp
3 years ago
49fbfb44a3
Remove startsWith from utils
3 years ago
d1524e3d96
simpler implementation of startsWith
3 years ago
a725d22ea5
add characterisation tests for utils
3 years ago
a8bb38ab6f
Move exiv2 app into its own folder
3 years ago
256365830a
Replace Metadatum::toLong() with Metadatum::toInt64().
3 years ago
15c91b4cc9
Merge pull request #2101 from Exiv2/main_LinuxDistrosOnPRs
...
Linux distros jobs on PRs + Fix linking issues on some platforms
3 years ago
38254be55e
Install new image_types.h header
3 years ago
b7d5c7e22a
Link against stdc++fs on Linux when it is needed
3 years ago
287744fa12
Merge pull request #2087 from Exiv2/update_canon_tags_2
...
Update canon tags 2
3 years ago
408d80bce8
Change order of ImageType values
3 years ago
f10283f118
bug: Fix crash when calling ImageFactory::create(none)
3 years ago
5a9799ffb2
Replace ImageType namespace by a enum class
3 years ago
0aa34c3098
fix(canon): cleanup canonAf2 and canonAf3 related code
3 years ago
800ed8959f
Rewire Canon MakerNote 0x0026 (AFInfo) to allow TiffDecoder::decodeCanonAFInfo to handle this tag.
...
Minor changes to test script.
Cosmetic code changes.
3 years ago
d19e2d42df
Use AutoRotate
3 years ago
e625f331f9
Include CanonFlashInfo (somehow missing after cherry-picking)
3 years ago
de036b2b2a
Fix remaining wrong brackets
3 years ago
4977b7d5c3
controlmode added
3 years ago
f247014ee6
AEB Bracket Value added
3 years ago
5800942a9b
OpticalZoomCode added
3 years ago
d72ca6806c
ExposureCompensation added
3 years ago
50390717f7
fix wrong brackets
3 years ago
c6b8be5498
wrong brackets fixed
3 years ago
b70a3fb572
Canon AF Info 2 Tag
3 years ago
5cc52feb4b
Adding Canon RawBurst Tag
3 years ago
cf36feaa61
Adding Canon AF Config Tag
3 years ago
56a455422d
Adding LensSerialNumber Tag
3 years ago
e3311b9a4f
canon filter options
3 years ago
d6f1f7c614
Adding of Canon Vignetting Correction Tag 2
3 years ago
8b174900fa
Adding Canon Lighting Optimization Tag
3 years ago
524b33e5df
Canon MultiExposure tag added
3 years ago
e2b1028973
Adding tag Canon AFMicroAdj
3 years ago
80d67b89c6
Adding Ambience Selection to tag list
3 years ago
3ffe9938f8
Decoding of Canon HDRInfo tag
3 years ago
b589ced049
update to tags
3 years ago
5f2dee4d40
update canonrf tags, new lenses
3 years ago
081f458bf1
update tags ID
3 years ago
f41e7e59e3
second rund
3 years ago
23293064bb
work on canon tags
3 years ago
23f089a1b6
Apply suggestions from code review
...
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>
3 years ago
f59a9abfe3
Remove unused PRINTUCS2 CMake option
3 years ago
432555eae8
Replace platform specific code with std::filesystem
3 years ago
fdfb295cc4
windows: Trick to get UTF-8 encoded argv in main entry point
...
- Adapt exifprint to the new wmain strategy
- Delete have_unicode_path
- wmain does not work with MSYS & MinGW
- cmake: entry point via cmake instead of pragma
- cmake: better doc for MSVC flags
- Fix entry point in sample apps
- Adapt CMake code to work with MSVC & MinGW
3 years ago
7933ff401d
Remove dead code around EXV_UNICODE_PATH
3 years ago
2a3dd2def9
Replace Value::toLong with Value::toInt64. ( #2062 )
...
* Replace Value::toLong with Value::toInt64.
* Fix compiler warning.
* Fix compile error.
* Fix declaration of canonEv
* Fix compiler warning.
* Fix compiler warning.
* Use int64_t for offsets in tiffcomposite_int.cpp
* Fix compiler warning.
* Fix compiler warnings.
* Fix compiler warning.
* Fix compiler warning.
* Fix compiler warning.
* Fix compiler warning.
* Remove static_cast<long int> in TagDetails initializer.
3 years ago
f2385a35aa
[nikon] Add Tokina ATX-i 11-20mm F2.8 CF lens ( #2072 )
...
* [nikon] Add Tokina ATX-i 11-20mm F2.8 CF lens
* [nikon] Add test for Tokina ATX-i 11-20mm F2.8 CF lens
Co-authored-by: Sturmflut <Simon Raffeiner>
Co-authored-by: Luis Díaz Más <piponazo@gmail.com>
3 years ago
50f34f4561
[nikon] Add instructions for adding new Nikon F mount lenses
...
- Also cleans up a dead link
3 years ago
eeb1e1d5f7
[nikon] Add Tokina AT-X 14-20 F2 PRO DX lens
3 years ago
1f07715141
Revert "Delete dead code"
...
This reverts commit 1d6bac61f2
3 years ago
b96091880a
Merge pull request #2061 from Exiv2/main_pvs
...
Adding static analysis with PVS-Studio
3 years ago
ac9439e931
Merge pull request #2063 from Exiv2/main_iterators
...
Modernise code around iterators & smart pointers
3 years ago
46c329081f
Fix `exiv2`: verbose extract stdout mutli-file ( #2068 )
...
When using `exiv2 --verbose --extract` with stdout and multiple files, the output is concatenated together.
3 years ago
524fad42e1
Remove useless ops
3 years ago
93fe2086e4
Simplify TaskFactory
3 years ago
f18d04cb8f
Modern implementation of Singleton
...
With this implementation we also make the initialization of the Singleton instance thread-safe
3 years ago
d20f014807
Simplify cloning in actions
3 years ago
b67dee8a57
Fix build on linux
3 years ago
0f03e77634
Simplify code around UniquePtr(s) & use make_unique over new
3 years ago
db4b63937e
Add some TODO comments
3 years ago
9d8dd86945
Use auto to reduce verbosity around code dealing with iterators
3 years ago
3b1d31e0af
Add Sigma 12-24mm F4 DG HSM Art lens for Nikon
3 years ago
a42501864a
Recover some documentation strings
3 years ago
c531c4abf5
More tests for IptcDataSets
3 years ago
476a254dfc
Remove dead code
...
No way to obtain nullptr DataSet* when we are checking already the 2
only existing DataSets above.
3 years ago
9b40f948eb
More tests
3 years ago
15e8c75a38
Delete unused IptcKey copy operator
3 years ago
d8fcbc4562
Add new tests for Iptc classes
3 years ago
df0b7c450d
Hide public details
3 years ago
8f9a780375
clang-format on datasets.cpp
3 years ago
1d6bac61f2
Delete dead code
3 years ago
071e73fa4d
Add many tests for datasets
3 years ago
a94d648d05
Rest of tests to have 100% coverage in BMP class
3 years ago
edf39e00dd
Add new BMP tests
3 years ago
e56abfa10a
Spelling ( #2067 )
...
* spelling: accelerometer
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: address
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: anonymous
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: available
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: baby
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: buffer
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: build
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: builds
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: by inclusion
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: byte order
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: camera
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: command
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: consistency
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: constructor
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: continuous
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: continuously
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: correspond
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: decompression
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dedicated
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: denominator
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dependencies
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: detector
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dlighting
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dragging
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: duplicate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dynamic
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: empty
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: enable
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: endianness
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: examining
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: exceed
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: extension
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: fact
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: fails
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: fixed
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: fluorescent
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: focuspoint
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: focuspoints
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: from
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: happened
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: hierarchy
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: initiate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: interesting
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: internal
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: javascript
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: language
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: libiconv
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: libraries
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: library
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: localization
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: macros
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: member
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: members
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: metadata
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: miscellaneous
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: mnemonic
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: modified
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: multiple
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: multithreaded
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: mysterious
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: photoshop
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: platforms
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: preliminary
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: priority
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: properties
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: qualifier
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: recognition
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: recognized
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: reentrancy
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: remaining
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: remotetest
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: requested
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: sensitivity
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: standardize
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: successful
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: such
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: tags
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: temperature
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: test
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: the
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: these
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: third
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: this
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: transparent
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unable
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: underwater
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: uninterpreted
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: using
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: utc - coordinated universal time
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: which
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: with
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
3 years ago
da320f35a7
Remove experimental code from pr#2053
3 years ago
6c59437319
Add IPTC 2021.1 source comments for pr#2053
3 years ago
fe83240bb8
Update XMP IPTC tags to 2021.1 standard
...
Changes:
1. Add/update tags.
2. According to the standard, several tags in
`Xmp.iptc.<property>` and `Xmp.iptcExt.<property>`, had been
wrongly added, as they only exist as part of a struct used by a
tag. The incorrect tags have been marked as deprecated in the
label and description.
3. Update existing test with translated output.
Ref: [IPTC Photo Metadata Standard 2021.1](https://www.iptc.org/std/photometadata/specification/IPTC-PhotoMetadata-2021.1.html )
3 years ago
b0318c36be
Upgrade C++ standard to c++17 ( #2052 )
...
* Enable C++17 and use new inline specifier for const variable members
* Silence deprecation warning on MSVC
* Disable samples by default
* improvements after review
4 years ago
629442df9d
Merge pull request #1929 from postscript-dev/fix_exiv2_-pR
...
Fix `exiv2 -pR` for Sony images (#1805 )
4 years ago
825c0c72bc
Check array index before inspecting it
4 years ago
240a72468e
Clang-format in pngchunk_int.cpp
4 years ago
ec21f65dca
Replace magicValue with constant variable
4 years ago
ceae86899d
Initialize uninitialized variables
4 years ago
b96f5af037
Remove dead code
4 years ago
061df50cea
keyTXTChunk improvement
4 years ago
c19425f6a4
Add unit tests for PngChunk::keyTXTChunk
4 years ago
c898f56ab2
cmake: Add missing source file
4 years ago
813566526c
Revisiting cmake code for generating coverage reports ( #2047 )
...
* cmake: better usage of gcovr for coverage reports
* Add test for FileIo::setPath
* Remove useless seek() overload
* Add missing override specifiers
* ignore .vs folder
* Small refactors in BasicIo implementations
* Remove duplicated doxygen doc
* Refactor & add tests for MemIO
* Fix compilation warnings on windows
4 years ago
a094dde1de
Merge pull request #2040 from kevinbackhouse/TiffEntryBaseStorage
...
Use std::shared_ptr for storage in TiffEntryBase
4 years ago
b52b6db39f
Output of -PV was not suitable for inputting to -m-, key was missing. ( #1970 )
...
* Output of -PV was not suitable for inputting to -m-, key was missing.
Fix #1969
* Make V flag to -P also print the type
This makes -PV work also for non-built-in tags (of which their type is
not known by exiv2).
* Adjust man to accomodate for the V flag change
4 years ago
9268279b47
Add comments.
4 years ago
b6a4fd1c67
Add storage parameter to setData.
4 years ago
29f7d0ccf0
Remove DataBuf::release() which is no longer used.
4 years ago
9f3240c91c
Delete TiffEntryBase::isMalloced_ field and use a std::shared_ptr instead.
4 years ago
29cc981180
Merge pull request #2028 from kevinbackhouse/FixIssue2027
...
Use memmove in TiffEncoder::updateDirEntry
4 years ago
13a2cf336d
fix_1416_iptc_DateCreated ( #1547 )
...
* fix_1416_iptc_DateCreated
* Fix unit tests
* DateValue:read 2nd iteration on pre-condition
* test with ISO_8601 date format
* Use std::regex for ISO 8601 basic & extended date formats
* Use std::regex for ISO 8601 basic & extended time formats
* Add more tests & notes for DateValue & TimeValue
* Comment tests using local calendar times
* DateValue::write also adds padding to year field
Co-authored-by: Luis Díaz Más <piponazo@gmail.com>
4 years ago
e34eacc467
Use memmove, rather than memcpy, because memory regions might overlap.
4 years ago
fd8447129c
Add more DNG 1.6 tags ( #2023 )
...
* Add more DNG 1.6 tags
* Update CinemaDNG, add more spec links
4 years ago
65fad9db0e
Merge pull request #2007 from kevinbackhouse/FixIssue2006
...
Fix integer overflow in PanasonicMakerNote::printAccelerometer
4 years ago
aebb3fb2c0
Merge pull request #2015 from kevinbackhouse/SonyPreviewUndefined
...
Treat Exif.Sony1.PreviewImage as undefined tag
4 years ago
0a1fa497d5
Merge pull request #1999 from jim-easterbrook/bug_1998
...
Restore modified tags after TZ manipulation
4 years ago
a1ad29edf3
Treat Exif.Sony1.PreviewImage as undefined tag.
4 years ago
35f48ae5c9
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=41438
...
Replace weird sign-conversion code with a simple static_cast.
4 years ago
6758e7288d
Merge branch 'main' into fix_exiv2_-pR
4 years ago
797f86c226
Fix minor whitespace formatting
...
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>
4 years ago
9c294ef4fd
Fix exiv2: verbose extract to stdout (see #1934 )
...
Fix ignores `--verbose` when extracting to stdout.
4 years ago
02ce7e9aff
Restore modified tags after TZ manipulation
...
This ensures that Xmp date/times that have been set by the user aren't
over written by the TZ restoration efforts. This fixes bug #1998
4 years ago
fde8ed07b3
Merge pull request #1967 from kevinbackhouse/ReadOrThrow
...
Add readOrThrow and seekOrThrow to BasicIo
4 years ago
1ae9f42cd8
Add camera models for NikonFl3 makernotes group ( #1994 )
...
* Add camera models for NikonFl3
* Python test for new NikonFl3 camera models
4 years ago
562b10f2c7
Fix Exif.NikonFl7.FlashCompensation
4 years ago
bd676bedc6
Fix `exiv2 -pR` for Sony images ( #1805 )
...
`exiv2 -pR` failed to process Sony makernotes. Fix checks if
makernotes header has Sony string, then uses correct offset.
Fix supplied by @clanmills
4 years ago
277b1875f7
Fix Exif.NikonFl7.FlashGroupBCControlData output
4 years ago
b3ca98c1e7
Fix Exif.NikonFl7.FlashCompensation pretty print
4 years ago
8ebf10f921
Fix condition in Exif.NikonFl7.FlashCompensation
4 years ago
f23d965643
Add limits check: Exif.NikonFl7.FlashCompensation
4 years ago
f0f3c7e8a2
Fix compile issues for NikonFl7 makernotes group
...
+ Fix fuzzing CI errors of `exp2` and `round` not being in `std` by adding
`#include <cmath>`
+ Fix Windows CI warning C4305 by explicitly defining value as a float
4 years ago
eb134d1946
Add testing for NikonFl7 makernotes group
4 years ago
ab90d430c7
Merge pull request #1979 from postscript-dev/fix_exiv2_sample_thumb_stdout
...
Add exiv2 extract thumb to stdout (#1934 )
4 years ago
68473d9d10
Remove static functions readOrThrow and seekOrThrow.
4 years ago
44542a9f94
Add readOrThrow and seekOrThrow to BasicIo.
4 years ago
8b7d8729b7
Expose unsupported CR3 previews as binary
4 years ago
31a2467a61
Add exiv2 extract thumb to stdout ( #1934 ): src
4 years ago
40e5021577
Limit CR3 previews to JPEG only
4 years ago
0ae85cc4ca
Merge pull request #1974 from dhoulder/skip-isobmff-boxes
...
Performance boost: don't read boxes we're not interested in
4 years ago
2d80891837
Only include expat.h when XMP is enabled. ( #1973 )
...
(cherry picked from commit 03cc59122249e79c5a72982b25dad88f4c2803d6)
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>
4 years ago
4e587fa931
Performance boost: don't read boxes we're not interested in
4 years ago
b385f2db1c
Canon cr3 previews ( #1958 )
...
* Extract THMB and PRVW images from Canon CR3 file
* Added test for Canon CR3 preview extraction.
Added test data Canon-R6-pruned.CR3 (first 492016 bytes of https://raw.pixls.us/getfile.php/4659/nice/Canon%20-%20Canon%20EOS%20R6%20-%203:2.CR3 ).
See https://github.com/Exiv2/exiv2/issues/1893
* Fixed format specifier
* Update src/bmffimage.cpp
Co-authored-by: Miloš Komarčević <4973094+kmilos@users.noreply.github.com>
* Update src/bmffimage.cpp
Co-authored-by: Miloš Komarčević <4973094+kmilos@users.noreply.github.com>
* retrigger checks
Co-authored-by: Miloš Komarčević <4973094+kmilos@users.noreply.github.com>
4 years ago
71744d5f7f
Merge pull request #1944 from Exiv2/nikon_colorbalance
...
Extending Nikon3.ColorBalance version coverage
4 years ago
81cfc162c1
Use std::move to transfer ownership of DataBufs.
4 years ago
4901c5dba6
Merge pull request #1930 from kevinbackhouse/CiffComponent-pData-ownership
...
Clarify ownership model of CiffComponent::pData_
4 years ago
3b0d827047
More =default changes.
4 years ago
5fdd9da3d3
Use =default.
4 years ago
2074f82344
Fold into common 02xx versions
4 years ago
4205e03c43
Extending Nikon3.ColorBalance version coverage
4 years ago
be5a01f0b2
Merge pull request #1921 from kevinbackhouse/FixIssue1920
...
Fix UBSAN failure caused by left-shift of negative number
4 years ago
83b9944cdd
We only need to extract one byte.
4 years ago
887acd098a
Merge pull request #1926 from postscript-dev/fix_sony_temperature_tags
...
Add conditions to 2 Sony temperature tags
4 years ago
02d40734a1
Update canonmn_int.cpp
...
Correct Exif.CanonCs.LensType 38 for "Canon EF 80-200mm f/4.5-5.6 II"
4 years ago
482cb2ded5
Clarify ownership model of CiffComponent::pData_
4 years ago
b27aa0b82c
Merge pull request #1922 from postscript-dev/fix_sony_tags
...
Add SonyMisc(2b|3c) Groups for Sony TIFF files
4 years ago
54ee165261
Add conditions to 2 Sony temperature tags
...
Only certain camera models are supported.
Source: https://github.com/exiftool/exiftool/blob/master/lib/Image/ExifTool/Sony.pm
4 years ago
45fe046a9c
Update src/tiffimage_int.cpp
...
Co-authored-by: Miloš Komarčević <4973094+kmilos@users.noreply.github.com>
4 years ago
193eea1913
Update src/tiffimage_int.cpp
...
Co-authored-by: Miloš Komarčević <4973094+kmilos@users.noreply.github.com>
4 years ago
7ace96263e
Add SonyMisc(2b|3c) Groups in TIFF files
...
- Previous version only supported JPEGs.
- Update Python test to use more specific grep, as this prevents
SonyMisc(2b|3c) from being included. Regression test to be added
in a different commit.
4 years ago
a71bb64fe9
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=39060
...
Fix UBSAN failure caused by left shift of a negative number.
4 years ago
1491b106d9
fix for reading jpeg-xr images
4 years ago
8a1e949bff
fix out of range access, minor performance improvement
4 years ago
7d2eb4ad09
Merge pull request #1905 from postscript-dev/update_website_docs
...
Update website docs
4 years ago
be296814c1
Merge pull request #1913 from kevinbackhouse/FixIssue1912
...
Fix integer overflow in print0x0007
4 years ago
cd4316c4f5
Do the calculation in floating point to avoid integer overflow.
4 years ago
04f4624718
Explicitly test for libproc.h ( #1916 )
...
This change adds support for ancient macOS lacking libproc. It also
eliminates a bug where exiv2 could not be built on case-sensitive
file systems (the header file is properly TargetConditionals.h).
4 years ago
801e20123a
Merge pull request #1902 from kevinbackhouse/FixIssue1901
...
Comment out bogus code in XMPUtils.cpp
4 years ago
d92b0a6717
Merge pull request #1910 from kevinbackhouse/PentaxQuadraticPrint
...
Fix quadratic loops in pentaxmn_int.cpp
4 years ago
7cb65d1e25
Merge pull request #1872 from postscript-dev/update_exiv2_manpage
...
Update exiv2 program and manpage
4 years ago
9f1e3e3e72
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=38887
...
Fix quadratic loops.
4 years ago
f643d9bb5e
Annotate some strings with xgettext:no-c-format
...
Some descriptions of location properties contain the text "100%
overlap". When extracting text for translation, `xgettext`
misidentifies this as containing the C format string "% o", and tags it
as `c-format`. Translation tools that are sensitive to this will
require that translations contain matching format strings; since in this
case the format string is nonsensical, that is often not reasonably
possible. See:
https://answers.launchpad.net/launchpad/+question/698762
The description of the DotRange tag contains the text "0% dot and 100%
dot", which is similarly misidentified.
To fix this, inform `xgettext` that the messages do not contain C format
strings, as documented here (towards the end):
https://www.gnu.org/software/gettext/manual/html_node/c_002dformat-Flag.html
4 years ago
098283c1f8
Merge branch 'Exiv2:main' into update_website_docs
4 years ago
c4e73831f2
Add missing MpfInfo group to `taglist.exe Exif`
4 years ago
e1e7dddfbd
Fix test failure.
4 years ago
795cfe90ce
Update exiv2 program, --help and usage
4 years ago
bb9ff53ebe
Throw an exception on integer overflow.
4 years ago
e71b99b236
Merge pull request #1886 from kevinbackhouse/private-pData
...
Make fields of DataBuf private
4 years ago
bd211a90ac
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=37889
...
Avoid reading 1 byte off the end when the string does not contain a '\0' byte.
4 years ago
9ff72e5ca5
Make offset=0 the default parameter.
4 years ago
61a14c45d1
Fix build failure.
4 years ago
e41f0c2cce
Fix build failure on Windows.
4 years ago
c9d0cf3643
Make fields of DataBuf private.
4 years ago
cb16324bcf
Merge pull request #1882 from kevinbackhouse/FixIssue1881
...
Throw an error if the size of the preview is greater than 1MB
4 years ago
ccfdcf84ea
Merge pull request #1824 from 1div0/JPEG XL
...
Corrected JPEG XL file type
4 years ago
67746dee73
Merge pull request #1874 from neheb/emp
...
remove most usages of std::make_pair
4 years ago
ce02361a64
Only build XMLValidator when XMP is enabled.
4 years ago
60144df557
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=37492
...
Throw an error if the size of the preview is greater than 1MB.
4 years ago
b35cc5ffa6
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=37363
...
Do some basic XML validation before running the xmpsdk library to avoid bugs in xmpsdk.
4 years ago
e7eddfc2f5
use more emplace_back
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
f3fcffd6e6
remove most usages of std::make_pair
...
Better alternatives exist with C++11.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
fbdb38b959
Add missing `--extract` option to exiv2 program
...
The long option version of `-e` was missing.
4 years ago
64fe77673f
Decouple EXIV2_BUILD_FUZZ_TESTS from EXIV2_TEAM_USE_SANITIZERS.
4 years ago
a1b65a7928
Merge pull request #1849 from Exiv2/mergify/bp/main/pr-1848
...
Replace assertion with an error message (backport #1848 )
4 years ago
0dc5cdd910
Merge pull request #1852 from Exiv2/mergify/bp/main/pr-1846
...
Replace assertion with error message in TiffDirectory::writeDirEntry() (backport #1846 )
4 years ago
330483a859
Merge pull request #1843 from Exiv2/mergify/bp/main/pr-1840
...
Check that the float is within the range of an int before casting (backport #1840 )
4 years ago
9fd8b40a4e
Replace assertion with an error message.
...
(cherry picked from commit cb32b809c80163c2392543dfb830dffe44e47f91)
4 years ago
66259b1c71
Check if embedded RAF image is really a TIFF (backport #1796 ) ( #1851 )
...
* Check if embedded RAF image is really a TIFF
(cherry picked from commit be12ae6f9e2f053bf101902865deadfe7c937f8d)
* Clarify comment on old vs new RAF
Co-authored-by: Christoph Hasse <hassec@users.noreply.github.com>
(cherry picked from commit 30f39ac98c1671547aa0b4021081e374864f1f04)
* Check I/O read result on RAF inspection
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>
(cherry picked from commit 09de8dc901a38555151bd87d89ada3bd931451ea)
* Add test
(cherry picked from commit 9c3db7f3c3cb48fe0669061e627174402f366816)
Co-authored-by: Miloš Komarčević <miloskomarcevic@aim.com>
Co-authored-by: Miloš Komarčević <4973094+kmilos@users.noreply.github.com>
4 years ago
9e160a453b
Replace assertion with an error message.
4 years ago
1d095cf751
Removed tag handled separately
4 years ago
5bc444ff00
Use DataBuf rather than raw malloc.
4 years ago
7c2ab1d7de
Check that the float is within the range of an int before casting.
4 years ago
0fab606e90
fix: incorrectly triggered enforce check during preview extraction in LoaderTiff::getData(), closes #1829
4 years ago
e34e150f22
Replace assertion with an error message.
...
(cherry picked from commit 4ec1768415ba015041a9bb28ab17c1ccf6a8c63e)
4 years ago
ed1db4ace2
Use std::round for rounding to nearest.
4 years ago
8d5e70379e
Update src/tags_int.cpp
...
Co-authored-by: Christoph Hasse <hassec@users.noreply.github.com>
(cherry picked from commit ad2e7221b498258bd04188b66f6da5cefd101e73)
4 years ago
52d70c8924
Check value is in range before casting from double to uint32_t, to avoid undefined behavior.
...
(cherry picked from commit 1455cc88466a14d8ea49935005e9de097984f012)
4 years ago
0e7d80fc84
Merge pull request #1826 from Exiv2/mergify/bp/main/pr-1820
...
Check that the string isn't empty (backport #1820 )
4 years ago
db25089c6f
Merge pull request #1823 from Exiv2/mergify/bp/main/pr-1818
...
Fix memory leak in pngimage.cpp (backport #1818 )
4 years ago
34aa899513
Merge pull request #1825 from Exiv2/mergify/bp/main/pr-1814
...
jp2image.cpp: check size before allocation to avoid out-of-memory errors (backport #1814 )
4 years ago
644aaaac92
Check that the string isn't empty
4 years ago
ffde235336
Add comment to explain the bounds-check.
4 years ago
67e2ef5ccd
Check size before allocation to avoid out-of-memory errors.
4 years ago
8f889c132e
Corrected JPEG XL file type
4 years ago
c641116b25
Add static_cast to fix build error on Windows.
4 years ago
b8ed3867c0
Use DataBuf, rather than new[], for automatic delete when an exception is throw.
4 years ago
dd4659ce2d
Add bounds-check to prevent out-of-bounds read in memcmp.
...
(cherry picked from commit a6253799d4e3727e32e6412798dceca4200efdda)
4 years ago
0144209ed0
Add SonySInfo1 makernote tags (tag 3000)
...
Add all tags, except the face detection sub-groups and related
bookkeeping values.
Source: Exiftool (https://exiftool.org/TagNames/Sony.html )
4 years ago
2488fc82e9
Merge pull request #1804 from kevinbackhouse/FuzzMore
...
Add fuzzing dictionary and test all printStructure() options
4 years ago
e086c7cbd2
add Canon EF 100-400 2x, and make size of aperture lens matching delta dependent on teleconverter factor
4 years ago
7d2f2d2526
make the ifdef in getExiv2ConfigPath a bit more minimal
4 years ago
95c2c26747
Fixes for Max and Win
4 years ago
6d5407e851
first search cwd for config file then check home dir
4 years ago
6fd6c8b3dd
fix: SIGSEGV on parsing of config file. (introduced in main by clang-tidy fix)
4 years ago
22b876d278
Merge pull request #1800 from postscript-dev/add_SonyMisc3c_tags
...
Add SonyMisc3c makernote tags (tag 9400)
4 years ago
593fcbd865
Add fuzzing dictionary and test all printStructure() options
4 years ago
35a2b25d64
Fix build error when EXIV2_DEBUG_MESSAGES is enabled.
4 years ago
2532f6db40
Add `markerHasLength` utility function.
4 years ago
96b85751ee
Add comment to explain bounds-check.
4 years ago
10bd09871f
Update src/jpgimage.cpp
...
Co-authored-by: Christoph Hasse <hassec@users.noreply.github.com>
4 years ago
fed192dc97
Fix compiler warning.
4 years ago
483a1497a0
Improved handling of jpg segments to avoid out-of-bound reads.
4 years ago
deb41bd117
bufRead needs to be adjusted after seek()
4 years ago
cc9d780534
Add SonyMisc3c makernote tags (tag 9400)
...
Changes:
+ Add tags. Rename Exiftool `SequenceLength` tags to `SequenceLength1`
and `SequenceLength2`, to prevent a name clash.
+ Update docs and manpage.
Source: [Exiftool](https://exiftool.org )
4 years ago
01b109e8ff
Merge pull request #1798 from Exiv2/mergify/bp/main/pr-1789
...
&bytes[0] (std::vector) will crash if bytes has zero elements (backport #1789 )
4 years ago
c3239e3187
&bytes[0] will crash if bytes has zero elements.
...
(cherry picked from commit 3e72d129e53b14e0b62d74aefed6bbd326562d63)
4 years ago
9004fb5a97
Remove redundant check.
...
(cherry picked from commit 19026fab2bc2b6dee2150f38153feb65a41cea17)
4 years ago
07225c05ee
Make sure that read is complete to prevent infinite loop.
...
(cherry picked from commit ffe5eb517dad93845e62144d8e53f52b17420ecd)
4 years ago
7251a96da6
remove exv_grep_keys_t type alias
4 years ago
d6c82b88bc
refactor: avoid unused variable warning of regex_error
4 years ago
687b38a130
refactor: use POSIX regex syntax as that is what was used before
4 years ago
d82980b563
refactor: replace old linux regex.h with regex from STL.
4 years ago
944e68fa15
Merge pull request #1787 from Exiv2/mergify/bp/main/pr-1766
...
Extra checking to prevent loop counter from wrapping around (backport #1766 )
4 years ago
686702616c
Merge pull request #1794 from kevinbackhouse/bmff-check-box-nesting
...
Enforce BMFF box nesting
4 years ago
3575a8258e
Merge pull request #1786 from Exiv2/mergify/bp/main/pr-1769
...
Safer std::vector indexing (backport #1769 )
4 years ago
9aabdcf698
fix: add Sigma 30mm f/1.4 DC DN | C to canon lens detection
4 years ago
5eb464271e
Fix format specifier.
4 years ago
43d95b8a75
Fix compiler warnings.
4 years ago
3019fbee4f
Extra protection against large allocations.
4 years ago
78e9c8aa82
address + box_length == box_end
4 years ago
02d4ef2c5e
Support for 64-bit box lengths looked broken.
4 years ago
8c64e9abba
Add `pbox_end` param to `BmffImage::boxHandler` to enforce box nesting.
4 years ago
293fd586ab
Add SonyMisc2b makernote tags (tag 9404)
...
Changes:
+ Add tags, pretty printing and tag group selector function
+ Update docs
Source: https://exiftool.org/TagNames/Sony.html
4 years ago
b82084995c
Add `getExifValue()` to `makernote_int.cpp`
...
Function generalizes `getExifModel()`, allowing any value in a tag to
be accessed.
4 years ago
eb2782e685
Fix warning: comparison of integer expressions of different signedness
4 years ago
67a46f742d
Type of escapeStart should be size_t.
4 years ago
670dfb2fab
Better fix for potential integer overflow in `bytes.size() - 3`.
4 years ago
69d82ffe01
Defensive coding changes to avoid integer overflow in loop conditions.
4 years ago
ad5e6c479c
Extra checking to prevent the loop counter from wrapping around.
4 years ago
dc2c77ce81
Safer std::vector indexing.
4 years ago
82057a6a1d
Merge pull request #1777 from postscript-dev/update_sony2fp_tags
...
Update Sony2Fp tags
4 years ago
d5ada325af
Check that `type` isn't an empty string.
4 years ago
510a38e27d
Move all `startsWith()` funcs to `Util` namespace
...
The function checks if a string is in the beginning of another. This
is intended for use until the move to C++20 when
`std::basic_string<>::starts_with()` becomes available. Suggested in
https://github.com/Exiv2/exiv2/pull/1777 .
Separate identical definitions have been moved into a single copy.
4 years ago
0827a76b6a
Update Sony2Fp makernote functions
...
Minor changes using suggestions in #1777 :
+ Simplify loop conditions
+ Add startsWith() in SonyMakerNote class
+ Change `if`/`else` to `switch`
4 years ago
e4e3362284
Defensive programming in Image::printIFDStructure
4 years ago
caf08b229e
dirLength == 0 can cause an infinite loop.
4 years ago
0208b508a0
Merge pull request #1773 from kevinbackhouse/fuzz
...
Add fuzz target
4 years ago
fa52d7e2cb
Better way to print the error message.
4 years ago
6685b8db4a
Print message to stderr when EXIV2_DEBUG_MESSAGES is enabled.
4 years ago
f724f4e2fc
Don't crash if s > size.
4 years ago
e821404d69
Merge branch 'update_sony2fp_tags' of https://github.com/postscript-dev/exiv2 into update_sony2fp_tags
4 years ago
4a21b45e60
Update Sony2Fp makernote tag selector function
...
In C++20, std::string has a starts_with() function. Add a startsWith()
function now, which can be replaced when the project moves to C++20.
Suggested in https://github.com/Exiv2/exiv2/pull/1777
4 years ago
670c89b2bd
Merge branch 'Exiv2:main' into update_sony2fp_tags
4 years ago
4ac8ac9ba0
Update Sony2Fp makernote tags (tag 9402)
...
Changes:
+ Add pretty printing for all tags
+ Add camera selector, to prevent incompatible models using tags
+ Update testing with new values
Source: Exiftool (https://exiftool.org/TagNames/Sony.html )
4 years ago
6798be637f
Merge pull request #1774 from Exiv2/mergify/bp/main/pr-1745
...
fix: avoid processing MOV (quicktime) files when BMFF is enabled (backport #1745 )
4 years ago
7b3dd26c23
Merge pull request #1718 from opengisch/ios
...
Fix building for ios
4 years ago
eb22591cea
Fix formatting of sonyMisc1 makernote tags
4 years ago
3e681c6730
fix: avoid processing MOV (quicktime) files when BMFF is enabled
...
(cherry picked from commit 1b6895927f293855e5bb437ad28f31da2c2cfe54)
4 years ago
bf786f4cc6
Updates to make fuzzing work.
4 years ago
2b8856dcea
Add SonyMisc1 (Tag 0x9403) makernote tags
...
Source: Exiftool (https://exiftool.org/TagNames/Sony.html )
4 years ago
033175e127
Don't deref end iterator.
4 years ago
43fe7bbb98
Add Exif.Image.PageName tag ( #1765 )
...
* Add Exif.Image.PageName tag
* Add trailing punctuation mark to PageName and DocumentName tags description.
* Add XPosition and YPosition TIFF tags
4 years ago
ff00771425
Better bounds checking in Jp2Image::printStructure
...
(cherry picked from commit 0fcdde80997913dde284ea98f06f9305d06cb160)
4 years ago
c2b52119d4
Check that findKey didn't return end().
4 years ago
98fb218475
Throw exception if lens info wasn't found.
4 years ago
d30c95d07e
fix incorrect loop condition ( #1752 )
4 years ago
5ab3f2b0c5
Defensive coding to avoid 0x80000000/0xFFFFFFFF FPE.
4 years ago
11a26fb0d4
Prevent divide-by-zero crash.
4 years ago
8c4d67ca50
Defensive coding to avoid 0x80000000/0xFFFFFFFF FPE.
4 years ago
d5b7f99fbf
Three tag descriptions corrected
4 years ago
37fea97dd3
clang-tidy: use override
...
Found with modernize-use-override
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
b84d8e9a44
clang-tidy: use auto
...
Found with modernize-use-auto
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
9210fb85f9
clang-tidy: pass by value
...
Found with modernize-pass-by-value
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
b16cd52b88
Replace sprintf with snprintf.
4 years ago
2fbf2e6b7c
clang-tidy: remove dedundant initializer
...
Found with readability-redundant-member-init
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
a4c5bdac19
fix: stricter date parsing in value.cpp ( #1720 )
...
* Regression test for issue 1713
* Stricter date parsing.
* Fix test failure caused by stdout mismatch.
(cherry picked from commit ab58026cff0e5edebc026261e9dc4b7db05b802d)
4 years ago
1d64f482ff
fix: use vector::at() rather than operator[] (backport #1735 ) ( #1741 )
...
* fix: use vector::at() rather than operator[] (#1735 )
* Regression test for https://github.com/Exiv2/exiv2/issues/1706
* Use vector::at() rather than operator[].
* Print to stderr when exception is caught and EXIV2_DEBUG_MESSAGES is enabled.
* Check that it prints "Bad value" for the date.
(cherry picked from commit f4d3adbf91e6dc4e34aee5bac7b7fd9e127a5c00)
# Conflicts:
# src/value.cpp
* fix merge conflicts from mergify backport
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>
Co-authored-by: Christoph Hasse <hassec@users.noreply.github.com>
4 years ago
2b84f4bd64
fix: zero initialize local variables. ( #1743 )
...
* Zero initialize local variables.
* Initialize xmpID_
4 years ago
3e099da7b7
Remove obsolete snprintf macros.
4 years ago
2539e5dd7e
fix: change duplicated Canon RF 100-500 2x into missing 1.4 teleconverter version
4 years ago
704ee571de
fix: allow for FX.Y syntax in aperture regex
4 years ago
fa78ab3593
Use official Canon RF lens model names
...
The new RF line is named F2.8L instead of f/2.8L (for example).
This patch makes the model names identically to the official
Canon lens names and the same names exiftool uses.
4 years ago
2f83b7e0f6
Merge pull request #1692 from Exiv2/hassec_canon_lens_test
...
New Canon Lens Identification + Automatic Test of all Lenses
4 years ago
cfeceee416
add lens: Olympus M.ZUIKO DIGITAL ED 12-45mm F4.0 PRO ( #1725 )
...
* add lens ID for Olympus M.Zuiko Digital ED 12-45mm F4.0 Pro #1723
* add test for #1723 checking the Olympus M.Zuiko Digital ED 12-45mm F4.0 Pro recognized correctly
4 years ago
5aafb351e5
Fix building on ios
4 years ago
23dbf4f51a
correct identification for Tamron SP 24-70mm G2 A032 ( #1691 )
...
* correct identification for Tamron SP 24-70mm G2 A032 with LensType 0E (14)
Existing entry with LensType 4E is kept as it's needed as well
Added testcase for LensType 0E for Tamron_SP_24-70mm_F2.8_Di_VC_USD_G2
4 years ago
efb0af8506
fix: make casts explicit to please msvc
4 years ago
7867343611
fix: prefer symbolic boolean operators so windows is happy
4 years ago
bdd8a386b5
feat: improve lens recognition of canon makernote
...
If multiple choices are possible they are now all reported. This
behaviour is now the same as it is in exiftool.
All lenses are tested in the new test_canon_lenses.py test
4 years ago
907fe2369e
fix: readd some previously removed lenses now that we plan to trea ambiguous lenses
4 years ago
4ee8962d42
refactor!: use lensfun style nameing for lenses
4 years ago
56f9979a4b
Improve detection of Canon lenses with TC
...
Lenses with and without a TC may share the same lens ID. Prefer entries
that explicitly mention the TC.
4 years ago
9962b88db3
Fix misdetection of Tamron SP AF 300mm as Canon EF 75-300mm
...
When searching for the Tamron lens, only the string "300mm" is searched in
the lens description, which also happens to be present for the Canon lens.
Since the Canon lens comes first in the list, it wins. Fix this issue by
prefixing the search string with a single space so it always has to match
the full focal length specification.
4 years ago
477150f067
Fix rounding error in fnumber calculation
...
The mathematical calculation of fnumbers does not always match the expected
values: For example for f/3.5 the precise mathematical value is 3.564...,
which gets rounded to 3.6. Fix this special case by returning a value
closer to the expected value.
4 years ago
0d030eefdf
Remove undetectable lenses
...
Lenses that have the exact same ID, focal length and aperture as some other
lens that comes earlier in the list (and thus always wins):
* 137, "Tamron SP 17-50mm f/2.8 XR Di II VC"
* 137, "Tamron SP 24-70mm f/2.8 Di VC USD"
* 161, "Sigma 28-70mm f/2.8 EX"
* 173, "Sigma 180mm EX HSM Macro f/3.5"
* 180, "Zeiss Milvus 50mm f/1.4"
* 183, "Sigma 150-600mm f/5-6.3 DG OS HSM | S"
* 254, "Tamron SP 90mm f/2.8 Di VC USD Macro 1:1 F004"
* 254, "Tamron SP 90mm f/2.8 Di VC USD Macro 1:1 F017"
Lenses that share their IDs with other lenses, but have no or an
unsupported focal length:
* 33, "Voigtlander or Carl Zeiss Lens"
* 131, "Sigma 4.5mm f/2.8 EX DC HSM Circular Fisheye"
4 years ago
f30022d73d
Fix issues detected with PVS-Studio + other little improvements ( #1689 )
...
* avoid re-declaration of constant variables
* Replace pthreads critical section with std::mutex
* ci - better naming
* cmake - increase minimum version to 3.11. Use project DESCRIPTION
* fix - do not treat string::find() return type as bool
* remove conditions that were always true
* remove condition that were always false
* Remove EXV_HAVE_GMTIME_R which is not used anymore
* pixelWidth_ was inherited from Exiv2::Image
The width & height variables in the TiffImage class need to be mutable
to be able to change their values on the getters pixelHeight() and
pixelWidth() ... Do not ask me why ...
* Remove superfluous if
* pvs:V766 item with identical key added already
* pvs:V730 not all members were initialized (time)
* pvs:V730 not all members are initialized
* pvs:v668 no point in testing pointer against null after new
* pvs:V1048 variable assigned the same value
* replace c-style dynamic vector with std one
* pvs:547 fakeData is always true
* Remove useless constructor in derived class
* pvs:V690 modern way to disable copy-ctor
* Replace malloc/free with new/delete. No need to check for null
* pvs:V1028 cast operands and not result
* Remove custom MIN/MAX functions
* pvs:V595 pointer used before verified against null
* pvs: index used before being checked
* pvs:V1028 possible overflow. Cast operands
* pvs:v575 potential null pointer passed to other functions
* pvs:V547 deal with always true/false expressions
* pvs:V560 part of conditional expressions always false or true
* pvs:V701 possible break in realloc -> move to std::vector
* Make some classes 'final'
* Replace sprintf with std::to_string()
* fix compilation on windows
4 years ago
758dd6bbc6
refactor!: remove free() function from DataBuf to avoid potential problems, see #1542
4 years ago
2c57f214c5
clang-tidy: use nullptr
...
Found with modernize-use-nullptr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
86c71ae6c3
clang-tidy: avoid global non const variables
...
Found with cppcoreguidelines-avoid-non-const-global-variables
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
d1e116a8ef
remove some pointless std::set
...
Partially found by gcc's -fanalyzer
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
4c4f8da338
remove initializers
...
these were moved outside the constructor body.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
e5894d71e1
default con/destructors in headers
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
ce47de67b5
use auto in template
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
c44c289d76
clang-tidy: fix ending namespace comnments
...
Found with llvm-namespace-comment
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
a74bceacb0
clang-tidy: remove pointless return
...
Found with readability-redundant-control-flow
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
743da1a564
clang-tidy: use C++ casting
...
Found with google-readability-casting
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
8dbc699858
clang-tidy: add missing explicit
...
Found with google-explicit-constructor
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
ff39473c18
clang-tidy: convert to static
...
Found with readability-convert-member-functions-to-static
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
6da49fd29b
more constexpr
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
cdbee3c26c
clang-tidy: init in member initializer
...
Found with cppcoreguidelines-prefer-member-initializer
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
036af68a71
remove pointless constructors
...
Replaced with Uniform initialization. Allows constexpr usage.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
8564d0b394
clang-tidy: pass by value
...
Found with modernize-pass-by-value
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
f9d394adf0
clang-tidy: run through performance checks
...
Found with performance*
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
b8712188bb
clang-tidy: use auto
...
Found with modernize-use-auto
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
20dfab8036
manual for range loop conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
8e52032ee0
clang-tidy: range loop conversions
...
Found with: modernize-loop-convert
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
c73dfa0106
clang-tidy: use uppercase numeric literals
...
Found with readability-uppercase-literal-suffix
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
8e178e912e
replace {} initialization with fill
...
Old compilers don't implement {} correctly.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
fdf9d3799c
clang-tidy: don't use else after return
...
Found with llvm-else-after-return
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
4aa5566cf6
clang-tidy: make several member functions const
...
Found with readability-make-member-function-const
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
24a8139233
clang-tidy: fix badly indented if
...
Found with readability-misleading-indentation
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
1b9b77c51f
clang-tidy: add ending namespace comments
...
Found with google-readability-namespace-comments
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
bf290e84e5
fix compilation with EXIV2_DEBUG_MESSAGES
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
4 years ago
3416b631c5
Add Sony ARW compression to dict
4 years ago
Rosen Penev
Luis Díaz Más
Robin Mills
Michael Allman
Kevin Backhouse
Christoph Hasse
Alex Esseling
Christoph Hasse
Sturmflut
Sturmflut
Peter
Josh Soref
Facundo
Miloš Komarčević
Jim Easterbrook
Miloš Komarčević
mergify[bot]
David Houlder
John55h
Dmitry Fedorov
Dmitry Fedorov
Heiko Bauke
Evan Miller
Colin Watson
Peter Kovář
postscript-dev
Andrea Giudiceandrea
norbertwg
Daniel Vogelbacher
andyrtr
Matthias Kuhn
nulllinie
Alexander Steffen